Skip to content

Commit d1bd2d0

Browse files
Merge pull request #157 from yasinBursali/fix/comfyui-security-hardening
fix(comfyui): harden port binding and security options
2 parents b9b6fc8 + e268d29 commit d1bd2d0

2 files changed

Lines changed: 8 additions & 5 deletions

File tree

dream-server/extensions/services/comfyui/compose.amd.yaml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,8 @@ services:
99
group_add:
1010
- "${VIDEO_GID:-44}"
1111
- "${RENDER_GID:-992}"
12-
cap_add:
13-
- SYS_PTRACE
1412
security_opt:
15-
- seccomp:unconfined
13+
- no-new-privileges:true
1614
shm_size: 8g
1715
environment:
1816
- HSA_OVERRIDE_GFX_VERSION=11.5.1
@@ -21,7 +19,7 @@ services:
2119
volumes:
2220
- ./data/comfyui/ComfyUI:/opt/ComfyUI
2321
ports:
24-
- "${COMFYUI_PORT:-8188}:8188"
22+
- "127.0.0.1:${COMFYUI_PORT:-8188}:8188"
2523
command: >-
2624
/bin/sh -c "/opt/comfyui-gfx1151-utils/check-comfyui.sh &&
2725
python3 /opt/ComfyUI/main.py --listen 0.0.0.0 --use-flash-attention"

dream-server/extensions/services/comfyui/compose.nvidia.yaml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,10 @@ services:
55
dockerfile: Dockerfile
66
container_name: dream-comfyui
77
restart: unless-stopped
8+
security_opt:
9+
- no-new-privileges:true
810
ports:
9-
- "${COMFYUI_PORT:-8188}:8188"
11+
- "127.0.0.1:${COMFYUI_PORT:-8188}:8188"
1012
volumes:
1113
- ./data/comfyui/models:/models
1214
- ./data/comfyui/output:/output
@@ -15,6 +17,9 @@ services:
1517
shm_size: '8g'
1618
deploy:
1719
resources:
20+
limits:
21+
cpus: '16.0'
22+
memory: 24G
1823
reservations:
1924
devices:
2025
- driver: nvidia

0 commit comments

Comments
 (0)