From 1c037ba53352a6e63c309a45cb9cefa9e9fc3dac Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 6 Apr 2026 01:15:17 +0000 Subject: [PATCH 1/3] build(deps): bump mypy from 1.19.1 to 1.20.0 in /requirements Bumps [mypy](https://github.com/python/mypy) from 1.19.1 to 1.20.0. - [Changelog](https://github.com/python/mypy/blob/master/CHANGELOG.md) - [Commits](https://github.com/python/mypy/compare/v1.19.1...v1.20.0) --- updated-dependencies: - dependency-name: mypy dependency-version: 1.20.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- requirements/typing.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/requirements/typing.txt b/requirements/typing.txt index 280071632aa6e..0e8010a78c0ef 100644 --- a/requirements/typing.txt +++ b/requirements/typing.txt @@ -1,5 +1,5 @@ torch==2.9.1 -mypy==1.19.1 +mypy==1.20.0 types-Markdown types-PyYAML From 241fc0af5d369ccd998238b91e33a39706121870 Mon Sep 17 00:00:00 2001 From: bhimrazy Date: Tue, 7 Apr 2026 13:37:42 +0545 Subject: [PATCH 2/3] fix: remove type ignore comments for precision handling in connector and accelerator_connector --- src/lightning/fabric/connector.py | 4 ++-- src/lightning/fabric/plugins/collectives/torch_collective.py | 2 +- src/lightning/fabric/utilities/registry.py | 4 +--- .../pytorch/trainer/connectors/accelerator_connector.py | 4 ++-- 4 files changed, 6 insertions(+), 8 deletions(-) diff --git a/src/lightning/fabric/connector.py b/src/lightning/fabric/connector.py index b3289debbd522..ad028def5b656 100644 --- a/src/lightning/fabric/connector.py +++ b/src/lightning/fabric/connector.py @@ -469,7 +469,7 @@ def _check_and_init_precision(self) -> Precision: f" Choose a different precision among: {', '.join(mp_precision_supported)}." ) if self._precision_input in ("16-true", "bf16-true"): - return HalfPrecision(self._precision_input) # type: ignore + return HalfPrecision(self._precision_input) if self._precision_input == "32-true": return Precision() if self._precision_input == "64-true": @@ -493,7 +493,7 @@ def _check_and_init_precision(self) -> Precision: else "Using bfloat16 Automatic Mixed Precision (AMP)" ) device = self._accelerator_flag if self._accelerator_flag in ("cpu", "mps") else "cuda" - return MixedPrecision(precision=self._precision_input, device=device) # type: ignore[arg-type] + return MixedPrecision(precision=self._precision_input, device=device) raise RuntimeError("No precision set") diff --git a/src/lightning/fabric/plugins/collectives/torch_collective.py b/src/lightning/fabric/plugins/collectives/torch_collective.py index 182e75f4583ef..df8ad8801a8a9 100644 --- a/src/lightning/fabric/plugins/collectives/torch_collective.py +++ b/src/lightning/fabric/plugins/collectives/torch_collective.py @@ -199,7 +199,7 @@ def destroy_group(cls, group: CollectibleGroup) -> None: # can be called by all processes in the default group, group will be `object()` if they are not part of the # current group if group in dist.distributed_c10d._pg_map: - dist.destroy_process_group(group) # type: ignore[arg-type] + dist.destroy_process_group(group) @classmethod @override diff --git a/src/lightning/fabric/utilities/registry.py b/src/lightning/fabric/utilities/registry.py index 7d8f6ca17712e..79ca438a75d93 100644 --- a/src/lightning/fabric/utilities/registry.py +++ b/src/lightning/fabric/utilities/registry.py @@ -36,9 +36,7 @@ def _load_external_callbacks(group: str) -> list[Any]: A list of all callbacks collected from external factories. """ - factories = ( - entry_points(group=group) if _PYTHON_GREATER_EQUAL_3_10_0 else entry_points().get(group, {}) # type: ignore[arg-type] - ) + factories = entry_points(group=group) if _PYTHON_GREATER_EQUAL_3_10_0 else entry_points().get(group, {}) external_callbacks: list[Any] = [] for factory in factories: diff --git a/src/lightning/pytorch/trainer/connectors/accelerator_connector.py b/src/lightning/pytorch/trainer/connectors/accelerator_connector.py index d51b11ea6fb12..f9d82708a9efd 100644 --- a/src/lightning/pytorch/trainer/connectors/accelerator_connector.py +++ b/src/lightning/pytorch/trainer/connectors/accelerator_connector.py @@ -465,7 +465,7 @@ def _check_and_init_precision(self) -> Precision: if isinstance(self.strategy, FSDPStrategy): return FSDPPrecision(self._precision_flag) # type: ignore[arg-type] if self._precision_flag in ("16-true", "bf16-true"): - return HalfPrecision(self._precision_flag) # type: ignore + return HalfPrecision(self._precision_flag) if self._precision_flag == "32-true": return Precision() if self._precision_flag == "64-true": @@ -487,7 +487,7 @@ def _check_and_init_precision(self) -> Precision: f"Using {'16bit' if self._precision_flag == '16-mixed' else 'bfloat16'} Automatic Mixed Precision (AMP)" ) device = self._accelerator_flag if self._accelerator_flag in ("cpu", "mps") else "cuda" - return MixedPrecision(self._precision_flag, device) # type: ignore[arg-type] + return MixedPrecision(self._precision_flag, device) raise RuntimeError("No precision set") From 7a39f5f77ff1fc73e64a94d5b3c1cc937d99bc85 Mon Sep 17 00:00:00 2001 From: bhimrazy Date: Tue, 7 Apr 2026 13:47:20 +0545 Subject: [PATCH 3/3] fix: drop dead Python <3.10 guard in registry entry_points call The minimum supported Python version is 3.10, so the `_PYTHON_GREATER_EQUAL_3_10_0` ternary in `_load_external_callbacks` was unreachable and caused a mypy error with the 1.20.0 upgrade (`dict[Never, Never]` incompatible with `EntryPoints`). --- src/lightning/fabric/utilities/registry.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/lightning/fabric/utilities/registry.py b/src/lightning/fabric/utilities/registry.py index 79ca438a75d93..68b9c701938ac 100644 --- a/src/lightning/fabric/utilities/registry.py +++ b/src/lightning/fabric/utilities/registry.py @@ -19,8 +19,6 @@ from lightning_utilities import is_overridden -from lightning.fabric.utilities.imports import _PYTHON_GREATER_EQUAL_3_10_0 - _log = logging.getLogger(__name__) @@ -36,7 +34,7 @@ def _load_external_callbacks(group: str) -> list[Any]: A list of all callbacks collected from external factories. """ - factories = entry_points(group=group) if _PYTHON_GREATER_EQUAL_3_10_0 else entry_points().get(group, {}) + factories = entry_points(group=group) external_callbacks: list[Any] = [] for factory in factories: