Skip to content
This repository was archived by the owner on Oct 9, 2023. It is now read-only.

Commit d6f7add

Browse files
authored
Remove deprecated code and slight cleanup (#1173)
1 parent baf0b0d commit d6f7add

16 files changed

Lines changed: 65 additions & 308 deletions

File tree

docs/source/api/data.rst

Lines changed: 52 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,6 @@ flash.core.data
77
:local:
88
:backlinks: top
99

10-
flash.core.data.io.output
11-
_________________________
12-
13-
.. autosummary::
14-
:toctree: generated/
15-
:nosignatures:
16-
:template: classtemplate.rst
17-
18-
~flash.core.data.io.output.Output
19-
2010
flash.core.data.base_viz
2111
________________________
2212

@@ -58,38 +48,6 @@ ___________________________
5848

5949
~flash.core.data.data_module.DataModule
6050

61-
flash.core.data.data_pipeline
62-
_____________________________
63-
64-
.. autosummary::
65-
:toctree: generated/
66-
:nosignatures:
67-
:template: classtemplate.rst
68-
69-
~flash.core.data.data_pipeline.DataPipeline
70-
71-
flash.core.data.io.input
72-
___________________________
73-
74-
.. autosummary::
75-
:toctree: generated/
76-
:nosignatures:
77-
:template: classtemplate.rst
78-
79-
~flash.core.data.io.input.Input
80-
~flash.core.data.io.input.DataKeys
81-
~flash.core.data.io.input.InputFormat
82-
83-
flash.core.data.io.classification_input
84-
_______________________________________
85-
86-
.. autosummary::
87-
:toctree: generated/
88-
:nosignatures:
89-
:template: classtemplate.rst
90-
91-
~flash.core.data.io.classification_input.ClassificationInputMixin
92-
9351
flash.core.data.utilities.classification
9452
________________________________________
9553

@@ -109,19 +67,6 @@ ________________________________________
10967
~flash.core.data.utilities.classification.MultiBinaryTargetFormatter
11068
~flash.core.data.utilities.classification.get_target_formatter
11169

112-
flash.core.data.process
113-
_______________________
114-
115-
.. autosummary::
116-
:toctree: generated/
117-
:nosignatures:
118-
:template: classtemplate.rst
119-
120-
~flash.core.data.process.DeserializerMapping
121-
~flash.core.data.process.Deserializer
122-
~flash.core.data.io.output_transform.OutputTransform
123-
~flash.core.data.io.input_transform.InputTransform
124-
12570
flash.core.data.properties
12671
__________________________
12772

@@ -175,3 +120,55 @@ _____________________
175120

176121
~flash.core.data.utils.convert_to_modules
177122
~flash.core.data.utils.download_data
123+
124+
flash.core.data.io.input
125+
___________________________
126+
127+
.. autosummary::
128+
:toctree: generated/
129+
:nosignatures:
130+
:template: classtemplate.rst
131+
132+
~flash.core.data.io.input.Input
133+
~flash.core.data.io.input.DataKeys
134+
~flash.core.data.io.input.InputFormat
135+
136+
flash.core.data.io.classification_input
137+
_______________________________________
138+
139+
.. autosummary::
140+
:toctree: generated/
141+
:nosignatures:
142+
:template: classtemplate.rst
143+
144+
~flash.core.data.io.classification_input.ClassificationInputMixin
145+
146+
flash.core.data.io.input_transform
147+
__________________________________
148+
149+
.. autosummary::
150+
:toctree: generated/
151+
:nosignatures:
152+
:template: classtemplate.rst
153+
154+
~flash.core.data.io.input_transform.InputTransform
155+
156+
flash.core.data.io.output
157+
_________________________
158+
159+
.. autosummary::
160+
:toctree: generated/
161+
:nosignatures:
162+
:template: classtemplate.rst
163+
164+
~flash.core.data.io.output.Output
165+
166+
flash.core.data.io.output_transform
167+
___________________________________
168+
169+
.. autosummary::
170+
:toctree: generated/
171+
:nosignatures:
172+
:template: classtemplate.rst
173+
174+
~flash.core.data.io.output_transform.OutputTransform

flash/__init__.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
from flash.core.data.io.input_transform import InputTransform
2626
from flash.core.data.io.output import Output
2727
from flash.core.data.io.output_transform import OutputTransform
28-
from flash.core.data.process import Serializer
2928
from flash.core.model import Task
3029
from flash.core.trainer import Trainer
3130
from flash.core.utilities.stages import RunningStage
@@ -49,7 +48,6 @@
4948
"Output",
5049
"OutputTransform",
5150
"RunningStage",
52-
"Serializer",
5351
"Task",
5452
"Trainer",
5553
]

flash/audio/speech_recognition/input.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,7 @@
2020
from torch.utils.data import Dataset
2121

2222
import flash
23-
from flash.core.data.io.input import DataKeys, Input
24-
from flash.core.data.process import Deserializer
23+
from flash.core.data.io.input import DataKeys, Input, ServeInput
2524
from flash.core.data.utilities.paths import filter_valid_files, list_valid_files
2625
from flash.core.data.utilities.samples import to_sample, to_samples
2726
from flash.core.utilities.imports import _AUDIO_AVAILABLE, requires
@@ -31,7 +30,7 @@
3130
from datasets import load_dataset
3231

3332

34-
class SpeechRecognitionDeserializer(Deserializer):
33+
class SpeechRecognitionDeserializer(ServeInput):
3534
@requires("audio")
3635
def __init__(self, sampling_rate: int = 16000, **kwargs):
3736
super().__init__(**kwargs)

flash/core/classification.py

Lines changed: 4 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
import torch
1717
import torch.nn.functional as F
18-
from pytorch_lightning.utilities import rank_zero_deprecation, rank_zero_warn
18+
from pytorch_lightning.utilities import rank_zero_warn
1919
from torchmetrics import Accuracy, Metric
2020

2121
from flash.core.adapter import AdapterTask
@@ -71,12 +71,12 @@ def _build(
7171
return metrics, loss_fn
7272

7373
def to_metrics_format(self, x: torch.Tensor) -> torch.Tensor:
74-
if getattr(self.hparams, "multi_label", False):
74+
if getattr(self, "multi_label", False):
7575
return torch.sigmoid(x)
7676
return torch.softmax(x, dim=1)
7777

7878

79-
class ClassificationTask(Task, ClassificationMixin):
79+
class ClassificationTask(ClassificationMixin, Task):
8080

8181
outputs: FlashRegistry = Task.outputs + CLASSIFICATION_OUTPUTS
8282

@@ -101,7 +101,7 @@ def __init__(
101101
)
102102

103103

104-
class ClassificationAdapterTask(AdapterTask, ClassificationMixin):
104+
class ClassificationAdapterTask(ClassificationMixin, AdapterTask):
105105

106106
outputs: FlashRegistry = Task.outputs + CLASSIFICATION_OUTPUTS
107107

@@ -350,20 +350,3 @@ def transform(
350350
filepath = sample[DataKeys.METADATA]["filepath"]
351351
return {"filepath": filepath, "predictions": fo_predictions}
352352
return fo_predictions
353-
354-
355-
class Labels(LabelsOutput):
356-
def __init__(self, labels: Optional[List[str]] = None, multi_label: bool = False, threshold: float = 0.5):
357-
rank_zero_deprecation(
358-
"`Labels` was deprecated in v0.6.0 and will be removed in v0.7.0." "Please use `LabelsOutput` instead."
359-
)
360-
super().__init__(labels=labels, multi_label=multi_label, threshold=threshold)
361-
362-
363-
class Probabilities(ProbabilitiesOutput):
364-
def __init__(self, multi_label: bool = False):
365-
rank_zero_deprecation(
366-
"`Probabilities` was deprecated in v0.6.0 and will be removed in v0.7.0."
367-
"Please use `ProbabilitiesOutput` instead."
368-
)
369-
super().__init__(multi_label=multi_label)

flash/core/data/data_source.py

Lines changed: 0 additions & 45 deletions
This file was deleted.

flash/core/data/process.py

Lines changed: 0 additions & 74 deletions
This file was deleted.

flash/core/data/utils.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,6 @@ def download_data(url: str, path: str = "data/", verbose: bool = False) -> None:
7272
Usage:
7373
download_file('http://web4host.net/5MB.zip')
7474
"""
75-
if url == "NEED_TO_BE_CREATED":
76-
raise NotImplementedError
77-
7875
if not os.path.exists(path):
7976
os.makedirs(path)
8077
local_filename = os.path.join(path, url.split("/")[-1])

flash/core/utilities/types.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
METRICS_TYPE = TypeVar("METRICS_TYPE", Metric, Mapping, Sequence, None)
3030

3131
# Data Pipeline
32-
DESERIALIZER_TYPE = TypeVar("DESERIALIZER_TYPE", "flash.core.data.process.Deserializer", None)
3332
INPUT_TRANSFORM_TYPE = TypeVar(
3433
"INPUT_TRANSFORM_TYPE",
3534
Type["flash.core.data.io.input_transform.InputTransform"],

flash/image/data.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,7 @@
2020
import torch
2121

2222
import flash
23-
from flash.core.data.io.input import DataKeys, Input
24-
from flash.core.data.process import Deserializer
23+
from flash.core.data.io.input import DataKeys, Input, ServeInput
2524
from flash.core.data.utilities.paths import filter_valid_files, has_file_allowed_extension, PATH_TYPE
2625
from flash.core.data.utilities.samples import to_samples
2726
from flash.core.data.utils import image_default_loader
@@ -49,7 +48,7 @@ def image_loader(filepath: str):
4948
return img
5049

5150

52-
class ImageDeserializer(Deserializer):
51+
class ImageDeserializer(ServeInput):
5352
@requires("image")
5453
def serve_load_sample(self, data: str) -> Dict:
5554
encoded_with_padding = (data + "===").encode("ascii")

flash/image/detection/output.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ def from_task(cls, task: Task, **kwargs) -> Output:
6161

6262
def transform(self, sample: Dict[str, Any]) -> Union[Detections, Dict[str, Any]]:
6363
if DataKeys.METADATA not in sample:
64-
raise ValueError("sample requires DefaultDataKeys.METADATA to use a FiftyOneDetectionLabelsOutput output.")
64+
raise ValueError("sample requires DataKeys.METADATA to use a FiftyOneDetectionLabelsOutput output.")
6565

6666
height, width = sample[DataKeys.METADATA]["size"]
6767

0 commit comments

Comments
 (0)