Fix TypeScript compilation errors

- Add missing return statements in catch blocks
- Prefix unused parameters with underscore
- Fix unused/missing imports
- All type errors resolved for clean build

Author: mattburchett

backend/src/middleware/auth.ts

@@ -56,11 +56,11 @@ export async function requireAuth(
     next();
   } catch (error) {
     logger.error('Error in auth middleware', { error });
-    res.status(500).json({ error: 'Internal server error' });
+    return res.status(500).json({ error: 'Internal server error' });
   }
 }
 
-export function optionalAuth(req: Request, res: Response, next: NextFunction) {
+export function optionalAuth(req: Request, _res: Response, next: NextFunction) {
   if (req.session.accessToken && req.session.tokenExpiry) {
     const isValid = authService.validateToken(
       req.session.accessToken,

backend/src/middleware/error.ts

@@ -5,7 +5,7 @@ export function errorHandler(
   err: Error,
   req: Request,
   res: Response,
-  next: NextFunction
+  _next: NextFunction
 ) {
   logger.error('Error caught by error handler', {
     error: err.message,

backend/src/routes/apps.ts

@@ -20,7 +20,7 @@ router.get('/', requireAuth, (req: Request, res: Response) => {
   }
 });
 
-router.get('/categories', requireAuth, (req: Request, res: Response) => {
+router.get('/categories', requireAuth, (_req: Request, res: Response) => {
   try {
     const categories = configService.getCategories();
 
@@ -49,7 +49,7 @@ router.get('/search', requireAuth, (req: Request, res: Response) => {
     });
   } catch (error) {
     logger.error('Error in search route', { error });
-    res.status(500).json({ error: 'Failed to search apps' });
+    return res.status(500).json({ error: 'Failed to search apps' });
   }
 });
 

backend/src/routes/auth.ts

@@ -99,7 +99,7 @@ router.post('/logout', async (req: Request, res: Response) => {
       logger.info('User logged out', { userId: req.session.userId });
     }
 
-    req.session.destroy((err) => {
+    return req.session.destroy((err) => {
       if (err) {
         logger.error('Failed to destroy session', { error: err });
         return res.status(500).json({ error: 'Failed to logout' });
@@ -109,7 +109,7 @@ router.post('/logout', async (req: Request, res: Response) => {
     });
   } catch (error) {
     logger.error('Error in logout route', { error });
-    res.status(500).json({ error: 'Failed to logout' });
+    return res.status(500).json({ error: 'Failed to logout' });
   }
 });
 

backend/src/server.ts

@@ -81,7 +81,7 @@ async function startServer() {
 
     app.use(sessionMiddleware);
 
-    app.get('/health', (req, res) => {
+    app.get('/health', (_req, res) => {
       res.json({
         status: 'ok',
         timestamp: new Date().toISOString(),

backend/src/services/apps.service.ts

@@ -1,5 +1,5 @@
 import { configService } from './config.service';
-import { Application, Category, CategoryWithApps } from '../types';
+import { Application, CategoryWithApps } from '../types';
 import logger from '../utils/logger';
 
 export class AppsService {

backend/src/services/config.service.ts

@@ -3,7 +3,7 @@ import YAML from 'yaml';
 import Joi from 'joi';
 import chokidar from 'chokidar';
 import { config } from '../config';
-import { AppConfig, CategoryData } from '../types';
+import { AppConfig, Category, CategoryData } from '../types';
 import logger from '../utils/logger';
 
 const configSchema = Joi.object({