Skip to content

Commit e428400

Browse files
abhinav-1305LisaHusband
authored andcommitted
fix: Correct state handling in CSS Template modal (apache#33846)
1 parent c6a6b0b commit e428400

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

superset-frontend/src/features/cssTemplates/CssTemplateModal.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,8 @@ const CssTemplateModal: FunctionComponent<CssTemplateModalProps> = ({
105105

106106
// Functions
107107
const hide = () => {
108-
setIsHidden(true);
109108
onHide();
109+
setCurrentCssTemplate(null);
110110
};
111111

112112
const onSave = () => {
@@ -202,7 +202,7 @@ const CssTemplateModal: FunctionComponent<CssTemplateModalProps> = ({
202202
css: '',
203203
});
204204
}
205-
}, [cssTemplate]);
205+
}, [cssTemplate, show]);
206206

207207
useEffect(() => {
208208
if (resource) {

0 commit comments

Comments
 (0)