node-litesvm Is there a way to add an upgrade-able program?

[ch0c0l8ra1n]

I have a check on my initialization that prevents front running but it relies on the program being upgrade-able.

    // If we only used this, someone could pass in a program data
    // address that they control.
    #[account(
        constraint = program_data.upgrade_authority_address == Some(signer.key())
        @ ErrorCode::NotUpgradeAuthority
    )]
    pub program_data: Account<'info, ProgramData>,

    // Verify that the program data address is not bogus.
    #[account(
        address = crate::ID,
        constraint = program.programdata_address()? == Some(program_data.key())
    )]
    pub program: Program<'info, Soulflip>,

This does not work with litesvm because addProgramFromFile doesn't seem to deploy the program in an upgrade-able way. I am not too aware of the intricacies of litesvm or the svm in general but when anchor test was failing with the same error, I could fix it with:

[[test.genesis]]
upgradeable = true

In my anchor.toml file.

[ch0c0l8ra1n]

I am currently using this code snippet to set the accounts manually.

export const deployUpgradeableProgram = async ({
    svm,
    program,
    elf,
    payerPublicKey,
}: ManualDeployProgramParams) => {
    const UPGRADEABLE_LOADER_ID = new anchor.web3.PublicKey(
        "BPFLoaderUpgradeab1e11111111111111111111111"
    );

    const programDataAddress = getProgramDataAddress(program);

    // 1. Create the ProgramData account (Holds the code + authority)
    // Data Format: [Int32(3) for 'ProgramData' enum] + [UInt64(0) slot] +
    // [Option(1) + Authority Key] + [ELF]
    const header = Buffer.alloc(4 + 8 + 1 + 32);
    header.writeInt32LE(3, 0); // Enum variant: ProgramData
    header.writeBigUInt64LE(BigInt(0), 4); // Slot deployed
    header.writeUInt8(1, 12);
    // Setting the payer public key as the upgrade authority
    payerPublicKey.toBuffer().copy(header, 13);

    const programDataContent = Buffer.concat([header, elf]);
    svm.setAccount(programDataAddress, {
        owner: UPGRADEABLE_LOADER_ID,
        lamports: 100_000_000_000,
        data: programDataContent,
        executable: false,
    });

    // 2. Create the Program account (The interface)
    // Data Format: [Int32(2) for 'Program' enum] + [ProgramData Address]
    const programBuf = Buffer.alloc(4 + 32);
    programBuf.writeUInt32LE(2, 0); // Enum variant: Program
    programDataAddress.toBuffer().copy(programBuf, 4);
    svm.setAccount(program.programId, {
        owner: UPGRADEABLE_LOADER_ID,
        lamports: 100_000_000_000,
        data: programBuf,
        executable: true, // This account IS marked executable
    });
};

export const getProgramDataAddress = (program: anchor.Program<Soulflip>) => {
    const BPF_LOADER_ID = new anchor.web3.PublicKey(
        "BPFLoaderUpgradeab1e11111111111111111111111"
    );
    const [programDataAddress] = anchor.web3.PublicKey.findProgramAddressSync(
        [program.programId.toBuffer()],
        BPF_LOADER_ID
    );
    return programDataAddress;
};

[dimalinux]

This problem is not specific to the node implementation. The rust code is using the older loader when you call svm.add_program: https://github.com/LiteSVM/litesvm/blob/v0.8.2/crates/litesvm/src/lib.rs#L738

In my case, I was testing a mainnet program, so I downloaded the JSON files of the program data and the program ID:

solana account --output json ADDRESS --url mainnet-beta --output-file FILENAME.json

Then I first loaded the program data account into light svm before loading the program account (order matters). The Rust code that I used to load the accounts is here: #149 (comment). That solution is working well for me and you could presumably do something similar in TypeScript as an option.

[ch0c0l8ra1n]

@dimalinux I am already manually setting the program account. Fortunately we can modify accounts at will with litesvm so this is more of an inconvinience than a problem. It would be nice if addProgramFromFile exposed a way to just add an upgradeable program.