Fix all warnings in solution and begin treating warnings as errors (#780)

I'm a bit skeptical of treating warnings as error in the database
project until Postgres is complete, but we'll see how that goes. Most of
the warnings in source generated code seem to resolve if you disable
nullables in the file, so I've done that for all models that were
causing warnings.

Worst case, we can disable this for `Refresh.Database` if it starts
causing issues.

Author: jvyden

Refresh.Common/Refresh.Common.csproj

@@ -4,6 +4,7 @@
         <TargetFramework>net9.0</TargetFramework>
         <ImplicitUsings>enable</ImplicitUsings>
         <Nullable>enable</Nullable>
+        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     </PropertyGroup>
 
     <ItemGroup>

Refresh.Database/GameDatabaseProvider.cs

@@ -841,9 +841,4 @@ protected override void Migrate(Migration migration, ulong oldVersion)
         //     }
     }
     #endif
-    
-    public void Dispose()
-    {
-        GC.SuppressFinalize(this);
-    }
 }

Refresh.Database/Models/Assets/GameAssetType.cs

@@ -410,7 +410,7 @@ public enum GameAssetType
 
 public static class GameAssetTypeExtensions
 {
-    private static readonly Dictionary<int, GameAssetType> _lbpMagics = new()
+    private static readonly Dictionary<int, GameAssetType> LbpMagics = new()
     {
         { BinaryPrimitives.ReadInt32BigEndian("TEX\0"u8), GameAssetType.Texture },
         { BinaryPrimitives.ReadInt32BigEndian("GTF\0"u8), GameAssetType.GameDataTexture },
@@ -477,13 +477,13 @@ public static class GameAssetTypeExtensions
     {
         int magicInt = magic[0] << 24 | magic[1] << 16 | magic[2] << 8;
 
-        if (!_lbpMagics.TryGetValue(magicInt, out GameAssetType assetType))
+        if (!LbpMagics.TryGetValue(magicInt, out GameAssetType assetType))
             return null;
 
         return assetType;
     }
 
-    public static string Magic(this GameAssetType type)
+    public static string? LbpMagic(this GameAssetType type)
     {
         return type switch
         {
@@ -546,6 +546,9 @@ public static string Magic(this GameAssetType type)
             GameAssetType.CachedCostumeData => "CCD",
             GameAssetType.DataLabels => "DLA",
             GameAssetType.AdventureMaps => "ADM",
+            GameAssetType.GriefSongState => "MATT",
+            GameAssetType.ChallengeGhost => "<ghost>",
+            _ => null,
         };
     }
 }

Refresh.Database/Models/Comments/GameLevelComment.cs

@@ -3,6 +3,8 @@
 
 namespace Refresh.Database.Models.Comments;
 
+#nullable disable
+
 public partial class GameLevelComment : IRealmObject, IGameComment, ISequentialId
 {
     [PrimaryKey] public int SequentialId { get; set; }

Refresh.Database/Models/Comments/GameProfileComment.cs

@@ -2,6 +2,8 @@
 
 namespace Refresh.Database.Models.Comments;
 
+#nullable disable
+
 public partial class GameProfileComment : IRealmObject, IGameComment, ISequentialId
 {
     [PrimaryKey] public int SequentialId { get; set; }

Refresh.Database/Models/Photos/GamePhotoSubject.cs

@@ -7,6 +7,8 @@ namespace Refresh.Database.Models.Photos;
 [XmlType("subject")]
 public class GamePhotoSubject
 {
+#pragma warning disable CS8618 // Non-nullable field must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring as nullable.
+    [Obsolete("used for serialization. XML stuff should be moved to SerializedGamePhotoSubject", true)]
     public GamePhotoSubject() {}
 
     public GamePhotoSubject(GameUser? user, string displayName, IList<float> bounds)

Refresh.Database/Models/Playlists/GamePlaylist.cs

@@ -2,6 +2,8 @@
 
 namespace Refresh.Database.Models.Playlists;
 
+#nullable disable
+
 /// <summary>
 /// A user-curated list of levels.
 /// </summary>

Refresh.Database/Models/Relations/LevelCommentRelation.cs

@@ -4,6 +4,8 @@
 
 namespace Refresh.Database.Models.Relations;
 
+#nullable disable
+
 public partial class LevelCommentRelation : IRealmObject, ICommentRelation<GameLevelComment>
 {
     public ObjectId CommentRelationId { get; set; } = ObjectId.GenerateNewId();

Refresh.Database/Models/Relations/ProfileCommentRelation.cs

@@ -4,6 +4,8 @@
 
 namespace Refresh.Database.Models.Relations;
 
+#nullable disable
+
 public partial class ProfileCommentRelation : IRealmObject, ICommentRelation<GameProfileComment>
 {
     public ObjectId CommentRelationId { get; set; } = ObjectId.GenerateNewId();

Refresh.Database/Models/Relations/RateReviewRelation.cs

@@ -3,6 +3,8 @@
 
 namespace Refresh.Database.Models.Relations;
 
+#nullable disable
+
 public partial class RateReviewRelation : IRealmObject
 {
     // we could just reuse RatingType from GameLevel rating logic
@@ -13,6 +15,7 @@ public RatingType RatingType
         set => this._ReviewRatingType = (int)value;
     }
 
+    // ReSharper disable once InconsistentNaming
     public int _ReviewRatingType { get; set; }
     public GameReview Review { get; set; }