Fix website pin migration not deleting leftover duplicate pins

Author: Toastbrot236

Refresh.Database/GameDatabaseContext.Pins.cs

@@ -2,6 +2,7 @@
 using Refresh.Database.Models.Users;
 using Refresh.Database.Models.Relations;
 using Refresh.Database.Models.Pins;
+using MongoDB.Bson;
 
 namespace Refresh.Database;
 
@@ -179,16 +180,20 @@ private IEnumerable<ProfilePinRelation> GetProfilePinsByUser(GameUser user, Toke
 
     public DatabaseList<ProfilePinRelation> GetProfilePinsByUser(GameUser user, TokenGame game, TokenPlatform platform, int skip, int count)
         => new(this.GetProfilePinsByUser(user, game, platform), skip, count);
+
+    #region Migration Methods
 
     public void AddPinProgress(PinProgressRelation relation, bool save)
     {
         this.PinProgressRelations.Add(relation);
         if (save) this.SaveChanges();
     }
 
-    public void RemovePinProgresses(IEnumerable<PinProgressRelation> relations, bool save)
+    public void RemoveAllPinProgressesByIdAndUser(long pinId, ObjectId userId, bool save)
     {
-        this.PinProgressRelations.RemoveRange(relations);
+        this.PinProgressRelations.RemoveRange(p => p.PinId == pinId && p.PublisherId == userId);
         if (save) this.SaveChanges();
     }
+
+    #endregion
 }

Refresh.Interfaces.Workers/Migrations/CorrectWebsitePinProgressPlatform.cs

@@ -33,10 +33,16 @@ protected override void Migrate(WorkContext context, PinProgressRelation[] batch
 
             foreach (IEnumerable<PinProgressRelation> group in pinsByUser)
             {
+                // Should never happen, but just incase
                 if (!group.Any()) continue;
 
-                // Find and migrate one progress
+                // Find best one by the current user
                 PinProgressRelation relationToMigrate = group.MaxBy(r => r.Progress)!;
+
+                // Remove all already existing progresses to remove duplicates
+                context.Database.RemoveAllPinProgressesByIdAndUser(pinId, relationToMigrate.PublisherId, false);
+
+                // Now take the best progress we've just got and add it as a website pin, preserving other old metadata
                 context.Database.AddPinProgress(new()
                 {
                     PinId = relationToMigrate.PinId,
@@ -47,9 +53,6 @@ protected override void Migrate(WorkContext context, PinProgressRelation[] batch
                     IsBeta = false, // doesn't matter here
                     Platform = TokenPlatform.Website,
                 }, false);
-
-                // Remove all others
-                context.Database.RemovePinProgresses(group, false);
             }
         }