address pr comments

Author: ReenigneArcher

.github/workflows/ci-macos-dmg.yml

@@ -35,7 +35,7 @@ on:
 env:
   CARGO_TERM_COLOR: always
   INPUT_RELEASE_VERSION: ${{ inputs.release_version }}
-  MACOSX_DEPLOYMENT_TARGET: 14.2
+  MACOSX_DEPLOYMENT_TARGET: "14.2"
 
 jobs:
   build_dmg:

packaging/linux/flatpak/dev.lizardbyte.app.Koko.yml

@@ -16,6 +16,7 @@ separate-locales: false
 
 finish-args:
   - --filesystem=home
+  - --filesystem=host:ro
   - --share=network
   - --share=ipc
   - --socket=fallback-x11
@@ -33,7 +34,8 @@ cleanup:
 
 modules:
   - shared-modules/libayatana-appindicator/libayatana-appindicator-gtk3.json
-  - modules/xdotool.json
+  # Required by the Linux tray/menu stack through the muda crate.
+  - modules/libxdo.json
 
   - name: koko
     buildsystem: simple
@@ -69,6 +71,10 @@ modules:
         install -Dm0644
         packaging/linux/flatpak/dev.lizardbyte.app.Koko.metainfo.xml
         /app/share/metainfo/dev.lizardbyte.app.Koko.metainfo.xml
+    run-tests: true
+    test-rule: ""
+    test-commands:
+      - cargo test --offline --locked --workspace --lib --bins --release
     sources:
       - type: git
         url: "@GITHUB_CLONE_URL@"

packaging/linux/flatpak/exceptions.json

@@ -3,6 +3,7 @@
     "appid-url-not-reachable",
     "appstream-screenshots-not-mirrored-in-ostree",
     "metainfo-missing-screenshots",
+    "finish-args-host-ro-filesystem-access",
     "finish-args-home-filesystem-access"
   ]
 }

…aging/linux/flatpak/modules/xdotool.json …kaging/linux/flatpak/modules/libxdo.jsonpackaging/linux/flatpak/modules/xdotool.json renamed to packaging/linux/flatpak/modules/libxdo.json packaging/linux/flatpak/modules/xdotool.json renamed to packaging/linux/flatpak/modules/libxdo.json

@@ -1,5 +1,5 @@
 {
-  "name": "xdotool",
+  "name": "libxdo",
   "buildsystem": "simple",
   "build-commands": [
     "make libxdo.so libxdo.so.4 libxdo.pc PREFIX=\"${FLATPAK_DEST}\" WITHOUT_RPATH_FIX=1",

packaging/macos/package-dmg.sh

@@ -22,6 +22,9 @@ Options:
   --output-dir PATH     Directory for the generated DMG. Default: artifacts.
   --sign                Sign the app bundle and DMG with APPLE_CODESIGN_IDENTITY.
   -h, --help            Show this help text.
+
+Environment:
+  MACOSX_DEPLOYMENT_TARGET  Minimum macOS version to write into Info.plist.
 EOF
 }
 
@@ -116,6 +119,12 @@ if [[ -z "${bundle_version}" ]]; then
   bundle_version="0"
 fi
 
+minimum_system_version="${MACOSX_DEPLOYMENT_TARGET:-}"
+if [[ -z "${minimum_system_version}" ]]; then
+  echo "MACOSX_DEPLOYMENT_TARGET must be set to write LSMinimumSystemVersion." >&2
+  exit 1
+fi
+
 package_dir="${work_dir}/${target}"
 app_dir="${package_dir}/${app_name}.app"
 contents_dir="${app_dir}/Contents"
@@ -172,7 +181,7 @@ cat > "${contents_dir}/Info.plist" <<EOF
   <key>LSApplicationCategoryType</key>
   <string>public.app-category.entertainment</string>
   <key>LSMinimumSystemVersion</key>
-  <string>14.2</string>
+  <string>${minimum_system_version}</string>
   <key>LSUIElement</key>
   <true/>
   <key>NSLocalNetworkUsageDescription</key>