testing tests

Author: ReenigneArcher

Contents/Code/plex_api_helper.py

@@ -598,6 +598,58 @@ def get_plex_item(rating_key):
     return item
 
 
+def get_user_info(token):
+    # type: (str) -> Optional[MyPlexAccount]
+    """
+    Get the Plex user info.
+
+    Parameters
+    ----------
+    token : str
+        The Plex token.
+
+    Returns
+    -------
+    Optional[MyPlexAccount]
+        The Plex user info.
+
+    Examples
+    --------
+    >>> get_user_info(token='...')
+    ...
+    """
+    try:
+        return MyPlexAccount(token=token)
+    except Exception as e:
+        Log.Error('Error getting user info: {}'.format(e))
+        return None
+
+
+def is_server_owner(user):
+    # type: (MyPlexAccount) -> bool
+    """
+    Check if the user is the owner of the Plex server.
+
+    Parameters
+    ----------
+    user : MyPlexAccount
+        The Plex user info.
+
+    Returns
+    -------
+    py:class:`bool`
+        True if the user is the owner of the Plex server, False otherwise.
+
+    Examples
+    --------
+    >>> is_server_owner(user=...)
+    ...
+    """
+    plex = setup_plexapi()
+
+    return plex.account().username in {user.email, user.username}
+
+
 def process_queue():
     # type: () -> None
     """
@@ -766,54 +818,3 @@ def scheduled_update():
         for item in all_items:
             if item.ratingKey not in q.queue:
                 q.put(item=item.ratingKey)
-
-
-def get_user_info(token):
-    # type: (str) -> Optional[MyPlexAccount]
-    """
-    Get the Plex user info.
-
-    Parameters
-    ----------
-    token : str
-        The Plex token.
-
-    Returns
-    -------
-    Optional[MyPlexAccount]
-        The Plex user info.
-
-    Examples
-    --------
-    >>> get_user_info(token='...')
-    ...
-    """
-    try:
-        return MyPlexAccount(token=token)
-    except Exception:
-        return None
-
-
-def is_server_owner(user):
-    # type: (MyPlexAccount) -> bool
-    """
-    Check if the user is the owner of the Plex server.
-
-    Parameters
-    ----------
-    user : MyPlexAccount
-        The Plex user info.
-
-    Returns
-    -------
-    py:class:`bool`
-        True if the user is the owner of the Plex server, False otherwise.
-
-    Examples
-    --------
-    >>> is_server_owner(user=...)
-    ...
-    """
-    plex = setup_plexapi()
-
-    return plex.account().username in {user.email, user.username}

Contents/Code/webapp.py

@@ -62,7 +62,7 @@ def render_template(*args, **kwargs):
     >>> render_template('home.html', title='Home', items=items)
     """
     kwargs['Prefs'] = Prefs
-    kwargs['is_logged_in'] = is_logged_in
+    kwargs['is_logged_in'] = is_logged_in()
     return flask_render_template(*args, **kwargs)
 
 
@@ -574,8 +574,8 @@ def is_logged_in():
         return False
 
     token = session["token"]
-    user = get_user_info(token)
-    logged_in = user and is_server_owner(user)
+    user = get_user_info(token=token)
+    logged_in = user and is_server_owner(user=user)
     return logged_in
 
 

tests/conftest.py

@@ -11,6 +11,7 @@
 from plexapi.exceptions import NotFound
 from plexapi.server import PlexServer
 from plexhints.agent_kit import Agent
+from plexhints.prefs_kit import Prefs
 import pytest
 import requests
 
@@ -102,6 +103,13 @@ def test_client():
             yield test_client  # this is where the testing happens!
 
 
+@pytest.fixture(scope='function')
+def test_client_disabled_login(test_client):
+    """Create a test client for testing webapp endpoints with login disabled"""
+    Prefs['bool_webapp_require_login'] = False
+    return test_client
+
+
 # plex server fixtures
 @pytest.fixture(scope="session")
 def plugin_logs():

tests/functional/test_webapp.py

@@ -25,7 +25,7 @@ def remove_themerr_db_cache_file():
 def test_home(test_client):
     """
     WHEN the '/' page is requested (GET)
-    THEN check that the response is valid
+    THEN check that the response is a redirect
 
     Repeat for '/home'
     """
@@ -34,9 +34,27 @@ def test_home(test_client):
     except AttributeError:
         pytest.skip("cannot access Plex token/server")
     else:
-        assert response.status_code == 200
+        assert response.status_code == 302
 
         response = test_client.get('/home')
+        assert response.status_code == 302
+
+
+def test_home_no_login(test_client_disabled_login):
+    """
+    WHEN the '/' page is requested (GET)
+    THEN check that the response is valid
+
+    Repeat for '/home'
+    """
+    try:
+        response = test_client_disabled_login.get('/')
+    except AttributeError:
+        pytest.skip("cannot access Plex token/server")
+    else:
+        assert response.status_code == 200
+
+        response = test_client_disabled_login.get('/home')
         assert response.status_code == 200
 
         assert 'id="section_' in response.data.decode('utf-8')
@@ -45,12 +63,25 @@ def test_home(test_client):
 def test_home_without_cache(remove_themerr_db_cache_file, test_client):
     """
     WHEN the '/' page is requested (GET)
-    THEN check that the response is valid
+    THEN check that the response is a redirect
     """
     try:
         response = test_client.get('/')
     except AttributeError:
         pytest.skip("cannot access Plex token/server")
+    else:
+        assert response.status_code == 302
+
+
+def test_home_without_cache_no_login(remove_themerr_db_cache_file, test_client_disabled_login):
+    """
+    WHEN the '/' page is requested (GET)
+    THEN check that the response is valid
+    """
+    try:
+        response = test_client_disabled_login.get('/')
+    except AttributeError:
+        pytest.skip("cannot access Plex token/server")
     else:
         assert response.status_code == 200
 
@@ -68,6 +99,15 @@ def test_image(test_client):
     assert response.content_type == 'image/vnd.microsoft.icon'
 
 
+def test_image_no_login(test_client_disabled_login):
+    """
+    WHEN the '/favicon.ico' file is requested (GET)
+    THEN check that the response is a redirect
+    """
+    response = test_client_disabled_login.get('favicon.ico')
+    assert response.status_code == 302
+
+
 def test_status(test_client):
     """
     WHEN the '/status' page is requested (GET)
@@ -76,3 +116,12 @@ def test_status(test_client):
     response = test_client.get('/status')
     assert response.status_code == 200
     assert response.content_type == 'application/json'
+
+
+def test_status_no_login(test_client_disabled_login):
+    """
+    WHEN the '/status' page is requested (GET)
+    THEN check that the response is a redirect
+    """
+    response = test_client_disabled_login.get('/status')
+    assert response.status_code == 302

tests/unit/test_plex_api_helper.py

@@ -24,3 +24,20 @@ def test_change_lock_status(section, lock):
         change_status = plex_api_helper.change_lock_status(item, field=field, lock=lock)
         assert change_status, 'change_lock_status did not return True'
         assert item.isLocked(field=field) == lock, 'Failed to change lock status to {}'.format(lock)
+
+
+def test_get_user_info(plex):
+    assert plex_api_helper.get_user_info(token=plex._token)
+
+
+def test_get_user_info_bad_token():
+    assert not plex_api_helper.get_user_info(token='bad_token')
+
+
+def test_is_server_owner(plex):
+    user = plex_api_helper.get_user_info(token=plex._token)
+    assert plex_api_helper.is_server_owner(user=user)
+
+
+def test_is_server_owner_bad_user():
+    assert not plex_api_helper.is_server_owner(user={})