refactor: copr-ci reusable workflow

Author: ReenigneArcher

.github/workflows/copr-ci.yml

@@ -47,14 +47,17 @@ env:
   SECRETS_COPR_BETA_WEBHOOK_TOKEN: ${{ secrets.COPR_BETA_WEBHOOK_TOKEN }}
   SECRETS_COPR_STABLE_WEBHOOK_TOKEN: ${{ secrets.COPR_STABLE_WEBHOOK_TOKEN }}
   SECRETS_COPR_CLI_CONFIG: ${{ secrets.COPR_CLI_CONFIG }}
+  PACKAGE_NAME: ${{ github.event.repository.name }}
+  GH_EVENT_ACTION: ${{ github.event.action }}
+  GH_EVENT_NAME: ${{ github.event_name }}
+  GH_EVENT_NUMBER: ${{ github.event.number }}
 
 jobs:
   package-init:
     name: Create/update copr package
     container: fedora:latest
     env:
       BASE_URL: https://copr.fedorainfracloud.org/api_3
-      PACKAGE_NAME: ${{ github.event.repository.name }}
       SOURCE_TYPE_TEXT: "custom"
     permissions:
       contents: read
@@ -80,7 +83,7 @@ jobs:
             echo "Copr CLI configuration file is empty. Exiting..."
 
             # if a pull request exit with 0
-            if [[ "${{ github.event_name }}" = "pull_request" ]]; then
+            if [[ "${GITHUB_EVENT_NAME}" = "pull_request" ]]; then
               echo "SKIP_REMAINING_JOBS=true" >> "${GITHUB_OUTPUT}"
             else
               exit 1
@@ -107,9 +110,9 @@ jobs:
           )
 
           # download the latest copr-ci.sh script
-          if [[ "${{ github.repository }}" = "LizardByte/copr-ci" ]]; then
+          if [[ "${GITHUB_REPOSITORY}" = "LizardByte/copr-ci" ]]; then
             # use the version from the same ref
-            ref="${{ github.ref }}"
+            ref="${GITHUB_REF}"
           else
             ref="master"  # default to master branch
           fi
@@ -159,10 +162,10 @@ jobs:
     needs: package-init
     outputs:
       BUILD_ID: ${{ steps.build.outputs.BUILD_ID }}
+      BUILD_CHANNEL: ${{ steps.get-properties.outputs.BUILD_CHANNEL }}
       BUILD_CANCEL: ${{ steps.build.outcome == 'cancelled' }}
       BUILD_SUCCESS: ${{ steps.build.outcome == 'success' }}
     runs-on: ubuntu-latest
-    timeout-minutes: ${{ inputs.job_timeout }}
     permissions:
       contents: read
     steps:
@@ -171,56 +174,32 @@ jobs:
           dnf install -y \
             copr-cli \
             git \
-            jq \
-            nodejs \
-            zip
+            jq
 
       - name: Checkout
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd  # v6.0.2
 
       - name: Set git safe directory
         run: git config --global --add safe.directory '*'
 
-      - name: Add problem matchers
-        run: |
-          # add default matchers
-          mkdir -p .github/matchers
-
-          # download the latest rpmlint.json matcher
-          if [[ ! "${{ github.repository }}" = "LizardByte/copr-ci" ]]; then
-            # not in copr-ci repo, so download the rpmlint.json
-            ref="master"  # default to master branch
-            curl \
-              -fsS \
-              --retry 3 \
-              "https://raw.githubusercontent.com/lizardbyte/copr-ci/${ref}/.github/matchers/rpmlint.json" \
-              -o ".github/matchers/rpmlint.json"
-          fi
-          echo "::add-matcher::.github/matchers/rpmlint.json"
-
-          # repo specific matchers
-          if [[ -f ".github/matchers/copr-ci.json" ]]; then
-            echo "Found copr-ci.json matcher, adding it..."
-            echo "::add-matcher::.github/matchers/copr-ci.json"
-          fi
-
       - name: Get properties
+        id: get-properties
         run: |
           # package name = repository name
-          package=${{ github.event.repository.name }}
+          package=${PACKAGE_NAME}
           copr_base="https://copr.fedorainfracloud.org/webhooks/custom-dir/${INPUTS_COPR_OWNERNAME}"
 
           # release and released type
-          if [[ "${{ github.event_name }}" = "release" ]]; then
-            if [[ "${{ github.event.action }}" = "prereleased" ]]; then
+          if [[ "${GH_EVENT_NAME}" = "release" ]]; then
+            if [[ "${GH_EVENT_ACTION}" = "prereleased" ]]; then
               BUILD_CHANNEL="beta"
               COPR_PUSH_WEBHOOK="${copr_base}/${BUILD_CHANNEL}/${SECRETS_COPR_BETA_WEBHOOK_TOKEN}/${package}/"
-            elif [[ "${{ github.event.action }}" = "released" ]]; then
+            elif [[ "${GH_EVENT_ACTION}" = "released" ]]; then
               BUILD_CHANNEL="stable"
               COPR_PUSH_WEBHOOK="${copr_base}/${BUILD_CHANNEL}/${SECRETS_COPR_STABLE_WEBHOOK_TOKEN}/${package}/"
             fi
-          elif [[ "${{ github.event_name }}" = "pull_request" ]]; then
-            BUILD_CHANNEL="pulls:pr:${{ github.event.number }}"
+          elif [[ "${GH_EVENT_NAME}" = "pull_request" ]]; then
+            BUILD_CHANNEL="pulls:pr:${GH_EVENT_NUMBER}"
             COPR_PR_WEBHOOK="${copr_base}/${BUILD_CHANNEL}/${INPUTS_COPR_PR_WEBHOOK_TOKEN}/${package}/"
           fi
 
@@ -234,8 +213,13 @@ jobs:
           echo "COPR_PUSH_WEBHOOK=${COPR_PUSH_WEBHOOK}"
           echo "COPR_PR_WEBHOOK=${COPR_PR_WEBHOOK}"
 
+          # Output BUILD_CHANNEL for other jobs
+          echo "BUILD_CHANNEL=${BUILD_CHANNEL}" >> "${GITHUB_OUTPUT}"
+
       - name: Build
         id: build
+        env:
+          PR_NUMBER: ${{ github.event.pull_request.number }}
         run: |
           curl \
             -fsS \
@@ -245,36 +229,78 @@ jobs:
             # "https://raw.githubusercontent.com/praiskup/copr-ci-tooling/main/copr-gh-actions-submit"
 
           # if a PR number is added the script will use the PR webhook, otherwise it will use the push webhook
-          bash submit ${{ github.event.pull_request.number }}
+          bash submit ${PR_NUMBER}
 
       - name: Cancel Copr build
         if: >-
           always() &&
           steps.build.outcome == 'cancelled' &&
           github.secret_source
+        env:
+          BUILD_ID: ${{ steps.build.outputs.BUILD_ID }}
         run: |
           mkdir -p ~/.config
           echo "${SECRETS_COPR_CLI_CONFIG}" > ~/.config/copr
 
           copr-cli \
             cancel \
-            ${{ steps.build.outputs.BUILD_ID }}
+            "${BUILD_ID}"
+
+  logs:
+    name: Copr logs
+    if: always() && needs.build.outputs.BUILD_ID != ''
+    container: fedora:latest
+    env:
+      BUILD_CHANNEL: ${{ needs.build.outputs.BUILD_CHANNEL }}
+      BUILD_ID: ${{ needs.build.outputs.BUILD_ID }}
+    needs: build
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+    steps:
+      - name: Install dependencies
+        run: |
+          dnf install -y \
+            jq
+
+      - name: Checkout
+        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd  # v6.0.2
+
+      - name: Add problem matchers
+        run: |
+          # add default matchers
+          mkdir -p .github/matchers
+
+          # download the latest rpmlint.json matcher
+          if [[ ! "${{ github.repository }}" = "LizardByte/copr-ci" ]]; then
+            # not in copr-ci repo, so download the rpmlint.json
+            ref="master"  # default to master branch
+            curl \
+              -fsS \
+              --retry 3 \
+              "https://raw.githubusercontent.com/lizardbyte/copr-ci/${ref}/.github/matchers/rpmlint.json" \
+              -o ".github/matchers/rpmlint.json"
+          fi
+          echo "::add-matcher::.github/matchers/rpmlint.json"
+
+          # repo specific matchers
+          if [[ -f ".github/matchers/copr-ci.json" ]]; then
+            echo "Found copr-ci.json matcher, adding it..."
+            echo "::add-matcher::.github/matchers/copr-ci.json"
+          fi
 
       - name: Logs
-        if: >-
-          always() &&
-          steps.build.outcome != 'skipped'
         run: |
-          package=${{ github.event.repository.name }}
+          package=${PACKAGE_NAME}
           base_url="https://download.copr.fedorainfracloud.org/results/${INPUTS_COPR_OWNERNAME}/${BUILD_CHANNEL}"
 
           # get chroots and prefixed build_id
-          build_url="https://copr.fedorainfracloud.org/api_3/build/${{ steps.build.outputs.BUILD_ID }}"
+          build_url="https://copr.fedorainfracloud.org/api_3/build/${BUILD_ID}"
           data=$(curl -fsS --retry 3 "${build_url}")
 
           # Extract build_id from source_package.url (matches the last path segment after 'srpm-builds/')
-          build_id=$(echo "${data}" | jq -r '.source_package.url' | sed -E 's#.*/srpm-builds/([0-9]+)/.*#\1#')
-          echo "build_id: ${build_id}"
+          build_id_alt=$(echo "${data}" | jq -r '.source_package.url' | sed -E 's#.*/srpm-builds/([0-9]+)/.*#\1#')
+          echo "build_id_alt: ${build_id_alt}"
 
           # Extract chroots
           chroots=$(echo "${data}" | jq -r '.chroots[]')
@@ -283,14 +309,14 @@ jobs:
 
           # Array of "name|url" pairs
           logs=(
-            "source_builder|${base_url}/srpm-builds/${build_id}/builder-live.log.gz"
-            "source_backend|${base_url}/srpm-builds/${build_id}/backend.log.gz"
-            "import|https://copr-dist-git.fedorainfracloud.org/per-task-logs/${{ steps.build.outputs.BUILD_ID }}.log"
+            "source_builder|${base_url}/srpm-builds/${build_id_alt}/builder-live.log.gz"
+            "source_backend|${base_url}/srpm-builds/${build_id_alt}/backend.log.gz"
+            "import|https://copr-dist-git.fedorainfracloud.org/per-task-logs/${BUILD_ID}.log"
           )
 
           for chroot in $chroots; do
-            logs+=("builder_${chroot}|${base_url}/${chroot}/${build_id}-${package}/builder-live.log.gz")
-            logs+=("backend_${chroot}|${base_url}/${chroot}/${build_id}-${package}/backend.log.gz")
+            logs+=("builder_${chroot}|${base_url}/${chroot}/${build_id_alt}-${package}/builder-live.log.gz")
+            logs+=("backend_${chroot}|${base_url}/${chroot}/${build_id_alt}-${package}/backend.log.gz")
           done
 
           error=0
@@ -311,16 +337,33 @@ jobs:
 
           exit ${error}
 
+  download-artifacts:
+    name: Download and upload artifacts
+    if: always() && needs.build.outputs.BUILD_SUCCESS == 'true'
+    container: fedora:latest
+    env:
+      BUILD_ID: ${{ needs.build.outputs.BUILD_ID }}
+    needs: build
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+    steps:
+      - name: Install dependencies
+        run: |
+          dnf install -y \
+            copr-cli \
+            nodejs \
+            zip
+
       - name: Download build
         id: download-build
-        if: steps.build.outcome == 'success'
         run: |
           mkdir -p artifacts
           copr-cli \
             download-build \
             --dest . \
             --rpms \
-            ${{ steps.build.outputs.BUILD_ID }}
+            "${BUILD_ID}"
 
       - name: Setup gh actions artifact client
         id: download-build-client