style: sonar fixes

Author: ReenigneArcher

src/sync-crowdin-issues.js

@@ -483,8 +483,8 @@ async function syncExistingIssue(ghIssue, crowdinIssue, projectId, projectSlug)
   if (ghIssue.body !== expectedBody) patch.body = expectedBody;
 
   // Compare label sets (order-independent).
-  const currentLabels = (ghIssue.labels ?? []).map((l) => (typeof l === 'string' ? l : l.name)).sort();
-  const desiredLabels = [...expectedLabels].sort();
+  const currentLabels = (ghIssue.labels ?? []).map((l) => (typeof l === 'string' ? l : l.name)).sort((a, b) => a.localeCompare(b));
+  const desiredLabels = [...expectedLabels].sort((a, b) => a.localeCompare(b));
   if (JSON.stringify(currentLabels) !== JSON.stringify(desiredLabels)) {
     patch.labels = expectedLabels;
     // Ensure any new labels exist before applying them.

tests/sync-crowdin-distribution.test.js

@@ -37,7 +37,6 @@ describe('constants', () => {
 
 describe('collectBody', () => {
   it('resolves with the concatenated buffer from all data events', async () => {
-    const { EventEmitter } = require('node:events');
     const mockRes = new EventEmitter();
 
     const promise = collectBody(mockRes);
@@ -51,7 +50,6 @@ describe('collectBody', () => {
   });
 
   it('rejects when the stream emits an error', async () => {
-    const { EventEmitter } = require('node:events');
     const mockRes = new EventEmitter();
 
     const promise = collectBody(mockRes);
@@ -132,11 +130,36 @@ describe('saveFile', () => {
   });
 });
 
+// Shared test helpers
+
+const { EventEmitter } = require('node:events');
+
+/**
+ * Helper: creates a minimal IncomingMessage-like EventEmitter.
+ */
+function makeResponse({ statusCode = 200, headers = {}, body = '' } = {}) {
+  const res = new EventEmitter();
+  res.statusCode = statusCode;
+  res.headers = headers;
+  // Schedule body/end asynchronously so the promise chain runs first
+  setImmediate(() => {
+    res.emit('data', typeof body === 'string' ? Buffer.from(body) : body);
+    res.emit('end');
+  });
+  return res;
+}
+
+/**
+ * Helper: creates a minimal https.get return stub with an .on() method.
+ */
+function makeReq() {
+  return { on: jest.fn().mockReturnThis() };
+}
+
 // fetchUrl
 
 describe('fetchUrl', () => {
   const https = require('node:https');
-  const { EventEmitter } = require('node:events');
 
   let httpsGetSpy;
 
@@ -148,28 +171,6 @@ describe('fetchUrl', () => {
     jest.restoreAllMocks();
   });
 
-  /**
-   * Helper: creates a minimal IncomingMessage-like EventEmitter.
-   */
-  function makeResponse({ statusCode = 200, headers = {}, body = 'ok' }) {
-    const res = new EventEmitter();
-    res.statusCode = statusCode;
-    res.headers = headers;
-    // Schedule body/end asynchronously so the promise chain runs first
-    setImmediate(() => {
-      res.emit('data', Buffer.from(body));
-      res.emit('end');
-    });
-    return res;
-  }
-
-  /**
-   * Helper: creates a minimal https.get return stub with an .on() method.
-   */
-  function makeReq() {
-    return { on: jest.fn().mockReturnThis() };
-  }
-
   it('resolves with the body buffer for a 200 response', async () => {
     const res = makeResponse({ body: 'hello world' });
     httpsGetSpy.mockImplementation((_url, cb) => {
@@ -280,7 +281,6 @@ describe('syncDistribution', () => {
   const fs = require('node:fs');
   const path = require('node:path');
   const os = require('node:os');
-  const { EventEmitter } = require('node:events');
 
   let tmpDir;
   let httpsGetSpy;
@@ -295,21 +295,6 @@ describe('syncDistribution', () => {
     fs.rmSync(tmpDir, { recursive: true, force: true });
   });
 
-  function makeResponse({ statusCode = 200, headers = {}, body = '' }) {
-    const res = new EventEmitter();
-    res.statusCode = statusCode;
-    res.headers = headers;
-    setImmediate(() => {
-      res.emit('data', typeof body === 'string' ? Buffer.from(body) : body);
-      res.emit('end');
-    });
-    return res;
-  }
-
-  function makeReq() {
-    return { on: jest.fn().mockReturnThis() };
-  }
-
   it('returns true when all files are fetched successfully', async () => {
     const manifest = {
       timestamp: 12345,
@@ -449,7 +434,6 @@ describe('main', () => {
   const fs = require('node:fs');
   const path = require('node:path');
   const os = require('node:os');
-  const { EventEmitter } = require('node:events');
 
   let tmpDir;
   let httpsGetSpy;
@@ -480,20 +464,6 @@ describe('main', () => {
     }
   });
 
-  function makeResponse({ statusCode = 200, headers = {}, body = '' }) {
-    const res = new EventEmitter();
-    res.statusCode = statusCode;
-    res.headers = headers;
-    setImmediate(() => {
-      res.emit('data', Buffer.from(body));
-      res.emit('end');
-    });
-    return res;
-  }
-
-  function makeReq() {
-    return { on: jest.fn().mockReturnThis() };
-  }
 
   it('completes successfully when all distributions sync without error', async () => {
     // main() reads DISTRIBUTIONS at module load time, so we call syncDistribution

tests/sync-crowdin-issues.test.js

@@ -367,49 +367,44 @@ describe('ensureIssueLabels', () => {
     jest.clearAllMocks();
     jest.spyOn(console, 'log').mockImplementation(() => {});
     jest.spyOn(console, 'warn').mockImplementation(() => {});
+    mockCreateLabel.mockResolvedValue({});
   });
 
   afterEach(() => jest.restoreAllMocks());
 
   it('creates the type label and one language label for a simple language', async () => {
-    mockCreateLabel.mockResolvedValue({});
     await ensureIssueLabels({ issueType: 'source_mistake', languageId: 'fr' });
     const names = mockCreateLabel.mock.calls.map((c) => c[0].name);
     expect(names).toContain('type:source-mistake');
     expect(names).toContain('lang:fr');
   });
 
   it('creates two language labels for a compound language (pt-BR)', async () => {
-    mockCreateLabel.mockResolvedValue({});
     await ensureIssueLabels({ issueType: 'general_question', languageId: 'pt-BR' });
     const names = mockCreateLabel.mock.calls.map((c) => c[0].name);
     expect(names).toContain('lang:pt');
     expect(names).toContain('lang:pt-BR');
   });
 
   it('uses TYPE_LABEL_COLOR for the type label', async () => {
-    mockCreateLabel.mockResolvedValue({});
     await ensureIssueLabels({ issueType: 'source_mistake', languageId: 'fr' });
     const typeCall = mockCreateLabel.mock.calls.find((c) => c[0].name === 'type:source-mistake');
     expect(typeCall[0].color).toBe(TYPE_LABEL_COLOR);
   });
 
   it('uses LANG_LABEL_COLOR for language labels', async () => {
-    mockCreateLabel.mockResolvedValue({});
     await ensureIssueLabels({ issueType: 'source_mistake', languageId: 'fr' });
     const langCall = mockCreateLabel.mock.calls.find((c) => c[0].name === 'lang:fr');
     expect(langCall[0].color).toBe(LANG_LABEL_COLOR);
   });
 
   it('skips language label creation when languageId is absent', async () => {
-    mockCreateLabel.mockResolvedValue({});
     await ensureIssueLabels({ issueType: 'general_question', languageId: null });
     const names = mockCreateLabel.mock.calls.map((c) => c[0].name);
     expect(names.every((n) => !n.startsWith('lang:'))).toBe(true);
   });
 
   it('uses the raw issueType as description when not in TYPE_MAP', async () => {
-    mockCreateLabel.mockResolvedValue({});
     await ensureIssueLabels({ issueType: 'unknown_type', languageId: null });
     const typeCall = mockCreateLabel.mock.calls.find((c) => c[0].name === 'type:unknown-type');
     expect(typeCall[0].description).toBe('unknown_type');
@@ -610,7 +605,7 @@ describe('buildIssueBody', () => {
   it('places the marker as the last line', () => {
     const body = buildIssueBody(baseIssue, projectId);
     const lines = body.split('\n');
-    expect(MARKER_RE.test(lines[lines.length - 1])).toBe(true);
+    expect(MARKER_RE.test(lines.at(-1))).toBe(true);
   });
 
   it('includes the Crowdin ID in the table', () => {
@@ -622,6 +617,8 @@ describe('buildIssueBody', () => {
     expect(body).toContain('### Language Managers');
     expect(body).toContain('@fake-github');
     expect(body).toContain('https://crowdin.com/profile/fake-crowdin');
+    // Marker must still be the last line even when the managers section is present
+    expect(MARKER_RE.test(body.split('\n').at(-1))).toBe(true);
   });
 
   it('includes multiple GitHub mentions for a language with multiple managers', () => {
@@ -647,12 +644,6 @@ describe('buildIssueBody', () => {
     const body = buildIssueBody({ ...baseIssue, languageId: undefined }, projectId);
     expect(body).not.toContain('### Language Managers');
   });
-
-  it('places the marker as the last line even when managers section is present', () => {
-    const body = buildIssueBody({ ...baseIssue, languageId: 'xx' }, projectId);
-    const lines = body.split('\n');
-    expect(MARKER_RE.test(lines[lines.length - 1])).toBe(true);
-  });
 });
 
 // fetchProjectSlug