Harden macOS capture setup and cursor moves

Updates CI on macOS to fully configure screen recording by writing replayd approval data, restarting replayd, and clarifying step messaging. In QtTrayMenu, adds a bounded cursor-position wait loop with polling and timeout so mouse move/restore checks are more reliable instead of relying on a single immediate position read.

Author: ReenigneArcher

.github/workflows/ci.yml

@@ -112,6 +112,7 @@ jobs:
         if: runner.os == 'macOS'
         run: |
           dependencies=(
+            "cliclick"
             "cmake"
             "doxygen"
             "graphviz"
@@ -123,11 +124,13 @@ jobs:
           )
           brew install "${dependencies[@]}"
 
-      - name: Fix macOS screen recording permissions
+      - name: Configure macOS screen recording
         if: runner.os == 'macOS'
         run: |
           set -euo pipefail
 
+          clickTool="$(command -v cliclick)"
+
           configure_system_tccdb() {
             local values=$1
             local dbPath="/Library/Application Support/com.apple.TCC/TCC.db"
@@ -144,19 +147,29 @@ jobs:
 
           systemValuesArray=(
             "'kTCCServiceScreenCapture','/bin/bash',1,2,0,1,NULL,NULL,NULL,'UNUSED',NULL,0,1599831148"
+            "'kTCCServicePostEvent','/bin/bash',1,2,0,1,NULL,NULL,NULL,'UNUSED',NULL,0,1599831148"
+            "'kTCCServicePostEvent','$clickTool',1,2,0,1,NULL,NULL,NULL,'UNUSED',NULL,0,1599831148"
           )
           for values in "${systemValuesArray[@]}"; do
             configure_system_tccdb "$values,NULL,NULL,'UNUSED',${values##*,}"
           done
 
           userValuesArray=(
             "'kTCCServiceScreenCapture','/bin/bash',1,2,0,1,NULL,NULL,NULL,'UNUSED',NULL,0,1583997993"
+            "'kTCCServicePostEvent','/bin/bash',1,2,0,1,NULL,NULL,NULL,'UNUSED',NULL,0,1583997993"
+            "'kTCCServicePostEvent','$clickTool',1,2,0,1,NULL,NULL,NULL,'UNUSED',NULL,0,1583997993"
           )
           for values in "${userValuesArray[@]}"; do
             configure_user_tccdb "$values,NULL,NULL,'UNUSED',${values##*,}"
           done
 
-          echo "macOS TCC permissions configured."
+          preflightScreenshot="$RUNNER_TEMP/screen-capture-preflight.png"
+          screencapture -x "$preflightScreenshot"
+          sleep 1
+          "$clickTool" kp:return
+          sleep 1
+
+          echo "macOS screen recording configured."
 
       - name: Setup Dependencies Windows
         if: runner.os == 'Windows'

src/QtTrayMenu.cpp

@@ -3,7 +3,9 @@
  * @brief Definitions for Qt tray menu implemenation
  */
 // standard includes
+#include <chrono>
 #include <filesystem>
+#include <thread>
 
 // qt includes
 #include <QApplication>
@@ -22,12 +24,28 @@
 
 namespace {
   constexpr int DEFAULT_PANEL_THICKNESS = 24;
+  constexpr int CURSOR_POSITION_POLL_INTERVAL_MS = 10;
+  constexpr int CURSOR_POSITION_TIMEOUT_MS = 500;
   constexpr int CURSOR_POSITION_TOLERANCE = 2;
 
   bool positionsAreClose(const QPoint &first, const QPoint &second) {
     return (first - second).manhattanLength() <= CURSOR_POSITION_TOLERANCE;
   }
 
+  bool waitForCursorPosition(const QPoint &targetPosition, const QRect &targetGeometry = {}) {
+    const auto deadline = std::chrono::steady_clock::now() + std::chrono::milliseconds(CURSOR_POSITION_TIMEOUT_MS);
+    do {
+      const QPoint currentPosition = QCursor::pos();
+      if (targetGeometry.isValid() ? targetGeometry.contains(currentPosition) : positionsAreClose(currentPosition, targetPosition)) {
+        return true;
+      }
+      std::this_thread::sleep_for(std::chrono::milliseconds(CURSOR_POSITION_POLL_INTERVAL_MS));
+    } while (std::chrono::steady_clock::now() < deadline);
+
+    const QPoint currentPosition = QCursor::pos();
+    return targetGeometry.isValid() ? targetGeometry.contains(currentPosition) : positionsAreClose(currentPosition, targetPosition);
+  }
+
   bool fallbackTrayIconPosition(QPoint *position) {
     const QScreen *screen = QGuiApplication::primaryScreen();
     if (screen == nullptr) {
@@ -405,8 +423,7 @@ bool QtTrayMenu::positionMouseOverIcon() {
     mousePositionSaved = true;
   }
   QCursor::setPos(targetPosition);
-  const QPoint currentPosition = QCursor::pos();
-  const bool positioned = iconGeometry.isValid() ? iconGeometry.contains(currentPosition) : positionsAreClose(currentPosition, targetPosition);
+  const bool positioned = waitForCursorPosition(targetPosition, iconGeometry);
   if (!positioned) {
     qWarning("QtTrayMenu: could not position the mouse over the tray icon");
   }
@@ -419,8 +436,8 @@ bool QtTrayMenu::restoreMousePosition() {
   }
 
   QCursor::setPos(savedMousePosition);
+  const bool restored = waitForCursorPosition(savedMousePosition);
   mousePositionSaved = false;
-  const bool restored = positionsAreClose(QCursor::pos(), savedMousePosition);
   if (!restored) {
     qWarning("QtTrayMenu: could not restore the saved mouse position");
   }