Improve Windows notification test reliability

Replaces direct registry modification for Quiet Hours in CI with a date change workaround. Updates unit tests to check Windows notification state using SHQueryUserNotificationState and skip tests if notifications are not accepted, improving test reliability in CI environments.

Author: ReenigneArcher

.github/workflows/ci.yml

@@ -156,20 +156,16 @@ jobs:
           [System.Windows.Forms.SendKeys]::SendWait(" ")
           echo "::endgroup::"
 
-          echo "::group::Disable Quiet Hours"
-          Set-ItemProperty `
-            -Path "HKCU:\SOFTWARE\Microsoft\Windows\CurrentVersion\Notifications\Settings" `
-            -Name "QuietHours" `
-            -Type DWord `
-            -Value 0
-          Start-Process "gpupdate.exe" -ArgumentList "/force" -Wait
-          echo "::endgroup::"
-
           echo "::group::Minimize all windows"
           $shell = New-Object -ComObject Shell.Application
           $shell.MinimizeAll()
           echo "::endgroup::"
 
+          echo "::group::Set Date - Hack for Quiet Time"
+          $newDate = (Get-Date).AddHours(2)
+          Set-Date -Date $newDate
+          echo "::endgroup::"
+
       - name: Run tests
         id: test
         # TODO: tests randomly hang on Linux, https://github.com/LizardByte/tray/issues/45

tests/unit/test_tray.cpp

@@ -7,6 +7,10 @@
 
 #if defined(_WIN32) || defined(_WIN64)
   #include <windows.h>
+  // clang-format off
+  // build fails if shellapi.h is included before windows.h
+  #include <shellapi.h>
+  // clang-format on
   #define TRAY_WINAPI 1
 #elif defined(__linux__) || defined(linux) || defined(__linux)
   #define TRAY_APPINDICATOR 1
@@ -276,6 +280,14 @@ TEST_F(TrayTest, TestSubmenuCallback) {
 TEST_F(TrayTest, TestNotificationDisplay) {
 #if !(defined(_WIN32) || defined(__linux__) || defined(__APPLE__))
   GTEST_SKIP() << "Notifications only supported on desktop platforms";
+  #endif
+
+#if defined(_WIN32)
+  QUERY_USER_NOTIFICATION_STATE notification_state;
+  HRESULT ns = SHQueryUserNotificationState(&notification_state);
+  if (ns != S_OK || notification_state != QUNS_ACCEPTS_NOTIFICATIONS) {
+    GTEST_SKIP() << "Notifications not accepted in this environment. SHQueryUserNotificationState result: " << ns << ", state: " << notification_state;
+  }
 #endif
 
   int initResult = tray_init(&testTray);
@@ -304,6 +316,14 @@ TEST_F(TrayTest, TestNotificationCallback) {
   GTEST_SKIP() << "Notifications only supported on desktop platforms";
 #endif
 
+#if defined(_WIN32)
+  QUERY_USER_NOTIFICATION_STATE notification_state;
+  HRESULT ns = SHQueryUserNotificationState(&notification_state);
+  if (ns != S_OK || notification_state != QUNS_ACCEPTS_NOTIFICATIONS) {
+    GTEST_SKIP() << "Notifications not accepted in this environment. SHQueryUserNotificationState result: " << ns << ", state: " << notification_state;
+  }
+#endif
+
   static bool callbackInvoked = false;
   auto notification_callback = []() {
     callbackInvoked = true;