Merge pull request #4 from segmentio/main

Merge upstream
Loops-so · Aug 21, 2024 · 954b21d · 954b21d
2 parents 6729bf1 + d682103
commit 954b21d
Show file tree

Hide file tree

Showing 272 changed files with 13,522 additions and 2,689 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -62,7 +62,7 @@ module.exports = {
       }
     },
     {
-      files: ['packages/cli/**/*.ts', 'packages/cli-internal/**/*.ts'],
+      files: ['packages/cli/**/*.ts'],
       rules: {
         'lodash/import-scope': ['error', 'member'],
         '@typescript-eslint/no-var-requires': 'off'

diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -6,32 +6,28 @@
 
 # Actions common lib folder
 
-actions-shared/ @segmentio/build-experience-team @segmentio/strategic-connections-team
+actions-shared/ @segmentio/strategic-connections-team
 
 # AJV utils
 
-ajv-human-errors/ @segmentio/build-experience-team @segmentio/strategic-connections-team
+ajv-human-errors/ @segmentio/strategic-connections-team
 
 # Browser destinations
 
-browser-destinations/ @segmentio/libraries-web-team @segmentio/strategic-connections-team @segmentio/build-experience-team
-
-# CLI private libs
-
-cli-internal/ @segmentio/build-experience-team @segmentio/strategic-connections-team
+browser-destinations/ @segmentio/libraries-web-team @segmentio/strategic-connections-team
 
 # CLI binary
 
-cli/ @segmentio/build-experience-team @segmentio/strategic-connections-team
+cli/ @segmentio/strategic-connections-team
 
 # Core actions runtime
 
-core/ @segmentio/build-experience-team @segmentio/strategic-connections-team
+core/ @segmentio/strategic-connections-team
 
 # Destination definitions and their actions
 
-destination-actions/ @segmentio/strategic-connections-team @segmentio/build-experience-team
+destination-actions/ @segmentio/strategic-connections-team
 
 # Utilities for event payload validation against an action's subscription AST.
 
-destination-subscriptions/ @segmentio/build-experience-team @segmentio/strategic-connections-team
+destination-subscriptions/ @segmentio/strategic-connections-team
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -43,7 +43,14 @@ jobs:
         run: NODE_ENV=production yarn nx affected -t build --parallel=3 # nx recipe
 
       - name: Test (Affected)
-        run: yarn nx affected -t test --parallel=3 # nx recipe
+        run: yarn nx affected -t test --parallel=3 --coverage # nx recipe
+
+      - name: Upload coverage reports to Codecov
+        uses: codecov/[email protected]
+        with:
+          token: ${{ secrets.CODECOV_TOKEN }}
+          slug: segmentio/action-destinations
+          handle_no_reports_found: true # don't fail if no reports are found
 
   lint:
     name: Lint
@@ -66,15 +73,10 @@ jobs:
           registry-url: 'https://registry.npmjs.org'
           cache: yarn
 
-      - name: Use Github Personal Access Token
-        run: git config --global url."https://${{ secrets.GH_PAT }}@github.com/".insteadOf ssh://[email protected]/
-
       - uses: nrwl/nx-set-shas@v3 # nx recipe
 
       - name: Install Dependencies
         run: yarn install --frozen-lockfile
-        env:
-          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
 
       - name: Build # TODO: This monorepo should be refactored so packages can be linted invidually. "affected" will not work ATM.
         run: NODE_ENV=production yarn build # nx recipe
@@ -105,15 +107,10 @@ jobs:
           registry-url: 'https://registry.npmjs.org'
           cache: yarn
 
-      - name: Use Github Personal Access Token
-        run: git config --global url."https://${{ secrets.GH_PAT }}@github.com/".insteadOf ssh://[email protected]/
-
       - uses: nrwl/nx-set-shas@v3 # nx recipe
 
       - name: Install Dependencies
         run: yarn install --frozen-lockfile
-        env:
-          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
 
       - name: Assert yarn.lock is up-to-date
         run: bash scripts/assert-lockfile-updated.sh
@@ -156,13 +153,8 @@ jobs:
           registry-url: 'https://registry.npmjs.org'
           cache: yarn
 
-      - name: Use Github Personal Access Token
-        run: git config --global url."https://${{ secrets.GH_PAT }}@github.com/".insteadOf ssh://[email protected]/
-
       - name: Install Dependencies
         run: yarn install --frozen-lockfile
-        env:
-          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
 
       - name: Build
         run: NODE_ENV=production yarn build:browser-bundles
@@ -208,13 +200,8 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-yarn-
 
-      - name: Use Github Personal Access Token
-        run: git config --global url."https://${{ secrets.GH_PAT }}@github.com/".insteadOf ssh://[email protected]/
-
       - name: Install Dependencies
         run: yarn install --frozen-lockfile
-        env:
-          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
 
       - name: Install Browser Dependencies
         run: npx playwright install-deps
@@ -258,13 +245,8 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-yarn-
 
-      - name: Use Github Personal Access Token
-        run: git config --global url."https://${{ secrets.GH_PAT }}@github.com/".insteadOf ssh://[email protected]/
-
       - name: Install Dependencies
         run: yarn install --frozen-lockfile
-        env:
-          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
 
       - name: Run Snyk to check for vulnerabilities
         uses: snyk/actions/node@master

diff --git a/.github/workflows/publish-canary.yml b/.github/workflows/publish-canary.yml
@@ -33,8 +33,6 @@ jobs:
 
       - name: Install Dependencies
         run: yarn install --frozen-lockfile --ignore-optional
-        env:
-          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
 
       - name: Build
         run: NODE_ENV=production yarn build

diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -24,8 +24,6 @@ jobs:
 
     steps:
       - uses: actions/checkout@v4
-        with:
-          token: ${{ secrets.GH_PAT }}
 
       - name: Use Node.js ${{ matrix.node-version }}
         uses: actions/setup-node@v4
@@ -34,13 +32,8 @@ jobs:
           registry-url: 'https://registry.npmjs.org'
           cache: yarn
 
-      - name: Use Github Personal Access Token
-        run: git config --global url."https://${{ secrets.GH_PAT }}@github.com/".insteadOf ssh://[email protected]/
-
       - name: Install Dependencies
         run: yarn install --frozen-lockfile
-        env:
-          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
 
       - name: Build
         run: NODE_ENV=production yarn build

diff --git a/.nxignore b/.nxignore
@@ -1 +0,0 @@
-packages/cli-internal

diff --git a/codecov.yml b/codecov.yml
@@ -0,0 +1,21 @@
+github_checks:
+  annotations: false
+comment:
+  require_changes: true
+
+codecov:
+  require_ci_to_pass: true # Require CI to pass before uploading coverage
+  notify:
+    wait_for_ci: true
+
+# https://about.codecov.io/blog/the-5-levels-of-code-coverage-how-to-build-a-testing-culture-in-your-organization/
+# Setting this configuration as recommended for beginners in the above blog post.
+# We can introduce more strict settings as we progress.
+coverage:
+  status:
+    project:
+      default:
+        informational: false
+    patch:
+      default:
+        informational: false
diff --git a/package.json b/package.json
@@ -20,7 +20,6 @@
     "canary": "./scripts/canary.sh",
     "clean": "sh scripts/clean.sh",
     "cli": "yarn workspace @segment/actions-cli",
-    "cli-internal": "yarn workspace @segment/actions-cli-internal",
     "cloud": "yarn workspace @segment/action-destinations",
     "core": "yarn workspace @segment/actions-core",
     "lint": "ls -d ./packages/* | xargs -I {} eslint '{}/**/*.ts' --cache",

diff --git a/packages/actions-shared/package.json b/packages/actions-shared/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@segment/actions-shared",
   "description": "Shared destination action methods and definitions.",
-  "version": "1.105.0",
+  "version": "1.108.0",
   "repository": {
     "type": "git",
     "url": "https://github.com/segmentio/action-destinations",
@@ -37,7 +37,7 @@
   },
   "dependencies": {
     "@amplitude/ua-parser-js": "^0.7.25",
-    "@segment/actions-core": "^3.124.0",
+    "@segment/actions-core": "^3.127.0",
     "cheerio": "^1.0.0-rc.10",
     "dayjs": "^1.10.7",
     "escape-goat": "^3",

diff --git a/packages/browser-destination-runtime/package.json b/packages/browser-destination-runtime/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@segment/browser-destination-runtime",
-  "version": "1.53.0",
+  "version": "1.56.0",
   "license": "MIT",
   "publishConfig": {
     "access": "public",
@@ -62,7 +62,7 @@
     }
   },
   "dependencies": {
-    "@segment/actions-core": "^3.124.0"
+    "@segment/actions-core": "^3.127.0"
   },
   "devDependencies": {
     "@segment/analytics-next": "*"

diff --git a/packages/browser-destinations/destinations/1flow/package.json b/packages/browser-destinations/destinations/1flow/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@segment/analytics-browser-actions-1flow",
-  "version": "1.36.0",
+  "version": "1.39.0",
   "license": "MIT",
   "publishConfig": {
     "access": "public",
@@ -15,7 +15,7 @@
   },
   "typings": "./dist/esm",
   "dependencies": {
-    "@segment/browser-destination-runtime": "^1.53.0"
+    "@segment/browser-destination-runtime": "^1.56.0"
   },
   "peerDependencies": {
     "@segment/analytics-next": ">=1.55.0"

diff --git a/packages/browser-destinations/destinations/adobe-target/package.json b/packages/browser-destinations/destinations/adobe-target/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@segment/analytics-browser-actions-adobe-target",
-  "version": "1.54.0",
+  "version": "1.57.0",
   "license": "MIT",
   "publishConfig": {
     "access": "public",
@@ -16,7 +16,7 @@
   },
   "typings": "./dist/esm",
   "dependencies": {
-    "@segment/browser-destination-runtime": "^1.53.0"
+    "@segment/browser-destination-runtime": "^1.56.0"
   },
   "peerDependencies": {
     "@segment/analytics-next": ">=1.55.0"

diff --git a/packages/browser-destinations/destinations/algolia-plugins/package.json b/packages/browser-destinations/destinations/algolia-plugins/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@segment/analytics-browser-actions-algolia-plugins",
-  "version": "1.31.0",
+  "version": "1.34.0",
   "license": "MIT",
   "publishConfig": {
     "access": "public",
@@ -15,7 +15,7 @@
   },
   "typings": "./dist/esm",
   "dependencies": {
-    "@segment/browser-destination-runtime": "^1.53.0"
+    "@segment/browser-destination-runtime": "^1.56.0"
   },
   "peerDependencies": {
     "@segment/analytics-next": ">=1.55.0"

diff --git a/packages/browser-destinations/destinations/amplitude-plugins/package.json b/packages/browser-destinations/destinations/amplitude-plugins/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@segment/analytics-browser-actions-amplitude-plugins",
-  "version": "1.54.0",
+  "version": "1.57.0",
   "license": "MIT",
   "publishConfig": {
     "access": "public",
@@ -15,7 +15,7 @@
   },
   "typings": "./dist/esm",
   "dependencies": {
-    "@segment/browser-destination-runtime": "^1.53.0"
+    "@segment/browser-destination-runtime": "^1.56.0"
   },
   "peerDependencies": {
     "@segment/analytics-next": ">=1.55.0"

diff --git a/packages/browser-destinations/destinations/braze-cloud-plugins/package.json b/packages/browser-destinations/destinations/braze-cloud-plugins/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@segment/analytics-browser-actions-braze-cloud-plugins",
-  "version": "1.58.0",
+  "version": "1.61.0",
   "license": "MIT",
   "publishConfig": {
     "access": "public",
@@ -15,8 +15,8 @@
   },
   "typings": "./dist/esm",
   "dependencies": {
-    "@segment/analytics-browser-actions-braze": "^1.58.0",
-    "@segment/browser-destination-runtime": "^1.53.0"
+    "@segment/analytics-browser-actions-braze": "^1.61.0",
+    "@segment/browser-destination-runtime": "^1.56.0"
   },
   "peerDependencies": {
     "@segment/analytics-next": ">=1.55.0"

diff --git a/packages/browser-destinations/destinations/braze/package.json b/packages/browser-destinations/destinations/braze/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@segment/analytics-browser-actions-braze",
-  "version": "1.58.0",
+  "version": "1.61.0",
   "license": "MIT",
   "publishConfig": {
     "access": "public",
@@ -35,8 +35,8 @@
   "dependencies": {
     "@braze/web-sdk": "npm:@braze/web-sdk@^4.1.0",
     "@braze/web-sdk-v3": "npm:@braze/web-sdk@^3.5.1",
-    "@segment/actions-core": "^3.124.0",
-    "@segment/browser-destination-runtime": "^1.53.0"
+    "@segment/actions-core": "^3.127.0",
+    "@segment/browser-destination-runtime": "^1.56.0"
   },
   "peerDependencies": {
     "@segment/analytics-next": ">=1.55.0"

diff --git a/packages/browser-destinations/destinations/bucket/package.json b/packages/browser-destinations/destinations/bucket/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@segment/analytics-browser-actions-bucket",
-  "version": "1.34.0",
+  "version": "1.37.0",
   "license": "MIT",
   "publishConfig": {
     "access": "public",
@@ -16,8 +16,8 @@
   "typings": "./dist/esm",
   "dependencies": {
     "@bucketco/tracking-sdk": "^2.0.0",
-    "@segment/actions-core": "^3.124.0",
-    "@segment/browser-destination-runtime": "^1.53.0"
+    "@segment/actions-core": "^3.127.0",
+    "@segment/browser-destination-runtime": "^1.56.0"
   },
   "peerDependencies": {
     "@segment/analytics-next": ">=1.55.0"

diff --git a/packages/browser-destinations/destinations/cdpresolution/package.json b/packages/browser-destinations/destinations/cdpresolution/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@segment/analytics-browser-actions-cdpresolution",
-  "version": "1.41.0",
+  "version": "1.44.0",
   "license": "MIT",
   "publishConfig": {
     "access": "public",
@@ -15,7 +15,7 @@
   },
   "typings": "./dist/esm",
   "dependencies": {
-    "@segment/browser-destination-runtime": "^1.53.0"
+    "@segment/browser-destination-runtime": "^1.56.0"
   },
   "peerDependencies": {
     "@segment/analytics-next": ">=1.55.0"

diff --git a/packages/browser-destinations/destinations/commandbar/package.json b/packages/browser-destinations/destinations/commandbar/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@segment/analytics-browser-actions-commandbar",
-  "version": "1.54.0",
+  "version": "1.57.0",
   "license": "MIT",
   "publishConfig": {
     "access": "public",
@@ -15,8 +15,8 @@
   },
   "typings": "./dist/esm",
   "dependencies": {
-    "@segment/actions-core": "^3.124.0",
-    "@segment/browser-destination-runtime": "^1.53.0"
+    "@segment/actions-core": "^3.127.0",
+    "@segment/browser-destination-runtime": "^1.56.0"
   },
   "peerDependencies": {
     "@segment/analytics-next": ">=1.55.0"