Merge in main #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(Jimo/Settings): add refetchExperiencesOnTraitsUpdate * fix(Jimo/SendUserData): use identify instead of user:id and add new setting refetchExperiencesOnTraitsUpdate * fix(Jimo/Tests): fix & add test for experience refetching
* updating device id field * fix tests
* adding field to control attribute creation * updating contentstack * updating test * tests for contentstack * registering contentstack plugin * completing registration * fixing tests * adding null check
* new workflow added * SECURITY | Add SECURITY.MD * SD-107645 | Products ingesting incorrectly * SD-107645 | Products ingesting incorrectly * SD-107645 | Products ingesting incorrectly * SD-107645 | Products ingesting incorrectly * SD-107645 | Products ingesting incorrectly * SD-107645 | Products ingesting incorrectly * SD-107645 | Products ingesting incorrectly --------- Co-authored-by: insider-automation <[email protected]> Co-authored-by: Sezer Güven <[email protected]>
* initial commit * fix failing tests * updated saveUser action * updated saveOrder action * updated saveEvent action * added action descriptions * updated presets * flattened saveEvent mapping * fixed saveEvent.perform * fixed saveEvent mapping * updated snapshots * updated snapshots * fixed saveEvent payload structure * don't include empty objects in payload * updated * progress * restructure events * remove defaults for optional fields * restore address field * update untranslated title default values * updated snapshots * remove unused import * fixed default paths * reorganized saveUser fields * updated saveBaseEvent fields * fixed default_address default in saveUser * moved custom event name to saveBaseEvent * updated tests * added defaults for customer field in saveEvent * test commit * refactor fields * consistent naming for fields variables * removed cartFields from saveCartEvent * removed less important saveOrder fields * updated event names * moved event name field from common fields * fixed field name * refactor event fields * updated generated types * updated tests * fixed checkout fields * updated payload transformation functions * removed custom event preset * fixed identifiers transformation * updated tests * wrapped cart and checkout fields into objects * updated tests * minor changes to presets * added missing checkout event name * fixed saveUser payload structure --------- Co-authored-by: Jonathan Sudhakar <[email protected]> Co-authored-by: Joe Ayoub <[email protected]>
* fix for non standard identifiers * supporting deviceId and advertisingId OOB * further tweak * generated types
* add alphabetic account id * generate
* initial push * added subfolder functionality * removing various commented code and cleanup for PR * cleaning up operation file and removing snapshot.test.ts * fixing index.ts and operations.ts errors * updating s3 with unit test failure fixes * revising all changes, tested to make sure they work * defining interface for credentials * fixing undefined unit tests * fixing folderName undefined value * trying to fix undefined * non null assertation block added * updating yarn.lock to that of master branch * feat(code): add uploadCsv test; update yarn.lock * cleaning up comments * removing console log in performBatch * fixing trycatch wrapper and removing data const * fixing test failures * fixing error message * removing console.log * refactored changes from meeting with Jeremy * refactor * changing everyting * adding operations * more done * removed error validate * added credentials checking * fixing upload function * fixed double payload * more progress * filename fix * fix addnl props traits * add steps to assume intermediary role * removing test --------- Co-authored-by: Mayur Pitale <[email protected]> Co-authored-by: Jason Sooter <[email protected]> Co-authored-by: Joe Ayoub <[email protected]> Co-authored-by: Varadarajan V <[email protected]>
… release branch (#2184) * [version-packages] allow version-package workflow to create PRs to release branch * cut version branch from base_branch input
* Add support for external Id * [s3 action] add steps to assume intermediary role * update description
#2187) * update types * added a note on default displayMode
…nt (#2198) * fix: remove email unsub link when unsubcribe tag not present * chore: add unit test and comment
…sion-packages (#2203) * introduce publish canary workflow * Allow to publish from hotfix-* branches * Add run_id to workflow * mark run_id as false * revert lerna.json
* initial commit * fix failing tests * updated saveUser action * updated saveOrder action * updated saveEvent action * added action descriptions * updated presets * flattened saveEvent mapping * fixed saveEvent.perform * fixed saveEvent mapping * updated snapshots * updated snapshots * fixed saveEvent payload structure * don't include empty objects in payload * updated * progress * restructure events * remove defaults for optional fields * restore address field * update untranslated title default values * updated snapshots * remove unused import * fixed default paths * reorganized saveUser fields * updated saveBaseEvent fields * fixed default_address default in saveUser * moved custom event name to saveBaseEvent * updated tests * added defaults for customer field in saveEvent * test commit * refactor fields * consistent naming for fields variables * removed cartFields from saveCartEvent * removed less important saveOrder fields * updated event names * moved event name field from common fields * fixed field name * refactor event fields * updated generated types * updated tests * fixed checkout fields * updated payload transformation functions * removed custom event preset * fixed identifiers transformation * updated tests * wrapped cart and checkout fields into objects * updated tests * minor changes to presets * added missing checkout event name * fixed saveUser payload structure * fixed typo * updated tests --------- Co-authored-by: Jonathan Sudhakar <[email protected]> Co-authored-by: Joe Ayoub <[email protected]>
… accounts and tags are properly applied (#2167) * Add new tag handling and creating a contact/revuser without an account * Add coverage and tests * Fixup the tags work, verify running locally * Update types * Update the tests correctly
* First implementation + unit tests. * Not using `rawData` in the type. That breaks the build. * Just not checking `data` for a `rawData` property. * Update packages/destination-actions/src/destinations/adjust/index.ts Co-authored-by: Joe Ayoub <[email protected]> * Update packages/destination-actions/src/destinations/adjust/functions.ts Co-authored-by: Joe Ayoub <[email protected]> * Update packages/destination-actions/src/destinations/adjust/functions.ts Co-authored-by: Joe Ayoub <[email protected]> * Modifications requested in PR review. * Unit test adjustments. * Not using snapshot tests. * Updating generated types. * ready for deploy --------- Co-authored-by: Joe Ayoub <[email protected]> Co-authored-by: Joe Ayoub <[email protected]>
* adding new s3 csv destination * adding s3 lib * varada change * fixing forbidden non null assertion * Publish (#2196) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Publish - @segment/[email protected] * Publish --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Varadarajan V <[email protected]>
…2188) * Revert [Stratconn 3257] Add batching to segment connections (#1859) * Added messageid and consent and fixed unit test cases --------- Co-authored-by: Gaurav Kochar <[email protected]>
…and send under traits in SendIdentify (#2169) * Made Address as separate key and send under traits * Added unit test case --------- Co-authored-by: Gaurav Kochar <[email protected]>
* bug fixes for aws-s3-csv destination * add audience name to filename * setting full_audience_sync to false --------- Co-authored-by: Mayur Pitale <[email protected]>
* additional props traits changes * fixing issue with headers --------- Co-authored-by: Joe Ayoub <[email protected]>
* Update README.md * x * blend updated version * new update * fixing preset * * add auth header * resolve conflict * fix from comment * modify sending structure * refactor & formatting * Remove .tool-versions file * remove required on new fields * * created new action /trackEvents - to replace /sendData action * more revert * remove * comment * added properties according to comments * generated types * * added depreacted to sendData action * more fixes --------- Co-authored-by: Yuval Zandbank <[email protected]> Co-authored-by: Yuval <[email protected]> Co-authored-by: joe-ayoub-segment <[email protected]> Co-authored-by: spiderman <[email protected]>
* fix broken test * fixing action file reference
* Iterable Lists destination base declaration. * Iterable Lists basic implementation + tests * Typo. * saving state - review with Leonel * continue review with joe * Reimplementing Iterable List Action with more settings and using natural action fields to get context values. * Updating unit tests. * working session with Leonel * working session with Leonel * working session with Leonel * working session with Leonel * working session with Leonel * Updating unit tests. * Not testing snapshots. --------- Co-authored-by: Joe Ayoub <[email protected]>
…ence key value (#2177) * add ability to set profile field based on audience property value * add tests for new profile id value functionality * remove auth return statement used for development * change empty string option to useAudienceKey * correct comment in function * fix generated types * apply suggestions from code review * correct label and description casing * add punctuation * remove test destination
* Update index.ts * Update index.ts * Update index.ts * Update index.ts * Update index.ts
* adding batch support * Fix Optimizely Unit test after batching * removing mocked payload * fixing rawData bug * removing unnecessary interface * updated tests * submitting generated types --------- Co-authored-by: Sam Pontefract <[email protected]> Co-authored-by: Romani-Ramzi <[email protected]> Co-authored-by: Romani Ramzi <[email protected]>
askkaz
pushed a commit
that referenced
this pull request
Aug 21, 2024
* feat(actions): initial template and mappings (#2) * feat(actions): initial template, types and presets * feat: tests & snapshots (#3) * tests & snapshots * fix: correct partnerAction values (#11) * fix: repeated lines at impression test (#12) * fix: repeated asserts in test * fix: making click description action focused Co-authored-by: Thomas Gilbert <[email protected]> * fix: making impression description action focused Co-authored-by: Thomas Gilbert <[email protected]> * fix: making purchase description action focused Co-authored-by: Thomas Gilbert <[email protected]> * fix: update snapshots (#13) * fix: correct partnerAction values * fix: syntax fix impression description Co-authored-by: Thomas Gilbert <[email protected]> --------- Co-authored-by: Thomas Gilbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.