v0.2.3

* HAL: fixed an issue in the lgw_reg_r()/lgw_reg_w()/lgw_reg_rb()/lgw_reg_wb()
functions to write the register page before reading/writing any register to
avoid conflicting with MCU register page setting.

Author: mcoracin

VERSION

@@ -1 +1 @@
-0.2.2
+0.2.3

libloragw/src/loragw_reg.c

@@ -651,7 +651,8 @@ int lgw_reg_w(uint16_t register_id, int32_t reg_value) {
     }
 
     /* select proper register page if needed */
-    if ((r.page != -1) && (r.page != lgw_regpage)) {
+    /* don't rely on lgw_regpage as the MCU could have changed the page index */
+    if (r.page != -1) {
         com_stat += page_switch(r.page);
     }
 
@@ -689,7 +690,8 @@ int lgw_reg_r(uint16_t register_id, int32_t *reg_value) {
     r = loregs[register_id];
 
     /* select proper register page if needed */
-    if ((r.page != -1) && (r.page != lgw_regpage)) {
+    /* don't rely on lgw_regpage as the MCU could have changed the page index */
+    if (r.page != -1) {
         com_stat += page_switch(r.page);
     }
 
@@ -737,7 +739,8 @@ int lgw_reg_wb(uint16_t register_id, uint8_t *data, uint16_t size) {
     }
 
     /* select proper register page if needed */
-    if ((r.page != -1) && (r.page != lgw_regpage)) {
+    /* don't rely on lgw_regpage as the MCU could have changed the page index */
+    if (r.page != -1) {
         com_stat += page_switch(r.page);
     }
 
@@ -780,7 +783,8 @@ int lgw_reg_rb(uint16_t register_id, uint8_t *data, uint16_t size) {
     r = loregs[register_id];
 
     /* select proper register page if needed */
-    if ((r.page != -1) && (r.page != lgw_regpage)) {
+    /* don't rely on lgw_regpage as the MCU could have changed the page index */
+    if (r.page != -1) {
         com_stat += page_switch(r.page);
     }
 

readme.md

@@ -1,9 +1,9 @@
-	 / _____)             _              | |    
-	( (____  _____ ____ _| |_ _____  ____| |__  
-	 \____ \| ___ |    (_   _) ___ |/ ___)  _ \ 
-	 _____) ) ____| | | || |_| ____( (___| | | |
-	(______/|_____)_|_|_| \__)_____)\____)_| |_|
-	  (C)2013 Semtech-Cycleo
+     / _____)             _              | |
+    ( (____  _____ ____ _| |_ _____  ____| |__
+     \____ \| ___ |    (_   _) ___ |/ ___)  _ \
+     _____) ) ____| | | || |_| ____( (___| | | |
+    (______/|_____)_|_|_| \__)_____)\____)_| |_|
+     (C)2013 Semtech-Cycleo
 
 LoRa Gateway project
 =====================
@@ -13,18 +13,18 @@ LoRa Gateway project
 
 This directory contains the sources of the library to build a LoRa Picocell
 Gateway based on a Semtech LoRa multi-channel RF receiver (a.k.a. concentrator).
-Once compiled all the code is contained in the libloragw.a file that will be 
+Once compiled all the code is contained in the libloragw.a file that will be
 statically linked (ie. integrated in the final executable).
 The library implements the communication with the concentrator embedded MCU
 through a serial port.
 
-The library also comes with a bunch of basic tests programs that are used to 
+The library also comes with a bunch of basic tests programs that are used to
 test the different sub-modules of the library.
 
 ## 2. Helper programs
 ---------------------
 
-Those programs are included in the project to provide examples on how to use 
+Those programs are included in the project to provide examples on how to use
 the HAL library, and to help the system builder test different parts of it.
 
 ### 2.1. util_pkt_logger ###
@@ -67,11 +67,17 @@ This software is used to obtain the unique id of the PicoCell gateway (the
 ## 4. User Guide
 ----------------
 
-[A detailed PicoCell GW user guide is available here](http://www.semtech.com/images/datasheet/picocell_gateway_user_guide.pdf)
+[A detailed PicoCell GW user guide is available here](https://github.com/Lora-net/picoGW_hal/wiki/Instructions-&-User-guide)
 
 ## 5. Changelog
 ---------------
 
+### v0.2.3  ###
+
+* HAL: fixed an issue in the lgw_reg_r()/lgw_reg_w()/lgw_reg_rb()/lgw_reg_wb()
+functions to write the register page before reading/writing any register to
+avoid conflicting with MCU register page setting.
+
 ### v0.2.2  ###
 
 * HAL: updated MCU firmware version to match with picoGW_mcu V0.2.1 release.
@@ -120,24 +126,24 @@ device path to be used to communicate with the concentrator board (tty...).
 ## 6. Legal notice
 ------------------
 
-The information presented in this project documentation does not form part of 
-any quotation or contract, is believed to be accurate and reliable and may be 
-changed without notice. No liability will be accepted by the publisher for any 
-consequence of its use. Publication thereof does not convey nor imply any 
-license under patent or other industrial or intellectual property rights. 
-Semtech assumes no responsibility or liability whatsoever for any failure or 
-unexpected operation resulting from misuse, neglect improper installation, 
-repair or improper handling or unusual physical or electrical stress 
-including, but not limited to, exposure to parameters beyond the specified 
-maximum ratings or operation outside the specified range. 
-
-SEMTECH PRODUCTS ARE NOT DESIGNED, INTENDED, AUTHORIZED OR WARRANTED TO BE 
-SUITABLE FOR USE IN LIFE-SUPPORT APPLICATIONS, DEVICES OR SYSTEMS OR OTHER 
-CRITICAL APPLICATIONS. INCLUSION OF SEMTECH PRODUCTS IN SUCH APPLICATIONS IS 
+The information presented in this project documentation does not form part of
+any quotation or contract, is believed to be accurate and reliable and may be
+changed without notice. No liability will be accepted by the publisher for any
+consequence of its use. Publication thereof does not convey nor imply any
+license under patent or other industrial or intellectual property rights.
+Semtech assumes no responsibility or liability whatsoever for any failure or
+unexpected operation resulting from misuse, neglect improper installation,
+repair or improper handling or unusual physical or electrical stress
+including, but not limited to, exposure to parameters beyond the specified
+maximum ratings or operation outside the specified range.
+
+SEMTECH PRODUCTS ARE NOT DESIGNED, INTENDED, AUTHORIZED OR WARRANTED TO BE
+SUITABLE FOR USE IN LIFE-SUPPORT APPLICATIONS, DEVICES OR SYSTEMS OR OTHER
+CRITICAL APPLICATIONS. INCLUSION OF SEMTECH PRODUCTS IN SUCH APPLICATIONS IS
 UNDERSTOOD TO BE UNDERTAKEN SOLELY AT THE CUSTOMER'S OWN RISK. Should a
-customer purchase or use Semtech products for any such unauthorized 
-application, the customer shall indemnify and hold Semtech and its officers, 
-employees, subsidiaries, affiliates, and distributors harmless against all 
+customer purchase or use Semtech products for any such unauthorized
+application, the customer shall indemnify and hold Semtech and its officers,
+employees, subsidiaries, affiliates, and distributors harmless against all
 claims, costs damages and attorney fees which could arise.
 
 *EOF*