Skip to content

Commit e42f30a

Browse files
authored
Merge pull request #31 from LordSimal/3.x
merge 3.x => 3.next
2 parents 72e10f3 + 707eb00 commit e42f30a

File tree

4 files changed

+27
-14
lines changed

4 files changed

+27
-14
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ jobs:
5454
5555
- name: Code Coverage Report
5656
if: success() && matrix.php-version == '8.1'
57-
uses: codecov/codecov-action@v4
57+
uses: codecov/codecov-action@v5
5858

5959
cs-stan:
6060
name: Coding Standard & Static Analysis

src/Http/SentryClient.php

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
namespace CakeSentry\Http;
55

66
use Cake\Core\Configure;
7+
use Cake\Database\Driver;
78
use Cake\Datasource\ConnectionManager;
89
use Cake\Error\PhpError;
910
use Cake\Event\Event;
@@ -53,13 +54,17 @@ protected function getQueryLoggers(): void
5354
$includeSchemaReflection = (bool)Configure::read('CakeSentry.includeSchemaReflection');
5455

5556
foreach ($configs as $name) {
57+
$logger = null;
5658
$connection = ConnectionManager::get($name);
5759
if ($connection->configName() === 'debug_kit') {
5860
continue;
5961
}
60-
/** @var \Cake\Database\Driver $driver */
62+
/** @var \Cake\Database\Driver|object $driver */
6163
$driver = $connection->getDriver();
62-
$logger = $driver->getLogger();
64+
65+
if ($driver instanceof Driver) {
66+
$logger = $driver->getLogger();
67+
}
6368

6469
if ($logger instanceof CakeSentryLog) {
6570
$logger->setIncludeSchema($includeSchemaReflection);

src/Middleware/CakeSentryPerformanceMiddleware.php

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
*/
1414
namespace CakeSentry\Middleware;
1515

16+
use Cake\Database\Driver;
1617
use Cake\Datasource\ConnectionManager;
1718
use Cake\Event\EventManager;
1819
use Cake\Http\Server;
@@ -121,13 +122,15 @@ protected function addQueryData(): void
121122
continue;
122123
}
123124
$logger = null;
124-
/** @var \Cake\Database\Driver $driver */
125+
/** @var \Cake\Database\Driver|object $driver */
125126
$driver = $connection->getDriver();
126-
$driverConfig = $driver->config();
127-
if ($driverConfig['sentryLog'] ?? false) {
128-
$logger = $driver->getLogger();
129-
if ($logger instanceof CakeSentryLog) {
130-
$logger->setPerformanceMonitoring(true);
127+
if ($driver instanceof Driver) {
128+
$driverConfig = $driver->config();
129+
if ($driverConfig['sentryLog'] ?? false) {
130+
$logger = $driver->getLogger();
131+
if ($logger instanceof CakeSentryLog) {
132+
$logger->setPerformanceMonitoring(true);
133+
}
131134
}
132135
}
133136
}

src/Middleware/CakeSentryQueryMiddleware.php

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
namespace CakeSentry\Middleware;
1515

1616
use Cake\Core\Configure;
17+
use Cake\Database\Driver;
1718
use Cake\Datasource\ConnectionManager;
1819
use CakeSentry\Database\Log\CakeSentryLog;
1920
use Psr\Http\Message\ResponseInterface;
@@ -57,15 +58,19 @@ protected function enableQueryLogging(): void
5758
continue;
5859
}
5960
$logger = null;
60-
/** @var \Cake\Database\Driver $driver */
61+
/** @var \Cake\Database\Driver|object $driver */
6162
$driver = $connection->getDriver();
62-
$driverConfig = $driver->config();
63-
if ($driverConfig['sentryLog'] ?? false) {
64-
$logger = $driver->getLogger();
63+
if ($driver instanceof Driver) {
64+
$driverConfig = $driver->config();
65+
if ($driverConfig['sentryLog'] ?? false) {
66+
$logger = $driver->getLogger();
67+
}
6568
}
6669

6770
$logger = new CakeSentryLog($logger, $name, $includeSchemaReflection);
68-
$driver->setLogger($logger);
71+
if (method_exists($driver, 'setLogger')) {
72+
$driver->setLogger($logger);
73+
}
6974
}
7075
}
7176
}

0 commit comments

Comments
 (0)