|
6 | 6 | pull_request: |
7 | 7 | branches: [main] |
8 | 8 |
|
| 9 | +permissions: |
| 10 | + contents: read |
| 11 | + pull-requests: write |
| 12 | + |
9 | 13 | jobs: |
10 | 14 | test: |
11 | 15 | name: Unit & Integration Tests |
|
27 | 31 | - name: Run linter |
28 | 32 | run: npm run lint |
29 | 33 |
|
30 | | - - name: Run baseline tests |
31 | | - run: npm run test:baseline |
32 | | - continue-on-error: false |
33 | | - |
34 | | - - name: Run unit tests (if they exist) |
35 | | - run: npm test -- run unit || echo "No unit tests found yet" |
36 | | - continue-on-error: true |
37 | | - |
38 | | - - name: Run integration tests (if they exist) |
39 | | - run: npm run test:integration || echo "No integration tests found yet" |
40 | | - continue-on-error: true |
41 | | - |
42 | 34 | - name: Run all tests with coverage |
43 | | - run: npm run test:coverage -- run || echo "Tests passed with warnings" |
44 | | - continue-on-error: false |
| 35 | + run: npm run test:coverage |
45 | 36 |
|
46 | 37 | - name: Upload coverage to Codecov |
47 | 38 | uses: codecov/codecov-action@v4 |
|
78 | 69 | run: npm ci |
79 | 70 |
|
80 | 71 | - name: Install Playwright browsers |
81 | | - run: npx playwright install --with-deps chromium firefox webkit |
| 72 | + run: npx playwright install --with-deps chromium |
82 | 73 |
|
83 | 74 | - name: Run E2E tests |
84 | 75 | run: npm run test:e2e |
@@ -164,10 +155,11 @@ jobs: |
164 | 155 | run: npm ci |
165 | 156 |
|
166 | 157 | - name: Build production bundle |
167 | | - # PHASE 0 TEMPORARY: Disable treating warnings as errors |
| 158 | + # TODO: Remove CI=false after fixing ESLint warnings (target: Phase 3) |
168 | 159 | # Create React App treats warnings as errors when CI=true |
169 | | - # Re-enable in Phase 3 (Code Quality & Refactoring) by removing CI=false |
170 | | - # Known warnings: unused variables in App.js, ArrayUpdateMenu.jsx, ListElement.jsx |
| 160 | + # Known warnings: unused variables in App.js (lines 119, 122, 596, 618, 2852) |
| 161 | + # unused variables in ArrayUpdateMenu.jsx (line 13) |
| 162 | + # Issue: https://github.com/LorenFrankLab/rec_to_nwb_yaml_creator/issues/[TBD] |
171 | 163 | run: CI=false npm run build |
172 | 164 |
|
173 | 165 | - name: Upload build artifacts |
|
0 commit comments