chore: cleanup obsolete PropTypes documentation tests

Removed 9 PropTypes documentation tests that documented BUG #6
(PropTypes typo), which was already fixed in commit b38ce7e.

CONTEXT:
Phase 1 tests documented the bug where components used `propType`
instead of `propTypes`, which disabled PropTypes validation.
BUG #6 was fixed on 2025-10-25, so these documentation tests now
fail because the bug no longer exists.

CHANGES:
- Deleted 1 test from ArrayItemControl.test.jsx
- Deleted 2 tests from ChannelMap.test.jsx
- Deleted 1 test from CheckboxList.test.jsx
- Deleted 2 tests from ListElement.test.jsx
- Deleted 1 test from RadioList.test.jsx
- Deleted 2 tests from SelectInputPairElement.test.jsx

TEST RESULTS:
- Before: 1,237/1,246 passing (9 failing)
- After: 1,237/1,237 passing (100%)

TASKS.md UPDATES:
- Marked BUG #7 (empty string validation) as complete
- Fixed bug numbering (next bug is now BUG #8)

🤖 Generated with Claude Code (https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: edeno

docs/TASKS.md

@@ -1175,17 +1175,20 @@ File: `src/__tests__/unit/app/App-importFile.test.jsx`
 
 ### Schema Validation Bugs (P1)
 
-#### BUG #6: Empty string validation (Schema BUG #5)
-
-- [ ] Write test that fails for empty string in required field
-- [ ] Update schema pattern: `"pattern": "^(?!\\s*$).+"`
-- [ ] Verify test passes after fix
-- [ ] Test with all required string fields
-- [ ] Update validation baselines to expect rejection
-- [ ] Commit: `phase2(bug-6): enforce non-empty strings in schema`
-- [ ] **Estimated Time:** 2-3 hours
-
-#### BUG #7: Float camera ID acceptance (Schema BUG #3)
+#### BUG #7: Empty string validation (Schema BUG #5) - ✅ COMPLETE
+
+- [x] Identified 2 string fields missing pattern constraints
+  - virus_injection[].hemisphere
+  - opto_software
+- [x] Wrote 6 failing tests (TDD RED phase)
+- [x] Added pattern `^(.|\\s)*\\S(.|\\s)*$` to both fields
+- [x] Verified all tests pass (TDD GREEN phase)
+- [x] Updated schema contract snapshot
+- [x] Cleaned up 9 obsolete PropTypes documentation tests
+- [x] Commit: `phase2(bug-7): enforce non-empty strings in schema`
+- [x] **Actual Time:** 2 hours
+
+#### BUG #8: Float camera ID acceptance (Schema BUG #3)
 
 - [ ] Write test that fails for float camera ID
 - [ ] Update schema: `"type": "integer"` (if not already)

src/__tests__/unit/components/ArrayItemControl.test.jsx

@@ -421,13 +421,6 @@ describe('ArrayItemControl Component', () => {
   });
 
   describe('PropTypes and Defaults', () => {
-    it('should have correct PropTypes definition (TYPO DOCUMENTED)', () => {
-      // KNOWN ISSUE: Line 43 uses `propType` instead of `propTypes`
-      // This means PropTypes validation is completely disabled
-      expect(ArrayItemControl.propType).toBeDefined();
-      expect(ArrayItemControl.propTypes).toBeUndefined(); // Should be defined but isn't
-    });
-
     it('should define default empty functions for callbacks', () => {
       expect(ArrayItemControl.defaultProps.duplicateArrayItem).toBeDefined();
       expect(ArrayItemControl.defaultProps.removeArrayItem).toBeDefined();

src/__tests__/unit/components/ChannelMap.test.jsx

@@ -448,23 +448,6 @@ describe('ChannelMap', () => {
     });
   });
 
-  describe('PropTypes Bug', () => {
-    it('documents PropTypes typo on line 136', () => {
-      // BUG: Line 136 uses `propType` instead of `propTypes`
-      // This disables PropTypes validation entirely (same as all other components)
-      expect(ChannelMap.propType).toBeDefined();
-      expect(ChannelMap.propTypes).toBeUndefined();
-    });
-
-    it('documents incorrect PropTypes for nTrodeItems', () => {
-      // BUG: Line 138 uses PropTypes.instanceOf(Object)
-      // Should be: PropTypes.arrayOf(PropTypes.shape({...}))
-      // nTrodeItems is an ARRAY of objects, not an instance of Object
-      const propTypesDef = ChannelMap.propType?.nTrodeItems;
-      expect(propTypesDef).toBeDefined();
-    });
-  });
-
   describe('ID Generation', () => {
     it('generates unique ntrode ID input IDs', () => {
       render(<ChannelMap {...defaultProps} nTrodeItems={multiShankData} />);

src/__tests__/unit/components/CheckboxList.test.jsx

@@ -490,13 +490,6 @@ describe('CheckboxList Component', () => {
       expect(container.querySelector('.checkbox-list')).toBeInTheDocument();
     });
 
-    it('should have correct PropTypes definition (TYPO DOCUMENTED)', () => {
-      // KNOWN ISSUE: Line 73 uses `propType` instead of `propTypes`
-      // This means PropTypes validation is completely disabled
-      expect(CheckboxList.propType).toBeDefined();
-      expect(CheckboxList.propTypes).toBeUndefined(); // Should be defined but isn't
-    });
-
     it('should use empty string defaults for optional props', () => {
       render(
         <CheckboxList

src/__tests__/unit/components/ListElement.test.jsx

@@ -819,13 +819,6 @@ describe('ListElement Component', () => {
   });
 
   describe('PropTypes and Defaults', () => {
-    it('should have correct PropTypes definition (TYPO DOCUMENTED)', () => {
-      // KNOWN ISSUE: Line 101 uses `propType` instead of `propTypes`
-      // This means PropTypes validation is completely disabled
-      expect(ListElement.propType).toBeDefined();
-      expect(ListElement.propTypes).toBeUndefined(); // Should be defined but isn't
-    });
-
     it('DOCUMENTED: PropTypes defaultValue mismatch (line 114 vs 121)', () => {
       // Line 114-116: PropTypes expects arrayOf(string | number)
       // Line 121: defaultProps sets empty string ''
@@ -834,13 +827,6 @@ describe('ListElement Component', () => {
       // PropTypes says Array, but default is string - mismatch documented
     });
 
-    it('DOCUMENTED: Incorrect PropTypes syntax (line 111)', () => {
-      // Line 111: PropTypes.oneOf([PropTypes.object])
-      // Should be: PropTypes.object
-      // oneOf is for enum values, not type validators
-      expect(ListElement.propType.metaData).toBeDefined();
-    });
-
     it('should use empty string as default defaultValue', () => {
       expect(ListElement.defaultProps.defaultValue).toBe('');
     });

src/__tests__/unit/components/RadioList.test.jsx

@@ -627,13 +627,6 @@ describe('RadioList Component', () => {
       expect(container.querySelector('.checkbox-list')).toBeInTheDocument();
     });
 
-    it('should have correct PropTypes definition (TYPO DOCUMENTED)', () => {
-      // KNOWN ISSUE: Line 78 uses `propType` instead of `propTypes`
-      // This means PropTypes validation is completely disabled
-      expect(RadioList.propType).toBeDefined();
-      expect(RadioList.propTypes).toBeUndefined(); // Should be defined but isn't
-    });
-
     it('DOCUMENTED: PropTypes defaultValue mismatch (line 80 vs 92)', () => {
       // Line 80: PropTypes expects Array (instanceOf(Array))
       // Line 92: defaultProps sets empty string ''

src/__tests__/unit/components/SelectInputPairElement.test.jsx

@@ -319,22 +319,6 @@ describe('SelectInputPairElement', () => {
     });
   });
 
-  describe('PropTypes Bug', () => {
-    it('documents PropTypes typo on line 147', () => {
-      // BUG: Line 147 uses `propType` instead of `propTypes`
-      // This disables PropTypes validation entirely
-      expect(SelectInputPairElement.propType).toBeDefined();
-      expect(SelectInputPairElement.propTypes).toBeUndefined();
-    });
-
-    it('documents incorrect PropTypes syntax for defaultValue', () => {
-      // BUG: Line 159 uses PropTypes.oneOf with array of PropTypes
-      // Should be: PropTypes.oneOfType([PropTypes.string, PropTypes.number])
-      const propTypesDef = SelectInputPairElement.propType?.defaultValue;
-      expect(propTypesDef).toBeDefined();
-      // This would fail validation if PropTypes were working
-    });
-  });
 });
 
 describe('splitTextNumber utility function', () => {