Merge ts-domain-optocompleteness: type the opto-completeness predicate under strict TS

domain/optoCompleteness.js → strict .ts (behavior-preserving): optoFieldsPresence takes a
permissive OptoFields, returns typed OptoFieldsPresence; count provably identical. Payoff:
validation/rules/optoRules.ts drops its Parameters<typeof …> cast (Record<string,any> model
is assignable to OptoFields). Verified: typecheck clean, validation + sectionStatus + baselines
(483) byte-identical, full suite 4793, CI=true build, e2e 104. Code-reviewer: behavior-preserving,
zero findings.

Author: edeno

.claude/docs/research/architecture-assessment.md

@@ -36,7 +36,7 @@ or enforced tokens** (F6), and **deferred lint debt that weakens the build gate*
 
 | Gap | Evidence | Why it bites refactoring |
 | --- | --- | --- |
-| **No static types** ⏳ PARTIAL | Incremental TS underway (`tsc --noEmit` CI gate live): `io/yaml.ts`, `state/workspaceTypes.ts` + the task-catalog modules, `domain/deviceOverrideMerge.ts`, and the Phase-9a validation leaf modules (`repairRouting`/`geometryProvenance`/`dayOverrideValidation`/`stepStatus`) are `.ts` under `strict`; the **entire `validation/` directory** (leaf predicates + `rules/*` families + `rulesValidation` composer + `index`/`schemaValidation`/`rawShape`/`quickChecks`/`useQuickChecks` + the shared `issueTypes.ts`) is now `.ts` under `strict`; the `state/` migration is underway — the persistence layer (`state/workspaceMigrations.ts` + `state/persistence.ts`) the canonical read layer (`state/workspaceSelectors.ts`, `unknown`-in / typed-container-out), and the first selector-consumers (`state/configDiff.ts`, `state/cameraUsage.ts`) are `.ts`. Remaining: most of `state/` (`workspaceUtils`/`workspaceTransitions`/`workspaceActions`/…) + `domain/`, most components, `useWorkspace`, and the legacy form path stay JS (`checkJs:false`) | Rename a domain fn or change an `Animal`/`Day` shape → **silent until a test happens to exercise it.** No safe IDE rename, no null-safety. Tooling agent scored type-safety **2/10** (improving as the pure core converts). |
+| **No static types** ⏳ PARTIAL | Incremental TS underway (`tsc --noEmit` CI gate live): `io/yaml.ts`, `state/workspaceTypes.ts` + the task-catalog modules, `domain/deviceOverrideMerge.ts` + `domain/optoCompleteness.ts`, and the Phase-9a validation leaf modules (`repairRouting`/`geometryProvenance`/`dayOverrideValidation`/`stepStatus`) are `.ts` under `strict`; the **entire `validation/` directory** (leaf predicates + `rules/*` families + `rulesValidation` composer + `index`/`schemaValidation`/`rawShape`/`quickChecks`/`useQuickChecks` + the shared `issueTypes.ts`) is now `.ts` under `strict`; the `state/` migration is underway — the persistence layer (`state/workspaceMigrations.ts` + `state/persistence.ts`) the canonical read layer (`state/workspaceSelectors.ts`, `unknown`-in / typed-container-out), and the first selector-consumers (`state/configDiff.ts`, `state/cameraUsage.ts`) are `.ts`. Remaining: most of `state/` (`workspaceUtils`/`workspaceTransitions`/`workspaceActions`/…) + `domain/`, most components, `useWorkspace`, and the legacy form path stay JS (`checkJs:false`) | Rename a domain fn or change an `Animal`/`Day` shape → **silent until a test happens to exercise it.** No safe IDE rename, no null-safety. Tooling agent scored type-safety **2/10** (improving as the pure core converts). |
 | **Oversized files/components** ⏳ PARTIAL | ~~`domain/validation.js` 1142~~ ✅ split (Phase 9a) into routing/provenance/producers/composer/step-status modules · ~~`validation/rulesValidation.js` 1108~~ ✅ split into `validation/rules/*` families (reference / opto / channelMap / electrodeGroup / dandiSubject / identity / behavioralEvent) + a 96-LOC composer · `valueList.js` 1073 · ~~`ValidationSummary/index.jsx` 1033~~ ✅ decomposed (Phase 9c-1) into rows-helpers / batch-action hook / ExportReport / BatchExportPreflight / DayStatusTable (index now 306) · ~~`DevicesStep.jsx` 825~~ ✅ decomposed (Phase 9c-3) into CamerasUsedSection / OverrideCleanupSection / ConfigVersionPanel / ElectrodeGroupsAccordion (step now 424) · `OptogeneticsFields.jsx` 826 · ~~`RecordingDaysTab.jsx` 822~~ ✅ decomposed (Phase 9c-2) into AnimalSetupCard / ExistingDataReview / DayList / DuplicateDayModal (tab now 496) · ~~`useWorkspace.js` 851~~ ✅ split into `workspaceActions` (createWorkspaceActions factory) / `useWorkspacePersistence` (status + autosave + saveNow) / `workspaceHydration` (resolveInitialWorkspace) + a pure `getAnimalDays` in `workspaceSelectors` (hook now 98) | High intrinsic load to change; many concerns per file; merge-conflict magnets. |
 | **~2,000 LOC legacy dead-weight** | `OptogeneticsFields.jsx` (826, imported only by `LegacyFormView`), `element/*`, `*Fields`, `LegacyFormView.jsx` — parallel to the workspace path | Every workspace UX/styling change risks needing a legacy twin; or the legacy code rots unmaintained. |
 | **CSS: no scoping, partial tokens** (= F6) | Global CSS, `.button-primary` redefined in 6 files, two different error icons, ~60% token adoption, mixed `.css`/`.scss` | Visual inconsistency *and* fragile edits — changing a shared style can leak across components. |

CHANGELOG.md

@@ -9,6 +9,18 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+- **Typed the optogenetics-completeness predicate under strict TS (refactor only, no behavior change).**
+  [domain/optoCompleteness.js](src/domain/optoCompleteness.ts) → `.ts`: `optoFieldsPresence` (the single
+  source of truth for "which of the four opto fields count as present") now takes a permissive
+  `OptoFields` and returns a typed `OptoFieldsPresence` (`{ …four booleans, count }`); the `isOptoList…`
+  / `isOptoSoftware…` helpers take `unknown`. Body equivalent — the `presence.count = …` post-assignment
+  is rewritten as four `const`s + a single returned object (same values). As a **payoff, the consumer
+  `validation/rules/optoRules.ts` drops its `model as Parameters<typeof optoFieldsPresence>[0]` cast** —
+  a `Record<string, any>` model is assignable to `OptoFields` directly. The other consumer
+  (`domain/sectionStatus.js`) is JS, so the rename is transparent. Validation (incl. opto rules) +
+  `sectionStatus` + golden baselines (483) pass; `npm run typecheck` + `CI=true` build clean; full suite
+  4793; e2e 104.
+
 - **Typed the day camera-usage helpers under strict TS (refactor only, no behavior change).**
   [state/cameraUsage.js](src/state/cameraUsage.ts) → `.ts`: `inferredCameraKeys` / `referencedCameraKeys`
   / `resolveDayCameraUsage` (→ `Camera[]`) / `findCameraAffectedDays` and the `cameraKey` helper are

src/domain/optoCompleteness.js src/domain/optoCompleteness.tssrc/domain/optoCompleteness.js renamed to src/domain/optoCompleteness.ts

@@ -18,49 +18,63 @@
  * site reads them from its own source).
  */
 
+/** The four optogenetics field VALUES (each call site reads them from its own source). */
+export interface OptoFields {
+  /** The excitation-source list. */
+  opto_excitation_source?: unknown;
+  /** The optical-fiber list. */
+  optical_fiber?: unknown;
+  /** The virus-injection list. */
+  virus_injection?: unknown;
+  /** The stimulation-software string. */
+  optogenetic_stimulation_software?: unknown;
+}
+
+/** Each optogenetics field's presence boolean plus the total count of present fields. */
+export interface OptoFieldsPresence {
+  opto_excitation_source: boolean;
+  optical_fiber: boolean;
+  virus_injection: boolean;
+  optogenetic_stimulation_software: boolean;
+  count: number;
+}
+
 /**
  * A list opto field counts as present only when it's a non-empty array (corrupt non-array → absent).
  * @param value
  */
-const isOptoListPresent = (value) => Array.isArray(value) && value.length > 0;
+const isOptoListPresent = (value: unknown): boolean => Array.isArray(value) && value.length > 0;
 
 /**
  * The software field counts as present only when it's a non-empty trimmed string.
  * @param value
  */
-const isOptoSoftwarePresent = (value) => typeof value === 'string' && value.trim() !== '';
+const isOptoSoftwarePresent = (value: unknown): boolean =>
+  typeof value === 'string' && value.trim() !== '';
 
 /**
  * Compute the per-field presence of the four optogenetics fields from their VALUES.
  *
- * @param {object} fields - The four field values (read from the caller's own source).
- * @param {*} fields.opto_excitation_source - The excitation-source list.
- * @param {*} fields.optical_fiber - The optical-fiber list.
- * @param {*} fields.virus_injection - The virus-injection list.
- * @param {*} fields.optogenetic_stimulation_software - The stimulation-software string.
- * @returns {{
- *   opto_excitation_source: boolean,
- *   optical_fiber: boolean,
- *   virus_injection: boolean,
- *   optogenetic_stimulation_software: boolean,
- *   count: number,
- * }} Each field's presence boolean plus the total count of present fields.
+ * @param fields - The four field values (read from the caller's own source).
  */
-export function optoFieldsPresence(fields) {
-  const source = fields || {};
-  const presence = {
-    opto_excitation_source: isOptoListPresent(source.opto_excitation_source),
-    optical_fiber: isOptoListPresent(source.optical_fiber),
-    virus_injection: isOptoListPresent(source.virus_injection),
-    optogenetic_stimulation_software: isOptoSoftwarePresent(
-      source.optogenetic_stimulation_software
-    ),
+export function optoFieldsPresence(fields: OptoFields | null | undefined): OptoFieldsPresence {
+  const source: OptoFields = fields || {};
+  const opto_excitation_source = isOptoListPresent(source.opto_excitation_source);
+  const optical_fiber = isOptoListPresent(source.optical_fiber);
+  const virus_injection = isOptoListPresent(source.virus_injection);
+  const optogenetic_stimulation_software = isOptoSoftwarePresent(
+    source.optogenetic_stimulation_software
+  );
+  return {
+    opto_excitation_source,
+    optical_fiber,
+    virus_injection,
+    optogenetic_stimulation_software,
+    count: [
+      opto_excitation_source,
+      optical_fiber,
+      virus_injection,
+      optogenetic_stimulation_software,
+    ].filter(Boolean).length,
   };
-  presence.count = [
-    presence.opto_excitation_source,
-    presence.optical_fiber,
-    presence.virus_injection,
-    presence.optogenetic_stimulation_software,
-  ].filter(Boolean).length;
-  return presence;
 }

src/validation/rules/optoRules.ts

@@ -31,7 +31,7 @@ export function optogeneticsRules(model: ValidationModel): ValidationIssue[] {
   // nav count can never drift. The arrays use Array.isArray(...) && length > 0 (a corrupt non-array
   // value is NOT present); the software is a non-empty trimmed string — matching the converter's
   // len()>0 on the string.
-  const optoPresence = optoFieldsPresence(model as Parameters<typeof optoFieldsPresence>[0]);
+  const optoPresence = optoFieldsPresence(model);
   const hasOptoSource = optoPresence.opto_excitation_source;
   const hasOpticalFiber = optoPresence.optical_fiber;
   const hasVirusInjection = optoPresence.virus_injection;