You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit b2b8d68
Browse filesBrowse the repository at this point in the historyBrowse files
code-reviewer / pr-test-analyzer / type-design-analyzer / ux-reviewer:
Correctness:
- applyConfigurationForward ignores day ids not in the workspace (no phantom
entries leaking into appliedToDays); dedups and updates only real days.
- resolveDayConfig guards a snapshot missing its `devices` (closes a latent crash).
A11y / UX (ReconfigWizard):
- role="alertdialog" + aria-describedby for this consequential multi-day action.
- Clear the validation error as the user edits; aria-describedby links the error.
- Relabel the action "Apply to N days" (shows the count); add a summary line and a
day-selection hint explaining the default scope (this day onward).
- Humanize changed electrode-group field names (e.g. location -> brain region).
- Cancel button labeled "Cancel and close"; render the wizard as a sibling of the
version bar (not nested in the flex layout); remount per day/version (fresh state).
- Fix WCAG-AA contrast on the no-change italic text (#777 -> #666).
- Guard empty snapshot description/date in the DevicesStep version bar.
Types/contracts:
- New ProbeConfigDiff typedef; document the appliedToDays partition invariant and
mark it a denormalized cache (authoritative source is Day.configurationVersion).
- updateDay notes that setting configurationVersion bypasses appliedToDays sync.
- DevicesStep actions PropTypes tightened to a shape; both components use
destructuring defaults instead of defaultProps.
Tests: add ntrode-removed, combined map+bad-channels, empty/undefined-config diff,
and phantom-day-id cases. Deferred items recorded in overview.md.
Baselines 125/125; full suite 2961 passed / 1 skipped.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
0 commit comments