Speedup get_sorting (#1246)

* Avoid repeated calls to recording.get_times() and use itertuples

* Update changelog

Author: edeno

CHANGELOG.md

@@ -22,11 +22,10 @@
 - Spikesorting
     - Fix compatibility bug between v1 pipeline and `SortedSpikesGroup` unit
         filtering #1238
-
+    - Speedup `get_sorting` on `CurationV1` #1246
 - Behavior
     - Implement pipeline for keypoint-moseq extraction of behavior syllables #1056
 
-
 ## [0.5.4] (December 20, 2024)
 
 ### Infrastructure

src/spyglass/spikesorting/v1/curation.py

@@ -203,25 +203,22 @@ def get_sorting(cls, key: dict) -> si.BaseSorting:
         analysis_file_abs_path = AnalysisNwbfile.get_abs_path(
             analysis_file_name
         )
+
         with pynwb.NWBHDF5IO(
             analysis_file_abs_path, "r", load_namespaces=True
         ) as io:
             nwbf = io.read()
             units = nwbf.units.to_dataframe()
-        units_dict_list = [
-            {
-                unit_id: np.searchsorted(recording.get_times(), spike_times)
-                for unit_id, spike_times in zip(
-                    units.index, units["spike_times"]
-                )
-            }
-        ]
 
-        sorting = si.NumpySorting.from_unit_dict(
-            units_dict_list, sampling_frequency=sampling_frequency
-        )
+        recording_times = recording.get_times()
+        units_dict = {
+            unit.Index: np.searchsorted(recording_times, unit.spike_times)
+            for unit in units.itertuples()
+        }
 
-        return sorting
+        return si.NumpySorting.from_unit_dict(
+            [units_dict], sampling_frequency=sampling_frequency
+        )
 
     @classmethod
     def get_merged_sorting(cls, key: dict) -> si.BaseSorting: