-
Notifications
You must be signed in to change notification settings - Fork 52
Closed
Labels
Description
Describe the bug
- Rather than an
ElectrodeGrouptable, theLFPBandV1pipeline stores/selects electrodes with the part tableLFPBandSelection.LFPBandElectrode - In the tutorial users are directed to use
LFPBandSelection.set_lfp_band_electrodesto create the selection entry- If there is an existing entry for the
LFPBandSelectionkey they're using, and they specify additional electrodes not in the original entry this will add those electrodes to the part table - If
LFPBandV1was already populated for the selection entry, there is now a mismatch between the entries inLFPBandSelection.LFPBandElectrodeand what is calculated and stored inLFPBandV1
- If there is an existing entry for the
Short Term Fix
- In
LFPBandSelection.set_lfp_band_electrodes, check if existingLFPBandSelectionentry.- If so, if the specified electrodes don't match what is already in the part table, raise an error/warning and don't insert
Longer Term Fix
- Above solution does not allow creation of new
LFPBandV1entry with different electrode selection for a givenLFP+ filter combination. Can be an issue if original entry was only made for a small subset of electrodes. - Issue comes from combination of the concept of a Selection table and a Group table in
LFPBandSelection - Would suggest separating in any future pipeline version