Update src/trodes_to_nwb/convert_position.py

edeno · Copilot · web-flow · commit 38038193b7af · 2025-09-26T07:21:25.000-07:00
Co-authored-by: Copilot &lt;175728472+Copilot@users.noreply.github.com&gt;
diff --git a/src/trodes_to_nwb/convert_position.py b/src/trodes_to_nwb/convert_position.py
@@ -1147,7 +1147,7 @@ def convert_h264_to_mp4(file: str, video_directory: str) -> str:
 
     try:
         # Construct the ffmpeg command
-        subprocess.run(["ffmpeg", "-i", file, new_file_name], check=False)
+        subprocess.run(["ffmpeg", "-i", file, new_file_name], check=True)
         logger.info(
             f"Video conversion completed. {file} has been converted to {new_file_name}"
         )

Original file line number	Diff line number	Diff line change
`@@ -1147,7 +1147,7 @@ def convert_h264_to_mp4(file: str, video_directory: str) -> str:`
`1147`	`1147`
`1148`	`1148`	`try:`
`1149`	`1149`	`# Construct the ffmpeg command`
`1150`		`- subprocess.run(["ffmpeg", "-i", file, new_file_name], check=False)`
	`1150`	`+ subprocess.run(["ffmpeg", "-i", file, new_file_name], check=True)`
`1151`	`1151`	`logger.info(`
`1152`	`1152`	`f"Video conversion completed. {file} has been converted to {new_file_name}"`
`1153`	`1153`	`)`