suggestions from review

Author: samuelbray32

src/trodes_to_nwb/convert_optogenetics.py

@@ -32,29 +32,15 @@ def add_optogenetics(nwbfile: NWBFile, metadata: dict, device_metadata: List[dic
         List of dictionaries containing metadata for devices used in the experiment.
     """
     logger = logging.getLogger("convert")
+    necessary_metadata = [
+        "virus_injection",
+        "opto_excitation_source",
+        "optical_fiber",
+        "optogenetic_stimulation_software",
+    ]
+
     if not (
-        all(
-            [
-                x in metadata
-                for x in [
-                    "virus_injection",
-                    "opto_excitation_source",
-                    "optical_fiber",
-                    "optogenetic_stimulation_software",
-                ]
-            ]
-        )
-        and all(
-            [
-                len(metadata[x]) > 0
-                for x in [
-                    "virus_injection",
-                    "opto_excitation_source",
-                    "optical_fiber",
-                    "optogenetic_stimulation_software",
-                ]
-            ]
-        )
+        all([((x in metadata) and len(metadata[x]) > 0) for x in necessary_metadata])
     ):
         logger.info("No available optogenetic metadata")
         return