Apply suggestions from code review

Co-authored-by: Ryan Ly <[email protected]>

Author: samuelbray32

src/trodes_to_nwb/spike_gadgets_raw_io.py

@@ -139,7 +139,7 @@ def _produce_ephys_channel_ids(
             # case where all channels are recorded, no censoring required
             return channel_names
 
-        if hw_channels_recorded is None:
+        if not hw_channels_recorded or len(hw_channels_recorded) != n_channels_recorded:
             raise ValueError(
                 "If n_total_channels != n_channels_recorded, "
                 "hw_channels_recorded must be provided to censor the returned list."
@@ -191,9 +191,7 @@ def _parse_header(self):
         num_chip_channels = int(
             hconf.attrib["numChannels"]
         )  # number of channels the hardware supports
-        num_ephy_channels = int(
-            hconf.attrib["numChannels"]
-        )  # number of channels recorder
+        num_ephy_channels = num_chip_channels  # number of channels recorded
         # check for agreement with number of channels in xml
         sconf_channels = np.sum([len(x) for x in sconf])
         if sconf_channels < num_ephy_channels: