test: Refactor transaction ID generation test for improved clarity and error handling

Author: Lqm1

mod_test.ts

@@ -8,32 +8,28 @@ import { assertEquals } from "@std/assert";
 import { handleXMigration, ClientTransaction } from "./mod.ts";
 
 /**
- * Test to verify the transaction ID generation process with default keys
+ * Test to verify the transaction ID generation process
  *
  * This test performs the following steps:
- * 1. Fetches the X homepage and extracts guest token
- * 2. Creates a ClientTransaction instance
- * 3. Generates a transaction ID for a specific API endpoint using default keys
+ * 1. Fetches the X homepage and extracts guest token for each request
+ * 2. Creates a new ClientTransaction instance for each request
+ * 3. Generates a transaction ID for a specific API endpoint
  * 4. Makes 25 API requests and verifies all of them are successful (100% success rate)
+ *
+ * Note: Rate limiting may occur. Rate limiting produces the same 404 errors
+ * as an invalid x-client-transaction-id. If more than 50% of requests return 404
+ * or if all requests fail with 404, try opening any user profile page in Chrome
+ * in private to check. If rate limiting is in effect, Chrome will also show errors.
  */
 Deno.test(
-  "Generate and verify transaction ID for X API UserByScreenName endpoint with default keys",
+  "Generate and verify transaction ID for X API UserByScreenName endpoint",
   async () => {
-    // Arrange: Set up necessary data and objects
-    const document = await handleXMigration();
-    const guestToken =
-      document.documentElement.outerHTML.match(/gt=([0-9]+);/)?.[1] || null;
-
-    if (!guestToken) {
-      throw new Error("Failed to extract guest token from the document");
-    }
-
-    const ct = await ClientTransaction.create(document);
     const totalRequests = 25;
     let successfulRequests = 0;
+    let notFoundErrors = 0;
 
-    // Create a base request
-    const createRequest = () =>
+    // Create a base request function
+    const createRequest = (guestToken: string) =>
       new Request(
         "https://api.x.com/graphql/1VOOyvKkiI3FMmkeDNxM9A/UserByScreenName?variables=%7B%22screen_name%22%3A%22elonmusk%22%7D&features=%7B%22hidden_profile_subscriptions_enabled%22%3Atrue%2C%22profile_label_improvements_pcf_label_in_post_enabled%22%3Atrue%2C%22rweb_tipjar_consumption_enabled%22%3Atrue%2C%22verified_phone_label_enabled%22%3Afalse%2C%22subscriptions_verification_info_is_identity_verified_enabled%22%3Atrue%2C%22subscriptions_verification_info_verified_since_enabled%22%3Atrue%2C%22highlights_tweets_tab_ui_enabled%22%3Atrue%2C%22responsive_web_twitter_article_notes_tab_enabled%22%3Atrue%2C%22subscriptions_feature_can_gift_premium%22%3Atrue%2C%22creator_subscriptions_tweet_preview_api_enabled%22%3Atrue%2C%22responsive_web_graphql_skip_user_profile_image_extensions_enabled%22%3Afalse%2C%22responsive_web_graphql_timeline_navigation_enabled%22%3Atrue%7D&fieldToggles=%7B%22withAuxiliaryUserLabels%22%3Atrue%7D",
         {
@@ -65,10 +61,30 @@ Deno.test(
       );
 
     // Act: Generate multiple transaction IDs and test them
-    console.log(`Running ${totalRequests} API requests with default keys...`);
+    console.log(`Running ${totalRequests} API requests...`);
 
     for (let i = 0; i < totalRequests; i++) {
-      const request = createRequest();
+      console.log(`Request ${i + 1}/${totalRequests}: Fetching X homepage...`);
+
+      // Create new document and ClientTransaction instance for each request
+      const document = await handleXMigration();
+      const guestToken =
+        document.documentElement.outerHTML.match(/gt=([0-9]+);/)?.[1] || null;
+
+      if (!guestToken) {
+        console.error(
+          `Request ${i + 1}: Failed to extract guest token from the document`
+        );
+        continue;
+      }
+
+      // Create a new ClientTransaction instance
+      const ct = await ClientTransaction.create(document);
+
+      // Create request with fresh guest token
+      const request = createRequest(guestToken);
+
+      // Generate transaction ID with the fresh ClientTransaction instance
       const transactionId = await ct.generateTransactionId(
         request.method,
         new URL(request.url).pathname
@@ -77,22 +93,29 @@ Deno.test(
 
       // Execute the request
       try {
+        console.log(`Request ${i + 1}/${totalRequests}: Executing API call...`);
         const response = await fetch(request);
         await response.text();
 
         if (response.ok) {
           successfulRequests++;
+          console.log(`Request ${i + 1}/${totalRequests}: Success`);
         } else {
           console.error(
-            `Request ${i + 1} failed with status: ${response.status}`
+            `Request ${i + 1}/${totalRequests}: Failed with status: ${
+              response.status
+            }`
           );
+          if (response.status === 404) {
+            notFoundErrors++;
+          }
         }
       } catch (error) {
-        console.error(`Request ${i + 1} error:`, error);
+        console.error(`Request ${i + 1}/${totalRequests}: Error:`, error);
       }
 
       // Small delay between requests to avoid rate limiting
-      await new Promise((resolve) => setTimeout(resolve, 100));
+      await new Promise((resolve) => setTimeout(resolve, 200));
     }
 
     console.log(
@@ -101,6 +124,24 @@ Deno.test(
         100
       ).toFixed(2)}%)`
     );
+    console.log(
+      `404 Not Found errors: ${notFoundErrors}/${totalRequests} (${(
+        (notFoundErrors / totalRequests) *
+        100
+      ).toFixed(2)}%)`
+    );
+
+    if (
+      notFoundErrors > totalRequests / 2 ||
+      notFoundErrors === totalRequests
+    ) {
+      console.warn(
+        "Possible rate limiting detected. Try opening any user profile page in Chrome to verify."
+      );
+      console.warn(
+        "If rate limiting is occurring, errors will also appear in the browser."
+      );
+    }
 
     // Assert: Verify all requests were successful (100% success rate)
     assertEquals(