Nagisa's review

Author: LucasSte

llvm/lib/Target/SBF/SBFISelLowering.cpp

@@ -400,7 +400,8 @@ SDValue SBFTargetLowering::LowerFormalArguments(
         int64_t Offset = static_cast<int64_t>(VA.getLocMemOffset() + Size);
         // Since the stack grows to the opposite direction in V3, the offset
         // is inverted.
-        if (!Subtarget->getHasDynamicFramesV3())
+        if (Subtarget->getFrameLowering()->getStackGrowthDirection() ==
+            TargetFrameLowering::StackGrowsDown)
           Offset = -Offset;
 
         const int FrameIndex =
@@ -527,7 +528,8 @@ SDValue SBFTargetLowering::LowerCall(TargetLowering::CallLoweringInfo &CLI,
 
       // Since the stack grows to the opposite direction in V3, the offset
       // is inverted.
-      if (Subtarget->getHasDynamicFramesV3())
+      if (Subtarget->getFrameLowering()->getStackGrowthDirection() ==
+          TargetFrameLowering::StackGrowsUp)
         Offset = -Offset;
 
       int FrameIndex = MF.getFrameInfo().CreateFixedObject(

llvm/lib/Target/SBF/SBFSubtarget.cpp

@@ -66,11 +66,11 @@ void SBFSubtarget::initSubtargetFeatures(StringRef CPU, StringRef FS) {
 
 SBFSubtarget::SBFSubtarget(const Triple &TT, const std::string &CPU,
                            const std::string &FS, const TargetMachine &TM)
-: SBFGenSubtargetInfo(TT, cpuFromSubArch(TT, CPU),
-                      /*TuneCPU*/ cpuFromSubArch(TT, CPU), FS),
-  InstrInfo(), FrameLowering(initializeSubtargetDependencies(
-                                 TT, cpuFromSubArch(TT, CPU), FS)
-                                 .getHasDynamicFramesV3()),
+  : SBFGenSubtargetInfo(TT, cpuFromSubArch(TT, CPU),
+                        /*TuneCPU*/ cpuFromSubArch(TT, CPU), FS),
+    InstrInfo(), FrameLowering(initializeSubtargetDependencies(
+                                   TT, cpuFromSubArch(TT, CPU), FS)
+                                   .getHasDynamicFramesV3()),
   TLInfo(TM, *this) {
   assert(TT.getArch() == Triple::sbf && "expected Triple::sbf");