Skip to content

Peer to peer code code reviewΒ #8

Description

@RuriEnciso

Hi @Luffytaro22 ,

Good job so far! πŸ‘. Your Code is Awesome! πŸ’ͺ

There are some few issues πŸ› that you still need to work πŸ”§ on though to go to the next project ⏭️ but you are almost there! πŸƒ

Don't Worry πŸ™

It's ok to have bugs in your code πŸ›. Especially if that's is your first project 1️⃣. Please, see this code review as a chance for you to learn practical coding skills and learn new tips that can improve your code quality πŸ’― and help you get a better job πŸ’Ό.

I am going to guide you on how to fix them down below. πŸ€“

Required Changes ♻️

Check the comments under the review.

  • Could you consider removing the max-with of the * global container because it makes an issue with the sides of the webpage.
  • Kindly consider changing the height of the footer to get a better UX.
  • I think it should be better if you resize the img tags with other responsive sizes like rem , % , em. because they improve your responsive design.

Happy coding!!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions