Skip to content

Commit cca0e9e

Browse files
committed
test(flowcontrol): correct FullPath backpressure comment
The inline comment claimed the FullPath benchmark sustains W>L queuing, but worker count rounds down to <= L and the real detector's in-flight load is released near-instantly, so dispatch is effectively free-flowing. Reword to match the function godoc: FullPath prices dispatch + the detector's per-cycle DynamicAttribute reads, not sustained backpressure. Signed-off-by: Luke Van Drie <lukevandrie@google.com>
1 parent 636836e commit cca0e9e

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

pkg/epp/flowcontrol/benchmark/benchmark_test.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -304,9 +304,10 @@ func BenchmarkFlowController_FullPath(b *testing.B) {
304304

305305
telemetry := newBenchmarkTelemetry()
306306

307-
// Concurrency-gated: each dispatched request consumes a detector slot and
308-
// releases it after ResponseBody, so W workers > L limit sustains backpressure
309-
// and forces real queuing in the dispatch cycle.
307+
// Concurrency-gated by the real detector: each dispatched request records in-flight load (via
308+
// PreRequest) and releases it after ResponseBody. Load is held only briefly, so this measures
309+
// free-flowing dispatch plus the detector's per-cycle DynamicAttribute read cost rather than
310+
// sustained W>L queuing.
310311
var globalReqID atomic.Uint64
311312

312313
b.ResetTimer()

0 commit comments

Comments
 (0)