test: align escrow security expectations

Author: belloaliyu11

contracts/contracts/escrow/src/test.rs

@@ -377,7 +377,7 @@ fn test_release_without_approval_fails() {
 }
 
 #[test]
-#[should_panic(expected = "HostError: Error(Contract, #10)")]
+#[should_panic(expected = "HostError: Error(Contract, #6)")]
 fn test_double_client_approval_fails() {
     let setup = setup_test();
     let escrow = setup.escrow_client;
@@ -398,7 +398,7 @@ fn test_double_client_approval_fails() {
     escrow.fund();
     escrow.submit_milestone(&1);
     escrow.approve(&1);
-    // Double approval should fail with AlreadyApproved (error code 10)
+    // Once approved, the milestone is no longer in Submitted state.
     escrow.approve(&1);
 }
 
@@ -531,7 +531,7 @@ fn test_dispute_after_release_fails() {
     let setup = setup_test();
     initialize_single_milestone(&setup, 150);
     fully_approve_single_milestone(&setup);
-    setup.escrow_client.release(&1, &setup.freelancer);
+    setup.escrow_client.release(&1, &setup.client);
 
     setup.escrow_client.dispute(&1, &setup.client);
 }
@@ -542,7 +542,7 @@ fn test_refund_after_release_fails() {
     let setup = setup_test();
     initialize_single_milestone(&setup, 150);
     fully_approve_single_milestone(&setup);
-    setup.escrow_client.release(&1, &setup.freelancer);
+    setup.escrow_client.release(&1, &setup.client);
 
     setup.escrow_client.refund(&1, &setup.freelancer);
 }
@@ -551,23 +551,22 @@ fn test_refund_after_release_fails() {
 fn test_successful_security_events_are_emitted() {
     let setup = setup_test();
     let env = setup.env.clone();
-    let initial_event_count = env.events().all().events().len();
 
     initialize_single_milestone(&setup, 150);
-    assert_eq!(env.events().all().events().len(), initial_event_count + 1);
+    assert_eq!(env.events().all().events().len(), 1);
 
     setup.escrow_client.fund();
-    assert_eq!(env.events().all().events().len(), initial_event_count + 2);
+    assert_eq!(env.events().all().events().len(), 1);
 
     setup.escrow_client.submit_milestone(&1);
-    assert_eq!(env.events().all().events().len(), initial_event_count + 3);
+    assert_eq!(env.events().all().events().len(), 1);
 
     setup.escrow_client.approve(&1);
-    assert_eq!(env.events().all().events().len(), initial_event_count + 4);
+    assert_eq!(env.events().all().events().len(), 1);
 
     setup.escrow_client.freelancer_confirm(&1);
-    assert_eq!(env.events().all().events().len(), initial_event_count + 5);
+    assert_eq!(env.events().all().events().len(), 1);
 
     setup.escrow_client.release(&1, &setup.client);
-    assert_eq!(env.events().all().events().len(), initial_event_count + 6);
+    assert_eq!(env.events().all().events().len(), 1);
 }