cdl: Fix VK_EXT_layer_settings implementation

Author: christophe-lunarg

src/cdl.cpp

@@ -203,8 +203,8 @@ Context::Context(const VkInstanceCreateInfo* pCreateInfo, const VkAllocationCall
     const auto* settings_ci = vku::FindStructInPNextChain<VkLayerSettingsCreateInfoEXT>(pCreateInfo);
 
     VkuLayerSettingSet layer_setting_set = VK_NULL_HANDLE;
-    VkResult result =
-        vkuCreateLayerSettingSet("lunarg_crash_diagnostic", settings_ci, pAllocator, nullptr, &layer_setting_set);
+    VkResult result = vkuCreateLayerSettingSet("VK_LAYER_LUNARG_crash_diagnostic", settings_ci, pAllocator, nullptr,
+                                               &layer_setting_set);
     if (result != VK_SUCCESS) {
         Log().Error("vkuCreateLayerSettingSet failed with error %d", result);
         return;

tests/framework/layer_settings.cpp

@@ -20,13 +20,13 @@
 #include <cstring>
 
 #define MakeStringSetting(_name) \
-    vk::LayerSettingEXT(kLayerSettingsName, #_name, vk::LayerSettingTypeEXT::eString, 1, &_name)
+    vk::LayerSettingEXT(kLayerName, #_name, vk::LayerSettingTypeEXT::eString, 1, &_name)
 
 #define MakeBoolSetting(_name) \
-    vk::LayerSettingEXT(kLayerSettingsName, #_name, vk::LayerSettingTypeEXT::eBool32, 1, &_name)
+    vk::LayerSettingEXT(kLayerName, #_name, vk::LayerSettingTypeEXT::eBool32, 1, &_name)
 
 #define MakeUint64Setting(_name) \
-    vk::LayerSettingEXT(kLayerSettingsName, #_name, vk::LayerSettingTypeEXT::eUint64, 1, &_name)
+    vk::LayerSettingEXT(kLayerName, #_name, vk::LayerSettingTypeEXT::eUint64, 1, &_name)
 
 LayerSettings::LayerSettings(const void* pnext)
     : settings_{