Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pincode validator to check for valid pincodes #172

Merged
merged 6 commits into from
Oct 5, 2024

Conversation

Somnath-Chattaraj
Copy link
Contributor

@Somnath-Chattaraj Somnath-Chattaraj commented Oct 5, 2024

Used a npm package to check for valid pincode

Images for reference

  • image with incorrect pincode
Screenshot 2024-10-05 at 12 00 51 PM
  • image with correct pincode. Also console log the pincode details
Screenshot 2024-10-05 at 12 01 21 PM

@Luson045 Hopes you find it helpful. Please give it a level Hacktoberfest-accepted

Copy link

vercel bot commented Oct 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medi-connect ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2024 4:01pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
med-space ⬜️ Ignored (Inspect) Visit Preview Oct 5, 2024 4:01pm

Copy link

netlify bot commented Oct 5, 2024

Deploy Preview for medi-connect-in ready!

Name Link
🔨 Latest commit 3483c1f
🔍 Latest deploy log https://app.netlify.com/sites/medi-connect-in/deploys/670162ddf71873000838712c
😎 Deploy Preview https://deploy-preview-172--medi-connect-in.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Somnath-Chattaraj
Copy link
Contributor Author

@Luson045 do i need to do anything else?

@Luson045
Copy link
Owner

Luson045 commented Oct 5, 2024

@Somnath-Chattaraj you weren't assigned this issue... have you read the announcements?

@Somnath-Chattaraj
Copy link
Contributor Author

Somnath-Chattaraj commented Oct 5, 2024

@Luson045 since it was a long time the assignee has not reponsed with any pr so I did it. A request, please accept this pr or give it a label, since my first pr #63 which i coauthored has not been detched as a pull request in hacktoberfest. Hope you will understand

@Luson045
Copy link
Owner

Luson045 commented Oct 5, 2024

@hmm okay merge the conflixts

@Somnath-Chattaraj
Copy link
Contributor Author

@Luson045 done

@Somnath-Chattaraj
Copy link
Contributor Author

@Luson045 you merge it as it also check for valid pincodes which is not done in pr #184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants