Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the navbar and its responsiveness #177

Merged
merged 3 commits into from
Oct 5, 2024
Merged

Conversation

dhruvjain23
Copy link
Contributor

As this issue assigned to me for improving the Navbar. I done with my task.

I take care all of the requirements during design and develop it.

  • I made it simple but attractive by using Gradient and this is Up to date with all current changes till current time.
  • Also added the "About" link to Navbar for navigate to about page.

Hope, It suits with your requirements.

Kindly merge this Pull Request under the hacktoberfest and hacktoberfest-accepted label and please give level3. @Luson045

Thanks Sir.
It may happens that due to compressed video , quality of color seems little bit change, hope you understand as i use gradient, in original it looks better.

Screen.Recording.2024-10-05.160207.mp4

Copy link

vercel bot commented Oct 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
med-space ⬜️ Ignored (Inspect) Visit Preview Oct 5, 2024 3:54pm

Copy link

netlify bot commented Oct 5, 2024

Deploy Preview for medi-connect-in ready!

Name Link
🔨 Latest commit 5c48df7
🔍 Latest deploy log https://app.netlify.com/sites/medi-connect-in/deploys/6701613f137f020008b9ada5
😎 Deploy Preview https://deploy-preview-177--medi-connect-in.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dhruvjain23
Copy link
Contributor Author

dhruvjain23 commented Oct 5, 2024

Sir , when I created the pull request , logo did'nt change , it seems , it changed after i done with all of my development, but sir i design it in such a way that after merge this request , you simply can change the link of logo.png in Navbar.jsx file and the new logo fits well with the navbar design. Hope you help sir. @Luson045

@Luson045
Copy link
Owner

Luson045 commented Oct 5, 2024

@dhruvjain23 okay everythings's fine but please change that hover effect, underline and transform-y it doesn't look very great, you can make it darker when hovered or just simply leave it but remvoe this underline and upward movement effect and merge the conflicts

@dhruvjain23
Copy link
Contributor Author

ok, I do that

@dhruvjain23
Copy link
Contributor Author

Final done.
Updated the hover functionality to darker when hover , also added the new logo by changing the previous one.

Kindly merge this Pull Request . @Luson045

@Luson045
Copy link
Owner

Luson045 commented Oct 5, 2024

Conflicts not yet resolved!

@Luson045
Copy link
Owner

Luson045 commented Oct 5, 2024

i had to resolve the conflicts so it's level2 now

@Luson045 Luson045 added level2 and removed level3 labels Oct 5, 2024
@Luson045 Luson045 merged commit a4f30b9 into Luson045:main Oct 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants