Fixes for v4.6.4 (#1665)

* avoid error during php artisan optimize
* add transaction on change
* fixes migration problem on pgsql

Author: ildyria

app/Actions/Diagnostics/Pipes/Checks/ForeignKeyListInfo.php

@@ -16,7 +16,7 @@ public function handle(array &$data, \Closure $next): array
 		match (DB::getDriverName()) {
 			'sqlite' => $this->sqlite($data),
 			'mysql' => $this->mysql($data),
-			'pgsql' => '',
+			'pgsql' => $this->pgsql($data),
 			default => ''
 		};
 
@@ -35,8 +35,7 @@ private function sqlite(array &$data): void
 
 	private function mysql(array &$data): void
 	{
-		$fks = DB::select('select
-	   *
+		$fks = DB::select('select *
 from information_schema.referential_constraints fks
 join information_schema.key_column_usage kcu on fks.constraint_schema = kcu.table_schema
 and fks.table_name = kcu.table_name
@@ -52,5 +51,28 @@ private function mysql(array &$data): void
 				$fk->UPDATE_RULE);
 		}
 	}
+
+	private function pgsql(array &$data): void
+	{
+		$fks = DB::select('SELECT tc.table_schema, tc.constraint_name, tc.table_name, kcu.column_name,
+ccu.table_schema AS foreign_table_schema,
+ccu.table_name AS foreign_table_name,
+ccu.column_name AS foreign_column_name
+FROM
+information_schema.table_constraints AS tc
+JOIN information_schema.key_column_usage AS kcu
+  ON tc.constraint_name = kcu.constraint_name
+  AND tc.table_schema = kcu.table_schema
+JOIN information_schema.constraint_column_usage AS ccu
+  ON ccu.constraint_name = tc.constraint_name
+  AND ccu.table_schema = tc.table_schema
+WHERE tc.constraint_type = \'FOREIGN KEY\';');
+
+		foreach ($fks as $fk) {
+			$data[] = sprintf('Foreign key: %-30s → %-20s',
+				$fk->table_name . '.' . $fk->column_name,
+				$fk->foreign_table_name . '.' . $fk->foreign_column_name);
+		}
+	}
 }
 

app/Actions/Diagnostics/Pipes/Infos/CountForeignKeyInfo.php

@@ -13,7 +13,7 @@ public function handle(array &$data, \Closure $next): array
 		match (DB::getDriverName()) {
 			'sqlite' => $this->sqlite($data),
 			'mysql' => $this->mysql($data),
-			'pgsql' => '',
+			'pgsql' => $this->pgsql($data),
 			default => ''
 		};
 
@@ -39,5 +39,24 @@ private function mysql(array &$data): void
 
 		$data[] = Diagnostics::line('Number of foreign key:', sprintf('%d found.', count($fks)));
 	}
+
+	private function pgsql(array &$data): void
+	{
+		$fks = DB::select('SELECT tc.table_schema, tc.constraint_name, tc.table_name, kcu.column_name,
+ccu.table_schema AS foreign_table_schema,
+ccu.table_name AS foreign_table_name,
+ccu.column_name AS foreign_column_name
+FROM
+information_schema.table_constraints AS tc
+JOIN information_schema.key_column_usage AS kcu
+  ON tc.constraint_name = kcu.constraint_name
+  AND tc.table_schema = kcu.table_schema
+JOIN information_schema.constraint_column_usage AS ccu
+  ON ccu.constraint_name = tc.constraint_name
+  AND ccu.table_schema = tc.table_schema
+WHERE tc.constraint_type = \'FOREIGN KEY\';');
+
+		$data[] = Diagnostics::line('Number of foreign key:', sprintf('%d found.', count($fks)));
+	}
 }
 

database/migrations/2022_12_10_183251_increment_user_i_ds.php

@@ -14,6 +14,16 @@
 	public function up(): void
 	{
 		Schema::disableForeignKeyConstraints();
+		DB::beginTransaction();
+
+		// In the case of pgsql we mark the following foreign keys to be defered after the commit transaction
+		// rather than after every requests
+		if (DB::getDriverName() === 'pgsql') {
+			$this->defer('base_albums', 'base_albums_owner_id_foreign');
+			$this->defer('user_base_album', 'user_base_album_user_id_foreign');
+			$this->defer('photos', 'photos_owner_id_foreign');
+		}
+
 		/** @var App\Models\User|null $admin */
 		$admin = DB::table('users')->find(0);
 		if ($admin !== null && ($admin->username === '' || $admin->password === '')) {
@@ -22,6 +32,7 @@ public function up(): void
 			// MigrateAdminUser migration and the user has never logged in.
 			DB::table('users')->where('id', '=', 0)->delete();
 		}
+
 		/** @var App\Models\User $user */
 		foreach (DB::table('users')->orderByDesc('id')->get() as $user) {
 			$oldID = $user->id;
@@ -34,13 +45,15 @@ public function up(): void
 			DB::table('webauthn_credentials')->where('authenticatable_id', '=', $oldID)->update(['authenticatable_id' => $newID]);
 			DB::table('users')->delete($oldID);
 		}
-		if (Schema::connection(null)->getConnection()->getDriverName() === 'pgsql' && DB::table('users')->count() > 0) {
+
+		if (DB::getDriverName() === 'pgsql' && DB::table('users')->count() > 0) {
 			// when using PostgreSQL, the new IDs are not updated after incrementing. Thus, we need to reset the index to the greatest ID + 1
 			// the sequence is called `users_id_seq1`
 			/** @var App\Models\User $lastUser */
 			$lastUser = DB::table('users')->orderByDesc('id')->first();
 			DB::statement('ALTER SEQUENCE users_id_seq1 RESTART WITH ' . strval($lastUser->id + 1));
 		}
+		DB::commit();
 		Schema::enableForeignKeyConstraints();
 	}
 
@@ -52,6 +65,16 @@ public function up(): void
 	public function down(): void
 	{
 		Schema::disableForeignKeyConstraints();
+		DB::beginTransaction();
+
+		// In the case of pgsql we mark the following foreign keys to be defered after the commit transaction
+		// rather than after every requests
+		if (DB::getDriverName() === 'pgsql') {
+			$this->defer('base_albums', 'base_albums_owner_id_foreign');
+			$this->defer('user_base_album', 'user_base_album_user_id_foreign');
+			$this->defer('photos', 'photos_owner_id_foreign');
+		}
+
 		/** @var App\Models\User $user */
 		foreach (User::query()->orderBy('id')->get() as $user) {
 			$oldID = $user->id;
@@ -66,6 +89,15 @@ public function down(): void
 			DB::table('webauthn_credentials')->where('authenticatable_id', '=', $oldID)->update(['authenticatable_id' => $newID]);
 			DB::table('users')->delete($oldID);
 		}
+		DB::commit();
 		Schema::enableForeignKeyConstraints();
 	}
+
+	/**
+	 * Defer a foreign key evalation to the end of a transaction in pgsql.
+	 */
+	private function defer(string $tableName, string $fkName): void
+	{
+		DB::select('ALTER TABLE ' . $tableName . ' ALTER CONSTRAINT ' . $fkName . ' DEFERRABLE INITIALLY DEFERRED;');
+	}
 };

routes/web-install.php

@@ -35,5 +35,4 @@
 	->name('install-admin');
 Route::get('install/admin', [SetUpAdminController::class, 'init'])
 	->withoutMiddleware(['installation:incomplete'])
-	->middleware(['admin_user:unset', 'installation:complete'])
-	->name('install-admin');
+	->middleware(['admin_user:unset', 'installation:complete']);