refactor(model): split DTO types by domain

Author: LyleMi

frontend/src/api/demo/audit.ts

@@ -3,45 +3,47 @@ import { sessions, toolCalls } from './sessions'
 import { matchesAgent, matchesDateRange } from './utils'
 
 const auditFindings: AuditFinding[] = [
-  makeFinding(501, 101, 1001, 'command', 'medium', 'shell.powershell.concatenated-delete', 'Review destructive shell composition', 'Remove command was composed with string interpolation.', 'Remove-Item $target -Recurse', 'powershell'),
-  makeFinding(502, 102, 1005, 'egress', 'low', 'network.fetch.failed', 'Network access attempted', 'A documentation lookup was attempted while offline demo policy was active.', 'Invoke-WebRequest https://example.invalid/pricing', 'powershell'),
-  makeFinding(503, 104, 1008, 'privacy', 'high', 'privacy.telemetry.enabled', 'Telemetry setting needs review', 'Demo privacy config shows a setting that is not hardened.', 'telemetry.enabled = true', 'json'),
-  makeFinding(504, 105, 1009, 'file', 'medium', 'file.output.screenshot', 'Generated artifact requires retention decision', 'A browser screenshot artifact was created during validation.', 'browser_screenshot tools chart', 'browser')
+  makeFinding({ id: 501, sessionId: 101, toolCallId: 1001, category: 'command', severity: 'medium', ruleId: 'shell.powershell.concatenated-delete', title: 'Review destructive shell composition', description: 'Remove command was composed with string interpolation.', command: 'Remove-Item $target -Recurse', shellFamily: 'powershell' }),
+  makeFinding({ id: 502, sessionId: 102, toolCallId: 1005, category: 'egress', severity: 'low', ruleId: 'network.fetch.failed', title: 'Network access attempted', description: 'A documentation lookup was attempted while offline demo policy was active.', command: 'Invoke-WebRequest https://example.invalid/pricing', shellFamily: 'powershell' }),
+  makeFinding({ id: 503, sessionId: 104, toolCallId: 1008, category: 'privacy', severity: 'high', ruleId: 'privacy.telemetry.enabled', title: 'Telemetry setting needs review', description: 'Demo privacy config shows a setting that is not hardened.', command: 'telemetry.enabled = true', shellFamily: 'json' }),
+  makeFinding({ id: 504, sessionId: 105, toolCallId: 1009, category: 'file', severity: 'medium', ruleId: 'file.output.screenshot', title: 'Generated artifact requires retention decision', description: 'A browser screenshot artifact was created during validation.', command: 'browser_screenshot tools chart', shellFamily: 'browser' })
 ]
 
-function makeFinding(
-  id: number,
-  sessionId: number,
-  toolCallId: number,
-  category: string,
-  severity: string,
-  ruleId: string,
-  title: string,
-  description: string,
-  command: string,
+type DemoFindingSpec = {
+  id: number
+  sessionId: number
+  toolCallId: number
+  category: string
+  severity: string
+  ruleId: string
+  title: string
+  description: string
+  command: string
   shellFamily: string
-): AuditFinding {
-  const session = sessions.find((item) => item.id === sessionId)
-  if (!session) throw new Error(`Missing demo session ${sessionId}`)
-  const tool = toolCalls.find((item) => item.id === toolCallId)
+}
+
+function makeFinding(spec: DemoFindingSpec): AuditFinding {
+  const session = sessions.find((item) => item.id === spec.sessionId)
+  if (!session) throw new Error(`Missing demo session ${spec.sessionId}`)
+  const tool = toolCalls.find((item) => item.id === spec.toolCallId)
   return {
-    id,
-    sessionId,
-    toolCallId,
+    id: spec.id,
+    sessionId: spec.sessionId,
+    toolCallId: spec.toolCallId,
     sourceFileId: session.sourceId || 0,
-    rawEventId: tool?.rawEventId || id + 5000,
+    rawEventId: tool?.rawEventId || spec.id + 5000,
     sourceLine: tool?.rawEventLine || 1,
     timestamp: tool?.endedAt || session.endedAt,
     source: 'demo audit',
     eventType: tool?.rawEndEventType || 'tool_result',
-    category,
-    severity,
-    ruleId,
-    title,
-    description,
-    evidence: tool?.rawEndEventSummary || description,
-    command,
-    shellFamily,
+    category: spec.category,
+    severity: spec.severity,
+    ruleId: spec.ruleId,
+    title: spec.title,
+    description: spec.description,
+    evidence: tool?.rawEndEventSummary || spec.description,
+    command: spec.command,
+    shellFamily: spec.shellFamily,
     platform: 'windows',
     decision: 'review',
     createdAt: session.endedAt,

frontend/src/api/demo/privacy.ts

@@ -11,37 +11,40 @@ const profiles: PrivacyConfigProfile[] = [
   { id: 'strict', title: 'Strict', description: 'Disable telemetry, network helpers, memory, and extended local retention.' }
 ]
 
-function privacySetting(
-  id: string,
-  group: string,
-  title: string,
-  key: string,
-  desiredValue: unknown,
-  strictValue: unknown,
-  currentValue: unknown,
-  configured: boolean,
-  status: string,
-  valueType: PrivacyConfigSetting['valueType'] = 'bool'
-): PrivacyConfigSetting {
+type PrivacySettingSpec = {
+  id: string
+  group: string
+  title: string
+  key: string
+  desiredValue: unknown
+  strictValue: unknown
+  currentValue: unknown
+  configured: boolean
+  status: string
+  valueType?: PrivacyConfigSetting['valueType']
+}
+
+function privacySetting(spec: PrivacySettingSpec): PrivacyConfigSetting {
+  const valueType = spec.valueType || 'bool'
   return {
-    id,
-    group,
-    title,
-    description: `Demo status for ${title.toLowerCase()}.`,
-    key,
-    desiredValue,
-    strictValue,
-    currentValue,
+    id: spec.id,
+    group: spec.group,
+    title: spec.title,
+    description: `Demo status for ${spec.title.toLowerCase()}.`,
+    key: spec.key,
+    desiredValue: spec.desiredValue,
+    strictValue: spec.strictValue,
+    currentValue: spec.currentValue,
     valueType,
-    configured,
+    configured: spec.configured,
     supportsUnset: true,
-    status,
-    impact: `Controls ${title.toLowerCase()} behavior for the selected agent.`,
+    status: spec.status,
+    impact: `Controls ${spec.title.toLowerCase()} behavior for the selected agent.`,
     canApply: true,
     profileValues: [
       { profile: 'default', op: 'unset' },
-      { profile: 'recommended', op: 'set', value: desiredValue },
-      { profile: 'strict', op: 'set', value: strictValue }
+      { profile: 'recommended', op: 'set', value: spec.desiredValue },
+      { profile: 'strict', op: 'set', value: spec.strictValue }
     ]
   }
 }
@@ -54,11 +57,11 @@ export function privacyStatus(target: PrivacyTarget): PrivacyConfigStatus {
     codebuddy: 'CodeBuddy'
   }
   const settings = [
-    privacySetting('analytics.enabled', 'Telemetry', 'Analytics', 'analytics.enabled', false, false, false, true, 'hardened'),
-    privacySetting('telemetry.enabled', 'Telemetry', 'Telemetry export', 'telemetry.enabled', false, false, target === 'claude', target !== 'claude', target === 'claude' ? 'attention' : 'hardened'),
-    privacySetting('web_search', 'Network', 'Web search', 'web_search', false, false, false, target === 'codex', target === 'codex' ? 'hardened' : 'implicit'),
-    privacySetting('history.persistence', 'Local history', 'Conversation history', 'history.persistence', false, false, true, false, 'implicit'),
-    privacySetting('retention.days', 'Local retention', 'Retention days', 'retention.days', 14, 7, 14, true, 'hardened', 'number')
+    privacySetting({ id: 'analytics.enabled', group: 'Telemetry', title: 'Analytics', key: 'analytics.enabled', desiredValue: false, strictValue: false, currentValue: false, configured: true, status: 'hardened' }),
+    privacySetting({ id: 'telemetry.enabled', group: 'Telemetry', title: 'Telemetry export', key: 'telemetry.enabled', desiredValue: false, strictValue: false, currentValue: target === 'claude', configured: target !== 'claude', status: target === 'claude' ? 'attention' : 'hardened' }),
+    privacySetting({ id: 'web_search', group: 'Network', title: 'Web search', key: 'web_search', desiredValue: false, strictValue: false, currentValue: false, configured: target === 'codex', status: target === 'codex' ? 'hardened' : 'implicit' }),
+    privacySetting({ id: 'history.persistence', group: 'Local history', title: 'Conversation history', key: 'history.persistence', desiredValue: false, strictValue: false, currentValue: true, configured: false, status: 'implicit' }),
+    privacySetting({ id: 'retention.days', group: 'Local retention', title: 'Retention days', key: 'retention.days', desiredValue: 14, strictValue: 7, currentValue: 14, configured: true, status: 'hardened', valueType: 'number' })
   ]
   const hardened = settings.filter((setting) => setting.status === 'hardened').length
   const attention = settings.filter((setting) => setting.status === 'attention').length