Skip to content

Commit 14ca30b

Browse files
fix: adapt bottom spacing in module pages for floating vs traditional nav
1 parent 6e1e0a5 commit 14ca30b

3 files changed

Lines changed: 45 additions & 33 deletions

File tree

app/src/main/java/me/bmax/apatch/ui/screen/APM.kt

Lines changed: 22 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -740,13 +740,16 @@ private fun ModuleList(
740740
key = { module -> module.id },
741741
verticalSpacing = 16.dp,
742742
horizontalSpacing = 16.dp,
743-
contentPadding = remember {
744-
PaddingValues(
745-
start = 16.dp,
746-
top = 16.dp,
747-
end = 16.dp,
748-
bottom = 16.dp + 16.dp + 56.dp
749-
)
743+
contentPadding = run {
744+
val isFloating = LocalIsFloatingNavMode.current
745+
remember(isFloating) {
746+
PaddingValues(
747+
start = 16.dp,
748+
top = 16.dp,
749+
end = 16.dp,
750+
bottom = if (isFloating) 16.dp + 16.dp + 56.dp else 16.dp
751+
)
752+
}
750753
},
751754
beforeItems = {
752755
if (showMountWarning) {
@@ -896,13 +899,16 @@ private fun ModuleList(
896899
LazyColumn(
897900
modifier = Modifier.fillMaxSize(),
898901
state = state,
899-
contentPadding = remember {
900-
PaddingValues(
901-
start = 0.dp,
902-
top = 16.dp,
903-
end = 0.dp,
904-
bottom = 16.dp + 16.dp + 56.dp /* Scaffold Fab Spacing + Fab container height */
905-
)
902+
contentPadding = run {
903+
val isFloating = LocalIsFloatingNavMode.current
904+
remember(isFloating) {
905+
PaddingValues(
906+
start = 0.dp,
907+
top = 16.dp,
908+
end = 0.dp,
909+
bottom = if (isFloating) 16.dp + 16.dp + 56.dp else 16.dp
910+
)
911+
}
906912
},
907913
) {
908914
// Warning Banner
@@ -1059,7 +1065,7 @@ private fun ModuleList(
10591065
onClickModule(clickedModule.id, clickedModule.name, clickedModule.hasWebUi)
10601066
})
10611067
}
1062-
item { Spacer(Modifier.height(88.dp)) }
1068+
item { Spacer(Modifier.height(if (LocalIsFloatingNavMode.current) 88.dp else 8.dp)) }
10631069
} else {
10641070
item { Spacer(Modifier.height(8.dp)) }
10651071
itemsIndexed(modules, key = { _, module -> module.id }) { _, module ->
@@ -1129,7 +1135,7 @@ private fun ModuleList(
11291135

11301136
}
11311137
}
1132-
item { Spacer(Modifier.height(88.dp)) }
1138+
item { Spacer(Modifier.height(if (LocalIsFloatingNavMode.current) 88.dp else 8.dp)) }
11331139
}
11341140
}
11351141
}

app/src/main/java/me/bmax/apatch/ui/screen/KPM.kt

Lines changed: 22 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -719,13 +719,16 @@ private fun KPModuleList(
719719
key = { module -> module.name },
720720
verticalSpacing = 16.dp,
721721
horizontalSpacing = 16.dp,
722-
contentPadding = remember {
723-
PaddingValues(
724-
start = 16.dp,
725-
top = 16.dp,
726-
end = 16.dp,
727-
bottom = 16.dp + 16.dp + 56.dp
728-
)
722+
contentPadding = run {
723+
val isFloating = LocalIsFloatingNavMode.current
724+
remember(isFloating) {
725+
PaddingValues(
726+
start = 16.dp,
727+
top = 16.dp,
728+
end = 16.dp,
729+
bottom = if (isFloating) 16.dp + 16.dp + 56.dp else 16.dp
730+
)
731+
}
729732
},
730733
beforeItems = {
731734
if (moduleList.isEmpty()) {
@@ -770,13 +773,16 @@ private fun KPModuleList(
770773
LazyColumn(
771774
modifier = Modifier.fillMaxSize(),
772775
state = state,
773-
contentPadding = remember {
774-
PaddingValues(
775-
start = 0.dp,
776-
top = 16.dp,
777-
end = 0.dp,
778-
bottom = 16.dp + 16.dp + 56.dp /* Scaffold Fab Spacing + Fab container height */
779-
)
776+
contentPadding = run {
777+
val isFloating = LocalIsFloatingNavMode.current
778+
remember(isFloating) {
779+
PaddingValues(
780+
start = 0.dp,
781+
top = 16.dp,
782+
end = 0.dp,
783+
bottom = if (isFloating) 16.dp + 16.dp + 56.dp else 16.dp
784+
)
785+
}
780786
},
781787
) {
782788
when {
@@ -826,7 +832,7 @@ private fun KPModuleList(
826832
}
827833
)
828834
}
829-
item { Spacer(Modifier.height(88.dp)) }
835+
item { Spacer(Modifier.height(if (LocalIsFloatingNavMode.current) 88.dp else 8.dp)) }
830836
} else {
831837
item { Spacer(Modifier.height(8.dp)) }
832838
itemsIndexed(moduleList, key = { _, module -> module.name }) { _, module ->
@@ -855,7 +861,7 @@ private fun KPModuleList(
855861
)
856862
}
857863
}
858-
item { Spacer(Modifier.height(88.dp)) }
864+
item { Spacer(Modifier.height(if (LocalIsFloatingNavMode.current) 88.dp else 8.dp)) }
859865
}
860866
}
861867
}

app/src/main/java/me/bmax/apatch/ui/screen/SuperUser.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -360,7 +360,7 @@ private fun SuperUserScreenModern(navigator: DestinationsNavigator, useLegacySuP
360360
}
361361
)
362362
}
363-
item { Spacer(Modifier.height(88.dp)) }
363+
item { Spacer(Modifier.height(if (LocalIsFloatingNavMode.current) 88.dp else 8.dp)) }
364364
}
365365
}
366366
}

0 commit comments

Comments
 (0)