Merge pull request #682 from guillaume-vignal/fix_plot_continuous_distribution

Fix incorrect filtering in `plot_continuous_distribution

Author: guillaume-vignal

pyproject.toml

@@ -43,7 +43,7 @@ dependencies = [
     "matplotlib>=3.8.4",
     "nbformat>5.8.0",
     "numba>=0.60.0",
-    "numpy>=2.0.0",
+    "numpy>=2.0.0,<2.4.0",
     "pandas>=2.2.2,<3.0.0",
     "plotly>=5.0.0,<6.0.0",
     "scikit-learn>=1.4.2,<1.6.0",

shapash/plots/plot_univariate.py

@@ -177,11 +177,11 @@ def plot_continuous_distribution(
         if len(filtered_data_tmp) > 0.95 * len(filtered_data):
             filtered_data = filtered_data_tmp
         else:
-            filtered_data_tmp = filtered_data[(filtered_data < upper_quantile)]
+            filtered_data_tmp = filtered_data[(filtered_data[col] < upper_quantile)]
             if len(filtered_data_tmp) > 0.95 * len(filtered_data):
                 filtered_data = filtered_data_tmp
             else:
-                filtered_data_tmp = filtered_data[(filtered_data > lower_quantile)]
+                filtered_data_tmp = filtered_data[(filtered_data[col] > lower_quantile)]
                 if len(filtered_data_tmp) > 0.95 * len(filtered_data):
                     filtered_data = filtered_data_tmp