Merge pull request #98 from MAIF/feature/update_python_v38_v39

Support python 3.8

Author: MaxGdr

.github/workflows/main.yml

@@ -8,7 +8,7 @@ jobs:
     strategy:
       max-parallel: 1
       matrix:
-        python-version: [3.6, 3.7]
+        python-version: [3.6, 3.7, 3.8]
     steps:
     - uses: actions/checkout@v2
     - name: Set up Python ${{ matrix.python-version }}
@@ -32,8 +32,8 @@ jobs:
     - name: Build python package
       run: |
         python setup.py sdist bdist_wheel
-    - name: Trigger next workflow
-      if: success() && startsWith(github.ref, 'refs/tags') && matrix.python-version == 3.7
+    - name: Deploy to PyPI
+      if: success() && startsWith(github.ref, 'refs/tags') && matrix.python-version == 3.8
       uses: pypa/gh-action-pypi-publish@master
       with:
         user: __token__

requirements.dev.txt

@@ -25,5 +25,5 @@ pytest==5.2.3
 pytest-cov==2.8.1
 scikit-learn==0.23.2
 xgboost==1.0.0
-nbformat==5.0.8
+nbformat>4.2.0
 numba==0.51.2

setup.cfg

@@ -1,5 +1,5 @@
 [bumpversion]
-current_version = 1.0.1
+current_version = 1.1.0
 commit = True
 tag = True
 

setup.py

@@ -20,7 +20,7 @@
         'dash-html-components==1.1.1',
         'dash-renderer==1.8.3',
         'dash-table==4.11.0',
-        'nbformat==5.0.8',
+        'nbformat>4.2.0',
         'numba==0.51.2',
     ]
 
@@ -30,8 +30,8 @@
 
 setup(
     name="shapash", # Replace with your own username
-    version="1.0.1",
-    python_requires='>3.5, < 3.8',
+    version="1.1.0",
+    python_requires='>3.5, < 3.9',
     url='https://github.com/MAIF/shapash',
     author="Yann Golhen, Sebastien Bidault, Yann Lagre, Maxime Gendre",
     author_email="[email protected]",
@@ -42,6 +42,7 @@
         "Programming Language :: Python :: 3",
         'Programming Language :: Python :: 3.6',
         'Programming Language :: Python :: 3.7',
+        'Programming Language :: Python :: 3.8',
         "License :: OSI Approved :: Apache Software License",
         "Operating System :: OS Independent",
     ],

shapash/__init__.py

@@ -3,4 +3,4 @@
 
 __author__ = """Yann Golhen, Yann Lagré, Sebastien Bidault, Maxime Gendre, Thomas Bouche, Johann Martin"""
 __email__ = '[email protected], [email protected], [email protected], [email protected]'
-__version__ = '1.0.1'
+__version__ = '1.1.0'

tests/data/predictor_to_load_38.pkl

@@ -28,6 +28,8 @@ def test_load_smartpredictor_1(self):
             pkl_file = path.join(current, 'data/predictor_to_load_37.pkl')
         elif str(sys.version)[0:3] == '3.6':
             pkl_file = path.join(current, 'data/predictor_to_load_36.pkl')
+        elif str(sys.version)[0:3] == '3.8':
+            pkl_file = path.join(current, 'data/predictor_to_load_38.pkl')
 
         predictor2 = load_smartpredictor(pkl_file)
 

tests/unit_tests/utils/test_load_smartpredictor.py

@@ -78,7 +78,7 @@ def test_check_explainer_1(self):
         Unit test check explainer 1
         """
         explainer = None
-        self.assertRaises(ValueError, check_explainer(explainer))
+        assert check_explainer(explainer) == None
 
     def test_check_explainer_2(self):
         """