Skip to content

[FR] Only trigger topic search when "/" is pressed #304

Description

@TeCHiScy

Describe the bug
Currently, when Topic pane is focused, any input except arrow keys, enter key is interpreted as search keywords. This behavior invalidates some nice Vim key bindings like "hjkl" for cursor moving, "gG" for first and last item, etc.

I'd suggest to, either:

  • Only trigger topic search when currently focused pane is Topic, and / is pressed, the bottom search bar preserve the behavior of searching records.
  • Adjust the search bar behavior, making it aware of which pane is currently focused, and performing filter/search on corresponding pane (Topic or Records)
  • Have seperate search bar for Topic/Records pane, and only trigger search when some pane is focuesed and / is pressed

I'd also suggest to not changing the sort of selected topic. This is because when a topic is moved top after selected, it's hard to quickly unselect it (especially when a mis-select happens). In this case, one can either unselected all selected topics with Ctrl-U or move cursor to the top, then unselect the mis-selected topic, which may be tedious. Keeping the selected topic in the original place helps relieve the issue.

I'd like to also propose that: When in search mode (/ is pressed, and search bar is activated), ESC to behave as an exit way of search mode. In other words, instead of prompt Press [CTRL + C] to exit, it just deactivate search bar and returns focus back to the previous activated pane. This makes yozefu more Vim style, and boosts efficiency.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions