Skip to content

Header Names Are Not Case-Sensitive! #590

Open
@dnwiebe

Description

@dnwiebe

The HTTP standard states that HTTP header names are not case-sensitive. Therefore, Host, host, and HOST all mean the same thing.

However, in HttpProtocolPack, in the find_header_host() function, only Host is accepted: any other casing will be ignored. This is potentially a big problem, because I know of clients that only ever use all-lowercase header names.

Drive case-insensitivity into find_header_host(), and find any other places in the code where we're seeking header names in a case-sensitive manner: change them too.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    • Status

      🔖 Ready

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions