Skip to content

[Question] Possible redundant Euler step in sampling loop ddpm/neuralsolver.py #1

@scpark20

Description

@scpark20

First of all, I really enjoyed and found the paper very interesting — thanks for sharing this work!
While reading the code, I noticed what seems to be an extra Euler-like update in the sampling loop:

pred_trajectory.append(x0)
delta_lamda = lamda_next - lamda
x = (sigma_next/sigma) * x + sigma_next * (delta_lamda) * x0

This runs after the main coefficient-weighted update, so it might be redundant and could overwrite the intended solver step.

Is this behavior correct, or should the extra update be removed?
Thanks in advance! :)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions