nojump.py raises a valueerror when applied not at first frame (#5201)

* nojump.py raises a valueerror when applied not at 0

* Updated changelog

* edited the valueError

* updated test_nojump_fails_midtrajectory

* updated test to a single function

Author: spyke7

package/CHANGELOG

@@ -20,6 +20,8 @@ The rules for this file:
  * 2.11.0
 
 Fixes
+ * NoJump shows a more informative message and fails  when applied
+   outside of the first frame (Issue #4915, PR #5201)
  * DSSP now explicitly checks for a minimum of 6 residues and raises a clear
    error message, unlike the previous behavior where it would fail with an
    incomprehensible broadcasting error at execution time (Issue #5046, PR #5163)

package/MDAnalysis/transformations/nojump.py

@@ -118,6 +118,13 @@ def _transform(self, ts):
         except np.linalg.LinAlgError:
             msg = f"Periodic box dimensions are not invertible at step {ts.frame}"
             raise NoDataError(msg)
+
+        if self.prev is None and ts.frame != 0:
+            raise ValueError(
+                "NoJump transformation must be applied starting from frame 0. "
+                f"Currently at frame {ts.frame}. Please reset trajectory to frame 0 before adding this transformation."
+            )
+
         if ts.frame == 0:
             # We don't need to apply the transformation here. However, we need to
             # ensure we have the 0th frame coordinates in reduced form. We also need to

testsuite/MDAnalysisTests/transformations/test_nojump.py

@@ -379,3 +379,18 @@ def test_notinvertible(nojump_universe):
         ]
         u.trajectory.add_transformations(*workflow)
         transformed_coordinates = u.trajectory.timeseries()[0]
+
+
+@pytest.mark.parametrize("frame_index", [-1, 5])
+def test_nojump_fails_when_not_at_frame_0(frame_index):
+    """
+    Test that NoJump raises a clear error when applied to a trajectory
+    that is not at frame 0.
+    """
+    u = mda.Universe(data.PSF_TRICLINIC, data.DCD_TRICLINIC)
+    u.trajectory[frame_index]
+
+    with pytest.raises(
+        ValueError, match="must be applied starting from frame 0"
+    ):
+        u.trajectory.add_transformations(NoJump())