Skip to content

Commit b7c3bb6

Browse files
committed
Address review feedback for cylayer selection test
1 parent f61e50e commit b7c3bb6

1 file changed

Lines changed: 4 additions & 13 deletions

File tree

testsuite/MDAnalysisTests/core/test_atomselections.py

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
from MDAnalysis import SelectionError, SelectionWarning
3434
from MDAnalysis.core.selection import Parser
3535
from MDAnalysis.lib.distances import distance_array
36-
from MDAnalysis.lib.pkdtree import PeriodicKDTree
3736
from MDAnalysis.tests.datafiles import (
3837
DCD,
3938
GRO,
@@ -57,7 +56,7 @@
5756
waterPSF,
5857
)
5958
from numpy.lib import NumpyVersion
60-
from numpy.testing import assert_array_equal, assert_equal
59+
from numpy.testing import assert_equal
6160

6261
from MDAnalysisTests import make_Universe
6362

@@ -1737,19 +1736,11 @@ def test_formal_charge_selection(sel, size, name):
17371736
assert len(ag) == size
17381737
assert ag.atoms[0].name == name
17391738

1740-
1741-
@pytest.fixture(scope="module")
1742-
def universe():
1739+
def test_cylayer_selection_parses_correctly():
17431740
u = mda.Universe(PSF, DCD)
17441741
u.dimensions = np.array([100.0, 100.0, 100.0, 90.0, 90.0, 90.0])
1745-
return u
1746-
1747-
1748-
def test_cylayer_selection_parses_correctly(universe):
1749-
universe.dimensions = np.array([100, 100, 100, 90, 90, 90])
17501742

1751-
sel = universe.select_atoms("cylayer 5 10 15 -15 name CA")
1743+
sel = u.select_atoms("cylayer 5 10 15 -15 name CA")
17521744

1753-
# Basic sanity checks
17541745
assert len(sel) > 0
1755-
assert sel.n_atoms <= universe.atoms.n_atoms
1746+
assert sel.n_atoms <= u.atoms.n_atoms

0 commit comments

Comments
 (0)