Save/Resume changes to accommodate routing only simulations

[mee067]

This was initially raised by @MazdaKompanizare when he was trying to use initial conditions from a normal simulation (LSS + Routing) for a routing only simulation (runroute nolss) or resuming a routing-only simulation from another routing-only simulation. Reading initial conditions for the LSS made issues in such a case and the system wanted to save them at the end (or at intervals using autosave). To overcome these issue and to economize file sizes (in case LSS is not running), I made those changes to r1860_ME_ZT to condition reading and writing on which components are active. I saw these were not carried over in 1.5.1.

In resumerun_save.f90

        if (index(resume_options%save%bin, '+STASONLY') == 0 .and. index(resume_options%save%bin, '+CLASSPROG') == 0) then
!<< ME Nov 3, 2023 - Added conditions based on whether LSS and/or Routing are active or not
            if (svs_mesh%PROCESS_ACTIVE .or. RUNCLASS36_flgs%PROCESS_ACTIVE) then
                call save_init_prog_variables_class(fls, shd)
                call runsvs_mesh_save_states_seq(fls, shd)
                call bflm_resume_save(fls, shd)
            end if
            if (WF_RTE_flgs%PROCESS_ACTIVE .or. rteflg%PROCESS_ACTIVE) then
                call WF_ROUTE_resume_save(fls, shd)
                call run_rte_resume_save(fls, shd)
            end if
            call run_save_basin_output_resume_save(fls, shd)
            call stats_state_save(fls)
!>>>>>zone-based storage
            if (RESERVOIRFLAG == 2) then
                iun = 100
                if (resume_options%save%freq /= FREQ_NUL .and. resume_options%save%freq /= FREQ_NOW) then
                    open(iun, file = 'zone_storage_states.' // trim(adjustl(line)) // '.txt', action = 'write', status = 'replace')
                else
                    open(iun, file = 'zone_storage_states.txt', action = 'write', status = 'replace')
                end if
                write(iun, *) (resrvs%rsvr(i)%stoSIM(1), i = 1, resrvs%nreserv), '# Intstor1(1:NRESV)'
                write(iun, *) (resrvs%rsvr(i)%flowSIM(1), i = 1, resrvs%nreserv), '# flowO1(1:NRESV)'
                close(iun)
            end if
!<<<<<zone-based storage
        else if (index(resume_options%save%bin, '+CLASSPROG') == 0) then
!<< ME Nov 3, 2023 - Added conditions based on whether LSS and/or Routing are active or not		
            if (svs_mesh%PROCESS_ACTIVE .or. RUNCLASS36_flgs%PROCESS_ACTIVE) then
                call save_init_prog_variables_class(fls, shd)
                call runsvs_mesh_save_states_seq(fls, shd)
                call bflm_resume_save(fls, shd)
            end if
            if (WF_RTE_flgs%PROCESS_ACTIVE .or. rteflg%PROCESS_ACTIVE) then
                call WF_ROUTE_resume_save(fls, shd)
                call run_rte_resume_save(fls, shd)
            end if

and in **resumerun_read.f90**

            if (index(resume_options%resume%bin, '+STASONLY') == 0 .and. index(resume_options%resume%bin, '+CLASSPROG') == 0) then
!<< ME Nov 3, 2023 - Added conditions based on whether LSS and/or Routing are active or not
                if (svs_mesh%PROCESS_ACTIVE .or. RUNCLASS36_flgs%PROCESS_ACTIVE) then
                    call read_init_prog_variables_class(fls, shd)				
                    call runsvs_mesh_resume_states_seq(fls, shd, resume_ts = .true.)
                    call bflm_resume_read(fls, shd)
                end if
                if (WF_RTE_flgs%PROCESS_ACTIVE .or. rteflg%PROCESS_ACTIVE) then
                    call WF_ROUTE_resume_read(fls, shd)
                    call run_rte_resume_read(fls, shd)
                end if
                call run_save_basin_output_resume_read(fls, shd)
                call stats_state_resume(fls)
!>>>>>zone-based storage
                if (RESERVOIRFLAG == 2) then
                    iun = 100
                    if (resume_options%resume%state == FLAG_AUTO) then
                        open(iun, file = 'zone_storage_states.' // trim(adjustl(line)) // '.txt', action = 'read', status = 'old')
                    else
                        open(iun, file = 'zone_storage_states.txt', action = 'read', status = 'old')
                    end if
                    read(iun, *) (resrvs%rsvr(i)%stoSIM(1), i = 1, resrvs%nreserv)
                    read(iun, *) (resrvs%rsvr(i)%flowSIM(1), i = 1, resrvs%nreserv)
                    close(iun)
                end if
!<<<<<zone-based storage
            else if (index(resume_options%resume%bin, '+CLASSPROG') == 0) then
!<< ME Nov 3, 2023 - Added conditions based on whether LSS and/or Routing are active or not
                if (svs_mesh%PROCESS_ACTIVE .or. RUNCLASS36_flgs%PROCESS_ACTIVE) then
                    call read_init_prog_variables_class(fls, shd)
                    call runsvs_mesh_resume_states_seq(fls, shd, resume_ts = .false.)
                    call bflm_resume_read(fls, shd)
                end if
                if (WF_RTE_flgs%PROCESS_ACTIVE .or. rteflg%PROCESS_ACTIVE) then
                    call WF_ROUTE_resume_read_nots(fls, shd)
                    call run_rte_resume_read_nots(fls, shd)
                end if

[dprincz]

I think I found this was redundant with checks already inside the modules themselves which exit if they're not active, so it was not carried over from the r1860_ME_ZT code.

Can you confirm it doesn't already behave as expected even though these changes weren't explicitly carried over?

[dprincz]

I think this might be confusing an issue when using the NetCDF resume files. In such case, the proposed changes in resumerun_save or resumerun_read wouldn't correct that and are indeed redundant. The issue pertaining to inactive process modules was resolved by changes to read_initial_values_nc and save_initial_values_nc separately, which did carry over from the r1860_ME code (ab8af9a). Because the NetCDF single file contains all variables across process modules, checks against the active process modules were added to those codes directly. I suspect this is likely the issue you're remembering, in which case I don't think the proposed resumerun_save and resumerun_read are necessary (i.e., no bug exists in this context). I appreciate if you could re-review the issue, and please close it if you come the same finding.

[mee067]

I am not sure but I think Mazda was still using seq format for the resume files - I have to dig a bit to make sure it was the case. I did not check to see whether the current changes you mentioned resolved the issue in 1.5.1.