fix(profile): strip the @ from Bluesky profile links

Bluesky handles are stored @-prefixed (the form prepends @ on save),
and the profile partial interpolated the stored value straight into
the href, producing bsky.app/profile/@handle — which does not resolve.
The href now cuts the @ so the link lands on bsky.app/profile/handle
for both @-prefixed and legacy bare stored values, and the visible
label consistently displays @handle either way. Storage and the form's
existing clean behaviour are unchanged.

(cherry picked from commit 2113ff6)

Author: MartinPaulEve

knowledge_commons_profiles/newprofile/tests/test_social_media_at_prefix.py

@@ -219,3 +219,34 @@ def test_bluesky_without_at_unchanged_in_initial(self):
         )
         form = ProfileForm(instance=profile)
         self.assertEqual(form.initial["bluesky"], "user.bsky.social")
+
+
+class BlueskyLinkRenderingTests(TestCase):
+    """The Bluesky profile link must never contain the stored @.
+
+    bsky.app/profile/@handle does not resolve; the href needs the bare
+    handle whether the stored value is @-prefixed (the canonical saved
+    form) or bare (legacy rows saved before the @ was prepended).
+    """
+
+    def _render(self, bluesky_value):
+        from django.template.loader import render_to_string
+
+        return render_to_string(
+            "newprofile/partials/profile_info.html",
+            {"profile_info": {"bluesky": bluesky_value}},
+        )
+
+    def test_bluesky_href_strips_stored_at(self):
+        html = self._render("@eve.gd")
+        self.assertIn('href="https://bsky.app/profile/eve.gd"', html)
+        self.assertNotIn("profile/@eve.gd", html)
+
+    def test_bluesky_href_with_bare_handle(self):
+        html = self._render("eve.gd")
+        self.assertIn('href="https://bsky.app/profile/eve.gd"', html)
+
+    def test_bluesky_label_always_displays_at_prefix(self):
+        for stored in ("@eve.gd", "eve.gd"):
+            html = self._render(stored)
+            self.assertIn("<span>@eve.gd</span>", html)

knowledge_commons_profiles/templates/newprofile/partials/profile_info.html

@@ -34,10 +34,11 @@
 
 <!-- Bluesky -->
 {% if profile_info.bluesky %}
-  <a href="https://bsky.app/profile/{{ profile_info.bluesky }}"
+  {# the stored handle may carry a leading @, which bsky.app profile URLs do not resolve #}
+  <a href="https://bsky.app/profile/{{ profile_info.bluesky|cut:"@" }}"
      class="social-link" id="bluesky" aria-label="Bluesky" hx-swap-oob="true">
       <img class="bluesky" src="{% static "img/bluesky.png" %}" alt="bluesky" />
-      <span>{{ profile_info.bluesky }}</span>
+      <span>@{{ profile_info.bluesky|cut:"@" }}</span>
   </a>
   {% else %}
   <a href="#" class="hide" id="bluesky" aria-label="Bluesky" aria-hidden="true" hx-swap-oob="true"></a>