Skip to content

Commit c8ffdc2

Browse files
authored
Merge pull request #5 from MFB-Technologies-Inc/feature/stop-schemes-from-polluting-dependents
- Add .swiftpm to gitignore to stop schemes from polluting packages that depend on NetworkService - Run swiftformat - Update ci.yml to use newer codecov flow - Add codecov badge to README - Remove unnecessary use of `try!`. Resolves issue #1. - Add missing assertion descriptions in tests. Resolves swiftlint warnings.
2 parents 036aaf9 + cff6b0e commit c8ffdc2

24 files changed

+58
-563
lines changed

.github/workflows/ci.yml

+5-4
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,9 @@ jobs:
4343
- name: Lint
4444
run: swiftlint .
4545
- name: Run Tests
46-
run: swift test --enable-code-coverage
46+
run: swift test --enable-code-coverage --parallel
4747
- name: Swift Coverage Report
48-
uses: maxep/[email protected]
49-
- name: Code Coverage
50-
run: bash <(curl -s https://codecov.io/bash) -X xcodellvm
48+
run: xcrun llvm-cov export -format="lcov" .build/debug/NetworkServicePackageTests.xctest/Contents/MacOS//NetworkServicePackageTests -instr-profile .build/debug/codecov/default.profdata > coverage_report.lcov
49+
- uses: codecov/codecov-action@v3
50+
with:
51+
fail_ci_if_error: true # optional (default = false)

.gitignore

+2-2
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,9 @@ playground.xcworkspace
8686
# *.xcodeproj
8787
# Xcode automatically generates this directory with a .xcworkspacedata file and xcuserdata
8888
# hence it is not needed unless you have added a package configuration file to your project
89-
# .swiftpm
89+
/.swiftpm
9090

91-
.build/
91+
/.build
9292

9393
# CocoaPods
9494
# We recommend against adding the Pods directory to your .gitignore. However

.swiftpm/xcode/package.xcworkspace/contents.xcworkspacedata

-7
This file was deleted.

.swiftpm/xcode/xcshareddata/xcschemes/NetworkService-Package.xcscheme

-205
This file was deleted.

.swiftpm/xcode/xcshareddata/xcschemes/NetworkService.xcscheme

-77
This file was deleted.

.swiftpm/xcode/xcshareddata/xcschemes/NetworkServiceAsyncBeta.xcscheme

-77
This file was deleted.

0 commit comments

Comments
 (0)