Improved code: function returns

Author: MGeurts

app/Livewire/People/Add/Child.php

@@ -122,7 +122,7 @@ public function updatedUploads(): void
             ->toArray();
     }
 
-    public function saveChild()
+    public function saveChild(): void
     {
         if ($this->isDirty()) {
             $validated = $this->childForm->validate();

app/Livewire/People/Add/Father.php

@@ -107,7 +107,7 @@ public function updatedUploads(): void
             ->toArray();
     }
 
-    public function saveFather()
+    public function saveFather(): void
     {
         if ($this->isDirty()) {
             $validated = $this->fatherForm->validate();

app/Livewire/People/Add/Mother.php

@@ -107,7 +107,7 @@ public function updatedUploads(): void
             ->toArray();
     }
 
-    public function saveMother()
+    public function saveMother(): void
     {
         if ($this->isDirty()) {
             $validated = $this->motherForm->validate();

app/Livewire/People/Add/Partner.php

@@ -114,7 +114,7 @@ public function updatedUploads(): void
             ->toArray();
     }
 
-    public function savePartner()
+    public function savePartner(): void
     {
         if ($this->isDirty()) {
             $validated = $this->partnerForm->validate();

app/Livewire/People/Add/Person.php

@@ -88,7 +88,7 @@ public function updatedUploads(): void
             ->toArray();
     }
 
-    public function savePerson()
+    public function savePerson(): void
     {
         if ($this->isDirty()) {
             $validated = $this->personForm->validate();

app/Livewire/People/Edit/Files.php

@@ -86,7 +86,7 @@ public function updatedUploads(): void
             ->toArray();
     }
 
-    public function save()
+    public function save(): void
     {
         foreach ($this->uploads as $upload) {
             $file = $this->person->addMedia($upload)->toMediaCollection('files', 'files');

app/Livewire/People/Profile.php

@@ -31,7 +31,7 @@ public function confirmDeletion(): void
         $this->deleteConfirmed = true;
     }
 
-    public function deletePerson()
+    public function deletePerson(): void
     {
         if ($this->person->isDeletable()) {
             $this->deletePersonPhotos();
@@ -46,9 +46,11 @@ public function deletePerson()
 
     private function deletePersonPhotos(): void
     {
-        foreach (config('app.photo_folders') as $folder) {
-            File::delete(File::glob(storage_path("app/public/{$folder}/" . $this->person->team_id . '/' . $this->person->id . '_*.webp')));
-        }
+        defer(function (): void {
+            foreach (config('app.photo_folders') as $folder) {
+                File::delete(File::glob(storage_path("app/public/{$folder}/" . $this->person->team_id . '/' . $this->person->id . '_*.webp')));
+            }
+        });
     }
 
     // ------------------------------------------------------------------------------

app/Models/Couple.php

@@ -59,7 +59,7 @@ public function getActivitylogOptions(): LogOptions
             ->dontSubmitEmptyLogs();
     }
 
-    public function tapActivity(Activity $activity, string $eventName)
+    public function tapActivity(Activity $activity, string $eventName): void
     {
         $activity->team_id = auth()->user()?->currentTeam?->id ?? null;
     }

app/Models/Person.php

@@ -111,7 +111,7 @@ public function getActivitylogOptions(): LogOptions
             ->dontSubmitEmptyLogs();
     }
 
-    public function tapActivity(Activity $activity, string $eventName)
+    public function tapActivity(Activity $activity, string $eventName): void
     {
         $activity->team_id = auth()->user()?->currentTeam?->id ?? null;
     }
@@ -547,7 +547,7 @@ public function getMetadataValue($key = null): ?string
     }
 
     /* updates, deletes if empty or creates 1 to n METADATA related to the person */
-    public function updateMetadata(Collection $personMetadata)
+    public function updateMetadata(Collection $personMetadata): void
     {
         // First, delete any existing metadata where the value is empty
         foreach (PersonMetadata::METADATA_KEYS as $key) {

app/Models/PersonMetadata.php

@@ -45,7 +45,7 @@ public function getActivitylogOptions(): LogOptions
             ->dontSubmitEmptyLogs();
     }
 
-    public function tapActivity(Activity $activity, string $eventName)
+    public function tapActivity(Activity $activity, string $eventName): void
     {
         $activity->team_id = auth()->user()?->currentTeam?->id ?? null;
     }