Skip to content

Commit e87c5a9

Browse files
committed
Merge branch 'main' of github.com:MIT-Emerging-Talent/ET6-CDSP-starter into MIT-Emerging-Talent-main
2 parents 6db396b + 7d219a3 commit e87c5a9

File tree

11 files changed

+55
-10
lines changed

11 files changed

+55
-10
lines changed

.github/workflows/ci-checks.yml

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ jobs:
4848
pip install pylint
4949
shell: bash
5050
- name: Python - Check Linting - pylint
51-
run: "pylint solutions tests || echo '::warning title=Pylint Error(s)::Discuss solutions and trade-offs in code review.'"
51+
run: "pylint **/*.py --ignore-paths=env,venv,.env,.venv,__pycache__,.git || echo '::warning title=Pylint Error(s)::Discuss solutions and trade-offs in code review.'"
5252
shell: bash
5353

5454
py_tests:
@@ -78,3 +78,21 @@ jobs:
7878
if: steps.check_tests.outputs.has_tests == 'true'
7979
run: python -m unittest
8080
shell: bash
81+
82+
py_notebook_linting:
83+
runs-on: ubuntu-latest
84+
steps:
85+
- uses: actions/checkout@v4
86+
- name: python version
87+
run: python --version
88+
shell: bash
89+
if: always()
90+
- name: install nbqa
91+
run: |
92+
python - m pip install --upgrade pip
93+
pip install pylint
94+
pip install nbqa
95+
shell: bash
96+
- name: Python Notebooks - Check Linting - nbqa
97+
run: "nbqa pylint *.ipynb || echo '::warning title=NoteBook QA Error(s)::Discuss solutions and trade-offs in code review.'"
98+
shell: bash

collaboration/guide/0_repository_setup.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@ it for collaboration:
2020
- _Issues_
2121
- _Projects_
2222
- _Always suggest updating pull request branches_
23+
- Enable CI Checks
24+
- Under the _Actions_ tab:
25+
- Enable workflows to ensure CI checks run on all pushes and pull requests.
26+
_(Note: If workflows are disabled, CI checks won’t trigger until enabled.)_
2327
- Collaboration Settings
2428
- Require a code review for PRs to `main`/`master`
2529
([owanateamachree](https://owanateamachree.medium.com/how-to-protect-the-master-branch-on-github-ab85e9b6b03),

collaboration/retrospectives/0_cross_cultural_collaboration.md

Whitespace-only changes.

collaboration/retrospectives/1_problem_identification.md

Whitespace-only changes.

collaboration/retrospectives/2_data_collection.md

Whitespace-only changes.

collaboration/retrospectives/3_data_analysis.md

Whitespace-only changes.

collaboration/retrospectives/4_communicating_results.md

Whitespace-only changes.

collaboration/retrospectives/5_final_presentation.md

Whitespace-only changes.
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
# Retrospectives
2+
3+
Retrospective documents for each milestone of the CDSP.
File renamed without changes.

0 commit comments

Comments
 (0)